Issue/7152 #7214
|
|
@ -32,8 +32,6 @@ function DownloadProgress({ byOutpoint, primary, playing, currentTheme, stopDown
|
|||
this name sounds like a function rather than an array. this name sounds like a function rather than an array.
downloadsToUpdate?
this could use a comment this could use a comment
(Object.keys(props.downloadList): any).map(..) (Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)
does our Button component work here? does our Button component work here?
```
<Button
iconSize={24}
button="close" <- or your className?
aria-label={__('Close')}
icon={ICONS.REMOVE}
onClick={...}
/>
```
All strings can be wrapped in __('some text') for i18n All strings can be wrapped in __('some text') for i18n
This could be <Button button="link" label={__('Yes')} /> if it works well. This could be <Button button="link" label={__('Yes')} /> if it works well.
This {title} should probably link to the FilePage for the content url This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like
```
<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
```
Neat to see this done from scratch and in about the same way! Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate. I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
we can persist this using our usePersistedState() hook we can persist this using our usePersistedState() hook
something weird happens here that crashes the app when I play a video. something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
this name sounds like a function rather than an array. this name sounds like a function rather than an array.
downloadsToUpdate?
this could use a comment this could use a comment
|
||||
cancelHash[hash] = value;
|
||||
};
|
||||
|
||||
useEffect(() => {}, []);
|
||||
|
(Object.keys(props.downloadList): any).map(..) (Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)
does our Button component work here? does our Button component work here?
```
<Button
iconSize={24}
button="close" <- or your className?
aria-label={__('Close')}
icon={ICONS.REMOVE}
onClick={...}
/>
```
All strings can be wrapped in __('some text') for i18n All strings can be wrapped in __('some text') for i18n
This could be <Button button="link" label={__('Yes')} /> if it works well. This could be <Button button="link" label={__('Yes')} /> if it works well.
This {title} should probably link to the FilePage for the content url This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like
```
<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
```
Neat to see this done from scratch and in about the same way! Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate. I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
we can persist this using our usePersistedState() hook we can persist this using our usePersistedState() hook
something weird happens here that crashes the app when I play a video. something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
this name sounds like a function rather than an array. this name sounds like a function rather than an array.
downloadsToUpdate?
this could use a comment this could use a comment
|
||||
|
||||
|
(Object.keys(props.downloadList): any).map(..) (Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)
does our Button component work here? does our Button component work here?
```
<Button
iconSize={24}
button="close" <- or your className?
aria-label={__('Close')}
icon={ICONS.REMOVE}
onClick={...}
/>
```
All strings can be wrapped in __('some text') for i18n All strings can be wrapped in __('some text') for i18n
This could be <Button button="link" label={__('Yes')} /> if it works well. This could be <Button button="link" label={__('Yes')} /> if it works well.
This {title} should probably link to the FilePage for the content url This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like
```
<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
```
Neat to see this done from scratch and in about the same way! Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate. I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
we can persist this using our usePersistedState() hook we can persist this using our usePersistedState() hook
something weird happens here that crashes the app when I play a video. something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
this name sounds like a function rather than an array. this name sounds like a function rather than an array.
downloadsToUpdate?
this could use a comment this could use a comment
|
||||
const handleStopDownload = (outpoint) => {
|
||||
const updated = [...downloading];
|
||||
removeItem(updated, outpoint);
|
||||
|
|
@ -42,7 +40,7 @@ function DownloadProgress({ byOutpoint, primary, playing, currentTheme, stopDown
|
|||
|
(Object.keys(props.downloadList): any).map(..) (Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)
does our Button component work here? does our Button component work here?
```
<Button
iconSize={24}
button="close" <- or your className?
aria-label={__('Close')}
icon={ICONS.REMOVE}
onClick={...}
/>
```
All strings can be wrapped in __('some text') for i18n All strings can be wrapped in __('some text') for i18n
This could be <Button button="link" label={__('Yes')} /> if it works well. This could be <Button button="link" label={__('Yes')} /> if it works well.
This {title} should probably link to the FilePage for the content url This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like
```
<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
```
Neat to see this done from scratch and in about the same way! Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate. I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
we can persist this using our usePersistedState() hook we can persist this using our usePersistedState() hook
something weird happens here that crashes the app when I play a video. something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
this name sounds like a function rather than an array. this name sounds like a function rather than an array.
downloadsToUpdate?
this could use a comment this could use a comment
(Object.keys(props.downloadList): any).map(..) (Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)
does our Button component work here? does our Button component work here?
```
<Button
iconSize={24}
button="close" <- or your className?
aria-label={__('Close')}
icon={ICONS.REMOVE}
onClick={...}
/>
```
All strings can be wrapped in __('some text') for i18n All strings can be wrapped in __('some text') for i18n
This could be <Button button="link" label={__('Yes')} /> if it works well. This could be <Button button="link" label={__('Yes')} /> if it works well.
This {title} should probably link to the FilePage for the content url This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like
```
<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
```
Neat to see this done from scratch and in about the same way! Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate. I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
we can persist this using our usePersistedState() hook we can persist this using our usePersistedState() hook
something weird happens here that crashes the app when I play a video. something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
this name sounds like a function rather than an array. this name sounds like a function rather than an array.
downloadsToUpdate?
this could use a comment this could use a comment
|
||||
};
|
||||
|
||||
const runningByOutpoint = {};
|
||||
const updateDownloading = [...downloading];
|
||||
|
(Object.keys(props.downloadList): any).map(..) (Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)
does our Button component work here? does our Button component work here?
```
<Button
iconSize={24}
button="close" <- or your className?
aria-label={__('Close')}
icon={ICONS.REMOVE}
onClick={...}
/>
```
All strings can be wrapped in __('some text') for i18n All strings can be wrapped in __('some text') for i18n
This could be <Button button="link" label={__('Yes')} /> if it works well. This could be <Button button="link" label={__('Yes')} /> if it works well.
This {title} should probably link to the FilePage for the content url This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like
```
<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
```
Neat to see this done from scratch and in about the same way! Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate. I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
we can persist this using our usePersistedState() hook we can persist this using our usePersistedState() hook
something weird happens here that crashes the app when I play a video. something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
this name sounds like a function rather than an array. this name sounds like a function rather than an array.
downloadsToUpdate?
this could use a comment this could use a comment
|
||||
const currentDownloading = [...downloading];
|
||||
|
(Object.keys(props.downloadList): any).map(..) (Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)
does our Button component work here? does our Button component work here?
```
<Button
iconSize={24}
button="close" <- or your className?
aria-label={__('Close')}
icon={ICONS.REMOVE}
onClick={...}
/>
```
All strings can be wrapped in __('some text') for i18n All strings can be wrapped in __('some text') for i18n
This could be <Button button="link" label={__('Yes')} /> if it works well. This could be <Button button="link" label={__('Yes')} /> if it works well.
This {title} should probably link to the FilePage for the content url This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like
```
<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
```
Neat to see this done from scratch and in about the same way! Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate. I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
we can persist this using our usePersistedState() hook we can persist this using our usePersistedState() hook
something weird happens here that crashes the app when I play a video. something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
this name sounds like a function rather than an array. this name sounds like a function rather than an array.
downloadsToUpdate?
this could use a comment this could use a comment
|
||||
|
||||
for (const key in byOutpoint) {
|
||||
const item = byOutpoint[key];
|
||||
|
|
@ -53,18 +51,18 @@ function DownloadProgress({ byOutpoint, primary, playing, currentTheme, stopDown
|
|||
|
(Object.keys(props.downloadList): any).map(..) (Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)
does our Button component work here? does our Button component work here?
```
<Button
iconSize={24}
button="close" <- or your className?
aria-label={__('Close')}
icon={ICONS.REMOVE}
onClick={...}
/>
```
All strings can be wrapped in __('some text') for i18n All strings can be wrapped in __('some text') for i18n
This could be <Button button="link" label={__('Yes')} /> if it works well. This could be <Button button="link" label={__('Yes')} /> if it works well.
This {title} should probably link to the FilePage for the content url This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like
```
<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
```
Neat to see this done from scratch and in about the same way! Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate. I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
we can persist this using our usePersistedState() hook we can persist this using our usePersistedState() hook
something weird happens here that crashes the app when I play a video. something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
this name sounds like a function rather than an array. this name sounds like a function rather than an array.
downloadsToUpdate?
this could use a comment this could use a comment
(Object.keys(props.downloadList): any).map(..) (Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)
does our Button component work here? does our Button component work here?
```
<Button
iconSize={24}
button="close" <- or your className?
aria-label={__('Close')}
icon={ICONS.REMOVE}
onClick={...}
/>
```
All strings can be wrapped in __('some text') for i18n All strings can be wrapped in __('some text') for i18n
This could be <Button button="link" label={__('Yes')} /> if it works well. This could be <Button button="link" label={__('Yes')} /> if it works well.
This {title} should probably link to the FilePage for the content url This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like
```
<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
```
Neat to see this done from scratch and in about the same way! Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate. I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
we can persist this using our usePersistedState() hook we can persist this using our usePersistedState() hook
something weird happens here that crashes the app when I play a video. something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
this name sounds like a function rather than an array. this name sounds like a function rather than an array.
downloadsToUpdate?
this could use a comment this could use a comment
|
||||
.filter((outpoint) => downloading.indexOf(outpoint) === -1)
|
||||
.map((outpoint) => {
|
||||
if (primary.outpoint !== outpoint && playing.outpoint !== outpoint) {
|
||||
updateDownloading.push(outpoint);
|
||||
|
(Object.keys(props.downloadList): any).map(..) (Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)
does our Button component work here? does our Button component work here?
```
<Button
iconSize={24}
button="close" <- or your className?
aria-label={__('Close')}
icon={ICONS.REMOVE}
onClick={...}
/>
```
All strings can be wrapped in __('some text') for i18n All strings can be wrapped in __('some text') for i18n
This could be <Button button="link" label={__('Yes')} /> if it works well. This could be <Button button="link" label={__('Yes')} /> if it works well.
This {title} should probably link to the FilePage for the content url This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like
```
<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
```
Neat to see this done from scratch and in about the same way! Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate. I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
we can persist this using our usePersistedState() hook we can persist this using our usePersistedState() hook
something weird happens here that crashes the app when I play a video. something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
this name sounds like a function rather than an array. this name sounds like a function rather than an array.
downloadsToUpdate?
this could use a comment this could use a comment
|
||||
currentDownloading.push(outpoint);
|
||||
|
(Object.keys(props.downloadList): any).map(..) (Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)
does our Button component work here? does our Button component work here?
```
<Button
iconSize={24}
button="close" <- or your className?
aria-label={__('Close')}
icon={ICONS.REMOVE}
onClick={...}
/>
```
All strings can be wrapped in __('some text') for i18n All strings can be wrapped in __('some text') for i18n
This could be <Button button="link" label={__('Yes')} /> if it works well. This could be <Button button="link" label={__('Yes')} /> if it works well.
This {title} should probably link to the FilePage for the content url This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like
```
<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
```
Neat to see this done from scratch and in about the same way! Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate. I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
we can persist this using our usePersistedState() hook we can persist this using our usePersistedState() hook
something weird happens here that crashes the app when I play a video. something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
this name sounds like a function rather than an array. this name sounds like a function rather than an array.
downloadsToUpdate?
this could use a comment this could use a comment
|
||||
}
|
||||
});
|
||||
|
||||
downloading
|
||||
.filter((outpoint) => (byOutpoint[outpoint] && byOutpoint[outpoint].status !== 'running') || !byOutpoint[outpoint])
|
||||
.map((outpoint) => {
|
||||
removeItem(updateDownloading, outpoint);
|
||||
|
(Object.keys(props.downloadList): any).map(..) (Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)
does our Button component work here? does our Button component work here?
```
<Button
iconSize={24}
button="close" <- or your className?
aria-label={__('Close')}
icon={ICONS.REMOVE}
onClick={...}
/>
```
All strings can be wrapped in __('some text') for i18n All strings can be wrapped in __('some text') for i18n
This could be <Button button="link" label={__('Yes')} /> if it works well. This could be <Button button="link" label={__('Yes')} /> if it works well.
This {title} should probably link to the FilePage for the content url This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like
```
<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
```
Neat to see this done from scratch and in about the same way! Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate. I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
we can persist this using our usePersistedState() hook we can persist this using our usePersistedState() hook
something weird happens here that crashes the app when I play a video. something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
this name sounds like a function rather than an array. this name sounds like a function rather than an array.
downloadsToUpdate?
this could use a comment this could use a comment
|
||||
removeItem(currentDownloading, outpoint);
|
||||
|
(Object.keys(props.downloadList): any).map(..) (Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)
does our Button component work here? does our Button component work here?
```
<Button
iconSize={24}
button="close" <- or your className?
aria-label={__('Close')}
icon={ICONS.REMOVE}
onClick={...}
/>
```
All strings can be wrapped in __('some text') for i18n All strings can be wrapped in __('some text') for i18n
This could be <Button button="link" label={__('Yes')} /> if it works well. This could be <Button button="link" label={__('Yes')} /> if it works well.
This {title} should probably link to the FilePage for the content url This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like
```
<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
```
Neat to see this done from scratch and in about the same way! Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate. I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
we can persist this using our usePersistedState() hook we can persist this using our usePersistedState() hook
something weird happens here that crashes the app when I play a video. something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
this name sounds like a function rather than an array. this name sounds like a function rather than an array.
downloadsToUpdate?
this could use a comment this could use a comment
|
||||
});
|
||||
if (!areEqual(downloading, updateDownloading)) setDownloading(updateDownloading);
|
||||
|
(Object.keys(props.downloadList): any).map(..) (Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)
does our Button component work here? does our Button component work here?
```
<Button
iconSize={24}
button="close" <- or your className?
aria-label={__('Close')}
icon={ICONS.REMOVE}
onClick={...}
/>
```
All strings can be wrapped in __('some text') for i18n All strings can be wrapped in __('some text') for i18n
This could be <Button button="link" label={__('Yes')} /> if it works well. This could be <Button button="link" label={__('Yes')} /> if it works well.
This {title} should probably link to the FilePage for the content url This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like
```
<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
```
Neat to see this done from scratch and in about the same way! Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate. I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
we can persist this using our usePersistedState() hook we can persist this using our usePersistedState() hook
something weird happens here that crashes the app when I play a video. something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
this name sounds like a function rather than an array. this name sounds like a function rather than an array.
downloadsToUpdate?
this could use a comment this could use a comment
|
||||
if (!areEqual(downloading, currentDownloading)) setDownloading(currentDownloading);
|
||||
|
(Object.keys(props.downloadList): any).map(..) (Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)
does our Button component work here? does our Button component work here?
```
<Button
iconSize={24}
button="close" <- or your className?
aria-label={__('Close')}
icon={ICONS.REMOVE}
onClick={...}
/>
```
All strings can be wrapped in __('some text') for i18n All strings can be wrapped in __('some text') for i18n
This could be <Button button="link" label={__('Yes')} /> if it works well. This could be <Button button="link" label={__('Yes')} /> if it works well.
This {title} should probably link to the FilePage for the content url This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like
```
<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
```
Neat to see this done from scratch and in about the same way! Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate. I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
we can persist this using our usePersistedState() hook we can persist this using our usePersistedState() hook
something weird happens here that crashes the app when I play a video. something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
this name sounds like a function rather than an array. this name sounds like a function rather than an array.
downloadsToUpdate?
this could use a comment this could use a comment
|
||||
|
||||
if (updateDownloading.length === 0) return null;
|
||||
|
(Object.keys(props.downloadList): any).map(..) (Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)
does our Button component work here? does our Button component work here?
```
<Button
iconSize={24}
button="close" <- or your className?
aria-label={__('Close')}
icon={ICONS.REMOVE}
onClick={...}
/>
```
All strings can be wrapped in __('some text') for i18n All strings can be wrapped in __('some text') for i18n
This could be <Button button="link" label={__('Yes')} /> if it works well. This could be <Button button="link" label={__('Yes')} /> if it works well.
This {title} should probably link to the FilePage for the content url This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like
```
<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
```
Neat to see this done from scratch and in about the same way! Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate. I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
we can persist this using our usePersistedState() hook we can persist this using our usePersistedState() hook
something weird happens here that crashes the app when I play a video. something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
this name sounds like a function rather than an array. this name sounds like a function rather than an array.
downloadsToUpdate?
this could use a comment this could use a comment
|
||||
if (currentDownloading.length === 0) return null;
|
||||
|
(Object.keys(props.downloadList): any).map(..) (Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)
does our Button component work here? does our Button component work here?
```
<Button
iconSize={24}
button="close" <- or your className?
aria-label={__('Close')}
icon={ICONS.REMOVE}
onClick={...}
/>
```
All strings can be wrapped in __('some text') for i18n All strings can be wrapped in __('some text') for i18n
This could be <Button button="link" label={__('Yes')} /> if it works well. This could be <Button button="link" label={__('Yes')} /> if it works well.
This {title} should probably link to the FilePage for the content url This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like
```
<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
```
Neat to see this done from scratch and in about the same way! Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate. I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
we can persist this using our usePersistedState() hook we can persist this using our usePersistedState() hook
something weird happens here that crashes the app when I play a video. something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
this name sounds like a function rather than an array. this name sounds like a function rather than an array.
downloadsToUpdate?
this could use a comment this could use a comment
|
||||
|
||||
if (playing.outpoint !== prevPlaying.outpoint) {
|
||||
if (downloading.includes(prevPlaying.outpoint)) {
|
||||
|
|
@ -84,7 +82,7 @@ function DownloadProgress({ byOutpoint, primary, playing, currentTheme, stopDown
|
|||
|
(Object.keys(props.downloadList): any).map(..) (Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)
does our Button component work here? does our Button component work here?
```
<Button
iconSize={24}
button="close" <- or your className?
aria-label={__('Close')}
icon={ICONS.REMOVE}
onClick={...}
/>
```
All strings can be wrapped in __('some text') for i18n All strings can be wrapped in __('some text') for i18n
This could be <Button button="link" label={__('Yes')} /> if it works well. This could be <Button button="link" label={__('Yes')} /> if it works well.
This {title} should probably link to the FilePage for the content url This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like
```
<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
```
Neat to see this done from scratch and in about the same way! Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate. I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
we can persist this using our usePersistedState() hook we can persist this using our usePersistedState() hook
something weird happens here that crashes the app when I play a video. something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
this name sounds like a function rather than an array. this name sounds like a function rather than an array.
downloadsToUpdate?
this could use a comment this could use a comment
(Object.keys(props.downloadList): any).map(..) (Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)
does our Button component work here? does our Button component work here?
```
<Button
iconSize={24}
button="close" <- or your className?
aria-label={__('Close')}
icon={ICONS.REMOVE}
onClick={...}
/>
```
All strings can be wrapped in __('some text') for i18n All strings can be wrapped in __('some text') for i18n
This could be <Button button="link" label={__('Yes')} /> if it works well. This could be <Button button="link" label={__('Yes')} /> if it works well.
This {title} should probably link to the FilePage for the content url This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like
```
<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
```
Neat to see this done from scratch and in about the same way! Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate. I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
we can persist this using our usePersistedState() hook we can persist this using our usePersistedState() hook
something weird happens here that crashes the app when I play a video. something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
this name sounds like a function rather than an array. this name sounds like a function rather than an array.
downloadsToUpdate?
this could use a comment this could use a comment
|
||||
setPrevPrimary(primary);
|
||||
}
|
||||
|
||||
updateDownloading.map((outpoint) => {
|
||||
|
(Object.keys(props.downloadList): any).map(..) (Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)
does our Button component work here? does our Button component work here?
```
<Button
iconSize={24}
button="close" <- or your className?
aria-label={__('Close')}
icon={ICONS.REMOVE}
onClick={...}
/>
```
All strings can be wrapped in __('some text') for i18n All strings can be wrapped in __('some text') for i18n
This could be <Button button="link" label={__('Yes')} /> if it works well. This could be <Button button="link" label={__('Yes')} /> if it works well.
This {title} should probably link to the FilePage for the content url This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like
```
<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
```
Neat to see this done from scratch and in about the same way! Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate. I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
we can persist this using our usePersistedState() hook we can persist this using our usePersistedState() hook
something weird happens here that crashes the app when I play a video. something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
this name sounds like a function rather than an array. this name sounds like a function rather than an array.
downloadsToUpdate?
this could use a comment this could use a comment
|
||||
currentDownloading.map((outpoint) => {
|
||||
|
(Object.keys(props.downloadList): any).map(..) (Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)
does our Button component work here? does our Button component work here?
```
<Button
iconSize={24}
button="close" <- or your className?
aria-label={__('Close')}
icon={ICONS.REMOVE}
onClick={...}
/>
```
All strings can be wrapped in __('some text') for i18n All strings can be wrapped in __('some text') for i18n
This could be <Button button="link" label={__('Yes')} /> if it works well. This could be <Button button="link" label={__('Yes')} /> if it works well.
This {title} should probably link to the FilePage for the content url This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like
```
<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
```
Neat to see this done from scratch and in about the same way! Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate. I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
we can persist this using our usePersistedState() hook we can persist this using our usePersistedState() hook
something weird happens here that crashes the app when I play a video. something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
this name sounds like a function rather than an array. this name sounds like a function rather than an array.
downloadsToUpdate?
this could use a comment this could use a comment
|
||||
if (!initDownloadingHash[outpoint]) {
|
||||
initDownloadingHash[outpoint] = true;
|
||||
doContinueDownloading(outpoint, false);
|
||||
|
|
@ -102,7 +100,7 @@ function DownloadProgress({ byOutpoint, primary, playing, currentTheme, stopDown
|
|||
|
(Object.keys(props.downloadList): any).map(..) (Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)
does our Button component work here? does our Button component work here?
```
<Button
iconSize={24}
button="close" <- or your className?
aria-label={__('Close')}
icon={ICONS.REMOVE}
onClick={...}
/>
```
All strings can be wrapped in __('some text') for i18n All strings can be wrapped in __('some text') for i18n
This could be <Button button="link" label={__('Yes')} /> if it works well. This could be <Button button="link" label={__('Yes')} /> if it works well.
This {title} should probably link to the FilePage for the content url This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like
```
<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
```
Neat to see this done from scratch and in about the same way! Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate. I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
we can persist this using our usePersistedState() hook we can persist this using our usePersistedState() hook
something weird happens here that crashes the app when I play a video. something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
this name sounds like a function rather than an array. this name sounds like a function rather than an array.
downloadsToUpdate?
this could use a comment this could use a comment
(Object.keys(props.downloadList): any).map(..) (Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)
does our Button component work here? does our Button component work here?
```
<Button
iconSize={24}
button="close" <- or your className?
aria-label={__('Close')}
icon={ICONS.REMOVE}
onClick={...}
/>
```
All strings can be wrapped in __('some text') for i18n All strings can be wrapped in __('some text') for i18n
This could be <Button button="link" label={__('Yes')} /> if it works well. This could be <Button button="link" label={__('Yes')} /> if it works well.
This {title} should probably link to the FilePage for the content url This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like
```
<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
```
Neat to see this done from scratch and in about the same way! Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate. I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
we can persist this using our usePersistedState() hook we can persist this using our usePersistedState() hook
something weird happens here that crashes the app when I play a video. something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
this name sounds like a function rather than an array. this name sounds like a function rather than an array.
downloadsToUpdate?
this could use a comment this could use a comment
|
||||
>
|
||||
<div className="download-progress__current-downloading">
|
||||
<span className="notification__bubble">
|
||||
|
I think we want information about how many, but not urgent distraction of bouncing. And maybe not red (but maybe?) I think we want information about how many, but not urgent distraction of bouncing. And maybe not red (but maybe?)
|
||||
<span className="notification__count">{updateDownloading.length}</span>
|
||||
|
(Object.keys(props.downloadList): any).map(..) (Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)
does our Button component work here? does our Button component work here?
```
<Button
iconSize={24}
button="close" <- or your className?
aria-label={__('Close')}
icon={ICONS.REMOVE}
onClick={...}
/>
```
All strings can be wrapped in __('some text') for i18n All strings can be wrapped in __('some text') for i18n
This could be <Button button="link" label={__('Yes')} /> if it works well. This could be <Button button="link" label={__('Yes')} /> if it works well.
This {title} should probably link to the FilePage for the content url This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like
```
<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
```
Neat to see this done from scratch and in about the same way! Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate. I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
we can persist this using our usePersistedState() hook we can persist this using our usePersistedState() hook
something weird happens here that crashes the app when I play a video. something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
this name sounds like a function rather than an array. this name sounds like a function rather than an array.
downloadsToUpdate?
this could use a comment this could use a comment
|
||||
<span className="notification__count">{currentDownloading.length}</span>
|
||||
|
(Object.keys(props.downloadList): any).map(..) (Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)
does our Button component work here? does our Button component work here?
```
<Button
iconSize={24}
button="close" <- or your className?
aria-label={__('Close')}
icon={ICONS.REMOVE}
onClick={...}
/>
```
All strings can be wrapped in __('some text') for i18n All strings can be wrapped in __('some text') for i18n
This could be <Button button="link" label={__('Yes')} /> if it works well. This could be <Button button="link" label={__('Yes')} /> if it works well.
This {title} should probably link to the FilePage for the content url This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like
```
<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
```
Neat to see this done from scratch and in about the same way! Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate. I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
we can persist this using our usePersistedState() hook we can persist this using our usePersistedState() hook
something weird happens here that crashes the app when I play a video. something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
this name sounds like a function rather than an array. this name sounds like a function rather than an array.
downloadsToUpdate?
this could use a comment this could use a comment
|
||||
</span>
|
||||
</div>
|
||||
</Button>
|
||||
|
|
@ -116,7 +114,7 @@ function DownloadProgress({ byOutpoint, primary, playing, currentTheme, stopDown
|
|||
|
(Object.keys(props.downloadList): any).map(..) (Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)
does our Button component work here? does our Button component work here?
```
<Button
iconSize={24}
button="close" <- or your className?
aria-label={__('Close')}
icon={ICONS.REMOVE}
onClick={...}
/>
```
All strings can be wrapped in __('some text') for i18n All strings can be wrapped in __('some text') for i18n
This could be <Button button="link" label={__('Yes')} /> if it works well. This could be <Button button="link" label={__('Yes')} /> if it works well.
This {title} should probably link to the FilePage for the content url This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like
```
<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
```
Neat to see this done from scratch and in about the same way! Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate. I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
we can persist this using our usePersistedState() hook we can persist this using our usePersistedState() hook
something weird happens here that crashes the app when I play a video. something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
this name sounds like a function rather than an array. this name sounds like a function rather than an array.
downloadsToUpdate?
this could use a comment this could use a comment
(Object.keys(props.downloadList): any).map(..) (Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)
does our Button component work here? does our Button component work here?
```
<Button
iconSize={24}
button="close" <- or your className?
aria-label={__('Close')}
icon={ICONS.REMOVE}
onClick={...}
/>
```
All strings can be wrapped in __('some text') for i18n All strings can be wrapped in __('some text') for i18n
This could be <Button button="link" label={__('Yes')} /> if it works well. This could be <Button button="link" label={__('Yes')} /> if it works well.
This {title} should probably link to the FilePage for the content url This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like
```
<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
```
Neat to see this done from scratch and in about the same way! Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate. I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
we can persist this using our usePersistedState() hook we can persist this using our usePersistedState() hook
something weird happens here that crashes the app when I play a video. something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
this name sounds like a function rather than an array. this name sounds like a function rather than an array.
downloadsToUpdate?
this could use a comment this could use a comment
|
||||
<div />
|
||||
</Button>
|
||||
|
||||
{updateDownloading.map((outpoint, index) => {
|
||||
|
(Object.keys(props.downloadList): any).map(..) (Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)
does our Button component work here? does our Button component work here?
```
<Button
iconSize={24}
button="close" <- or your className?
aria-label={__('Close')}
icon={ICONS.REMOVE}
onClick={...}
/>
```
All strings can be wrapped in __('some text') for i18n All strings can be wrapped in __('some text') for i18n
This could be <Button button="link" label={__('Yes')} /> if it works well. This could be <Button button="link" label={__('Yes')} /> if it works well.
This {title} should probably link to the FilePage for the content url This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like
```
<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
```
Neat to see this done from scratch and in about the same way! Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate. I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
we can persist this using our usePersistedState() hook we can persist this using our usePersistedState() hook
something weird happens here that crashes the app when I play a video. something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
this name sounds like a function rather than an array. this name sounds like a function rather than an array.
downloadsToUpdate?
this could use a comment this could use a comment
|
||||
{currentDownloading.map((outpoint, index) => {
|
||||
|
(Object.keys(props.downloadList): any).map(..) (Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)
does our Button component work here? does our Button component work here?
```
<Button
iconSize={24}
button="close" <- or your className?
aria-label={__('Close')}
icon={ICONS.REMOVE}
onClick={...}
/>
```
All strings can be wrapped in __('some text') for i18n All strings can be wrapped in __('some text') for i18n
This could be <Button button="link" label={__('Yes')} /> if it works well. This could be <Button button="link" label={__('Yes')} /> if it works well.
This {title} should probably link to the FilePage for the content url This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like
```
<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
```
Neat to see this done from scratch and in about the same way! Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate. I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
we can persist this using our usePersistedState() hook we can persist this using our usePersistedState() hook
something weird happens here that crashes the app when I play a video. something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
this name sounds like a function rather than an array. this name sounds like a function rather than an array.
downloadsToUpdate?
this could use a comment this could use a comment
|
||||
const item = runningByOutpoint[outpoint];
|
||||
let releaseTime = '';
|
||||
let isPlaying = false;
|
||||
|
|
|
|||
|
(Object.keys(props.downloadList): any).map(..) (Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)
does our Button component work here? does our Button component work here?
```
<Button
iconSize={24}
button="close" <- or your className?
aria-label={__('Close')}
icon={ICONS.REMOVE}
onClick={...}
/>
```
All strings can be wrapped in __('some text') for i18n All strings can be wrapped in __('some text') for i18n
This could be <Button button="link" label={__('Yes')} /> if it works well. This could be <Button button="link" label={__('Yes')} /> if it works well.
This {title} should probably link to the FilePage for the content url This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like
```
<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
```
Neat to see this done from scratch and in about the same way! Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate. I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
we can persist this using our usePersistedState() hook we can persist this using our usePersistedState() hook
something weird happens here that crashes the app when I play a video. something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
this name sounds like a function rather than an array. this name sounds like a function rather than an array.
downloadsToUpdate?
this could use a comment this could use a comment
(Object.keys(props.downloadList): any).map(..) (Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)
does our Button component work here? does our Button component work here?
```
<Button
iconSize={24}
button="close" <- or your className?
aria-label={__('Close')}
icon={ICONS.REMOVE}
onClick={...}
/>
```
All strings can be wrapped in __('some text') for i18n All strings can be wrapped in __('some text') for i18n
This could be <Button button="link" label={__('Yes')} /> if it works well. This could be <Button button="link" label={__('Yes')} /> if it works well.
This {title} should probably link to the FilePage for the content url This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like
```
<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
```
Neat to see this done from scratch and in about the same way! Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate. I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
we can persist this using our usePersistedState() hook we can persist this using our usePersistedState() hook
something weird happens here that crashes the app when I play a video. something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
this name sounds like a function rather than an array. this name sounds like a function rather than an array.
downloadsToUpdate?
this could use a comment this could use a comment
|
||||
|
|
@ -7,8 +7,8 @@
|
|||
|
We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode. We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
I like this color, but maybe it should use var(--color-primary)? I like this color, but maybe it should use var(--color-primary)?
dark mode, unless my .env is messed up dark mode, unless my .env is messed up
http://getbem.com/naming/ http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container
having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app? having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
try var(--border-radius) try var(--border-radius)
try var(--border-radius) try var(--border-radius)
We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode. We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
I like this color, but maybe it should use var(--color-primary)? I like this color, but maybe it should use var(--color-primary)?
dark mode, unless my .env is messed up dark mode, unless my .env is messed up
http://getbem.com/naming/ http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container
having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app? having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
try var(--border-radius) try var(--border-radius)
try var(--border-radius) try var(--border-radius)
|
||||
display: flex;
|
||||
flex-direction: column;
|
||||
background-color: var(--color-header-background); //var(--color-gray-9):dark-mode
|
||||
border-radius: 10px;
|
||||
|
We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode. We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
I like this color, but maybe it should use var(--color-primary)? I like this color, but maybe it should use var(--color-primary)?
dark mode, unless my .env is messed up dark mode, unless my .env is messed up
http://getbem.com/naming/ http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container
having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app? having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
try var(--border-radius) try var(--border-radius)
try var(--border-radius) try var(--border-radius)
|
||||
border: 1px solid var(--color-gray-3);
|
||||
|
We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode. We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
I like this color, but maybe it should use var(--color-primary)? I like this color, but maybe it should use var(--color-primary)?
dark mode, unless my .env is messed up dark mode, unless my .env is messed up
http://getbem.com/naming/ http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container
having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app? having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
try var(--border-radius) try var(--border-radius)
try var(--border-radius) try var(--border-radius)
|
||||
border-radius: var(--border-radius);
|
||||
|
We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode. We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
I like this color, but maybe it should use var(--color-primary)? I like this color, but maybe it should use var(--color-primary)?
dark mode, unless my .env is messed up dark mode, unless my .env is messed up
http://getbem.com/naming/ http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container
having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app? having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
try var(--border-radius) try var(--border-radius)
try var(--border-radius) try var(--border-radius)
|
||||
// border: 1px solid var(--color-gray-3);
|
||||
|
We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode. We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
I like this color, but maybe it should use var(--color-primary)? I like this color, but maybe it should use var(--color-primary)?
dark mode, unless my .env is messed up dark mode, unless my .env is messed up
http://getbem.com/naming/ http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container
having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app? having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
try var(--border-radius) try var(--border-radius)
try var(--border-radius) try var(--border-radius)
|
||||
z-index: 9999;
|
||||
}
|
||||
.download-progress__top-close-button {
|
||||
|
|
@ -23,7 +23,7 @@
|
|||
|
We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode. We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
I like this color, but maybe it should use var(--color-primary)? I like this color, but maybe it should use var(--color-primary)?
dark mode, unless my .env is messed up dark mode, unless my .env is messed up
http://getbem.com/naming/ http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container
having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app? having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
try var(--border-radius) try var(--border-radius)
try var(--border-radius) try var(--border-radius)
We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode. We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
I like this color, but maybe it should use var(--color-primary)? I like this color, but maybe it should use var(--color-primary)?
dark mode, unless my .env is messed up dark mode, unless my .env is messed up
http://getbem.com/naming/ http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container
having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app? having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
try var(--border-radius) try var(--border-radius)
try var(--border-radius) try var(--border-radius)
|
||||
height: 2px;
|
||||
width: 13px;
|
||||
background-color: var(--color-gray-4);
|
||||
border-radius: 3px;
|
||||
|
We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode. We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
I like this color, but maybe it should use var(--color-primary)? I like this color, but maybe it should use var(--color-primary)?
dark mode, unless my .env is messed up dark mode, unless my .env is messed up
http://getbem.com/naming/ http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container
having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app? having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
try var(--border-radius) try var(--border-radius)
try var(--border-radius) try var(--border-radius)
|
||||
border-radius: var(--border-radius);
|
||||
|
We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode. We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
I like this color, but maybe it should use var(--color-primary)? I like this color, but maybe it should use var(--color-primary)?
dark mode, unless my .env is messed up dark mode, unless my .env is messed up
http://getbem.com/naming/ http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container
having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app? having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
try var(--border-radius) try var(--border-radius)
try var(--border-radius) try var(--border-radius)
|
||||
}
|
||||
}
|
||||
.download-progress__state-container {
|
||||
|
|
@ -76,10 +76,10 @@
|
|||
|
We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode. We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
I like this color, but maybe it should use var(--color-primary)? I like this color, but maybe it should use var(--color-primary)?
dark mode, unless my .env is messed up dark mode, unless my .env is messed up
http://getbem.com/naming/ http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container
having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app? having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
try var(--border-radius) try var(--border-radius)
try var(--border-radius) try var(--border-radius)
We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode. We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
I like this color, but maybe it should use var(--color-primary)? I like this color, but maybe it should use var(--color-primary)?
dark mode, unless my .env is messed up dark mode, unless my .env is messed up
http://getbem.com/naming/ http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container
having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app? having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
try var(--border-radius) try var(--border-radius)
try var(--border-radius) try var(--border-radius)
|
||||
width: 100%;
|
||||
background-color: var(--color-gray-5);
|
||||
height: 6px;
|
||||
border-radius: 10px;
|
||||
|
We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode. We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
I like this color, but maybe it should use var(--color-primary)? I like this color, but maybe it should use var(--color-primary)?
dark mode, unless my .env is messed up dark mode, unless my .env is messed up
http://getbem.com/naming/ http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container
having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app? having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
try var(--border-radius) try var(--border-radius)
try var(--border-radius) try var(--border-radius)
|
||||
border-radius: var(--border-radius);
|
||||
|
We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode. We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
I like this color, but maybe it should use var(--color-primary)? I like this color, but maybe it should use var(--color-primary)?
dark mode, unless my .env is messed up dark mode, unless my .env is messed up
http://getbem.com/naming/ http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container
having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app? having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
try var(--border-radius) try var(--border-radius)
try var(--border-radius) try var(--border-radius)
|
||||
}
|
||||
.download-progress__bar-content {
|
||||
border-radius: 10px;
|
||||
|
We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode. We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
I like this color, but maybe it should use var(--color-primary)? I like this color, but maybe it should use var(--color-primary)?
dark mode, unless my .env is messed up dark mode, unless my .env is messed up
http://getbem.com/naming/ http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container
having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app? having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
try var(--border-radius) try var(--border-radius)
try var(--border-radius) try var(--border-radius)
|
||||
border-radius: var(--border-radius);
|
||||
|
We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode. We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
I like this color, but maybe it should use var(--color-primary)? I like this color, but maybe it should use var(--color-primary)?
dark mode, unless my .env is messed up dark mode, unless my .env is messed up
http://getbem.com/naming/ http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container
having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app? having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
try var(--border-radius) try var(--border-radius)
try var(--border-radius) try var(--border-radius)
|
||||
height: 100%;
|
||||
background-color: var(--color-primary);
|
||||
}
|
||||
|
|
@ -92,8 +92,8 @@
|
|||
|
We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode. We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
I like this color, but maybe it should use var(--color-primary)? I like this color, but maybe it should use var(--color-primary)?
dark mode, unless my .env is messed up dark mode, unless my .env is messed up
http://getbem.com/naming/ http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container
having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app? having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
try var(--border-radius) try var(--border-radius)
try var(--border-radius) try var(--border-radius)
We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode. We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
I like this color, but maybe it should use var(--color-primary)? I like this color, but maybe it should use var(--color-primary)?
dark mode, unless my .env is messed up dark mode, unless my .env is messed up
http://getbem.com/naming/ http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container
having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app? having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
try var(--border-radius) try var(--border-radius)
try var(--border-radius) try var(--border-radius)
|
||||
.download-progress__playing-button {
|
||||
flex-shrink: 0;
|
||||
margin-left: auto;
|
||||
width: 25px;
|
||||
|
We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode. We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
I like this color, but maybe it should use var(--color-primary)? I like this color, but maybe it should use var(--color-primary)?
dark mode, unless my .env is messed up dark mode, unless my .env is messed up
http://getbem.com/naming/ http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container
having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app? having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
try var(--border-radius) try var(--border-radius)
try var(--border-radius) try var(--border-radius)
|
||||
height: 25px;
|
||||
|
We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode. We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
I like this color, but maybe it should use var(--color-primary)? I like this color, but maybe it should use var(--color-primary)?
dark mode, unless my .env is messed up dark mode, unless my .env is messed up
http://getbem.com/naming/ http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container
having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app? having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
try var(--border-radius) try var(--border-radius)
try var(--border-radius) try var(--border-radius)
|
||||
width: 29.6px;
|
||||
|
We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode. We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
I like this color, but maybe it should use var(--color-primary)? I like this color, but maybe it should use var(--color-primary)?
dark mode, unless my .env is messed up dark mode, unless my .env is messed up
http://getbem.com/naming/ http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container
having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app? having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
try var(--border-radius) try var(--border-radius)
try var(--border-radius) try var(--border-radius)
|
||||
height: 29.6px;
|
||||
|
We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode. We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
I like this color, but maybe it should use var(--color-primary)? I like this color, but maybe it should use var(--color-primary)?
dark mode, unless my .env is messed up dark mode, unless my .env is messed up
http://getbem.com/naming/ http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container
having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app? having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
try var(--border-radius) try var(--border-radius)
try var(--border-radius) try var(--border-radius)
|
||||
}
|
||||
.download-progress__count-time {
|
||||
font-size: 11px;
|
||||
|
|
@ -144,7 +144,7 @@
|
|||
|
We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode. We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
I like this color, but maybe it should use var(--color-primary)? I like this color, but maybe it should use var(--color-primary)?
dark mode, unless my .env is messed up dark mode, unless my .env is messed up
http://getbem.com/naming/ http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container
having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app? having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
try var(--border-radius) try var(--border-radius)
try var(--border-radius) try var(--border-radius)
We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode. We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
I like this color, but maybe it should use var(--color-primary)? I like this color, but maybe it should use var(--color-primary)?
dark mode, unless my .env is messed up dark mode, unless my .env is messed up
http://getbem.com/naming/ http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container
having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app? having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
try var(--border-radius) try var(--border-radius)
try var(--border-radius) try var(--border-radius)
|
||||
right: 10px;
|
||||
width: 400px;
|
||||
height: 300px;
|
||||
border-radius: 10px;
|
||||
|
We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode. We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
I like this color, but maybe it should use var(--color-primary)? I like this color, but maybe it should use var(--color-primary)?
dark mode, unless my .env is messed up dark mode, unless my .env is messed up
http://getbem.com/naming/ http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container
having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app? having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
try var(--border-radius) try var(--border-radius)
try var(--border-radius) try var(--border-radius)
|
||||
border-radius: var(--border-radius);
|
||||
|
We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode. We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
I like this color, but maybe it should use var(--color-primary)? I like this color, but maybe it should use var(--color-primary)?
dark mode, unless my .env is messed up dark mode, unless my .env is messed up
http://getbem.com/naming/ http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container
having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app? having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
try var(--border-radius) try var(--border-radius)
try var(--border-radius) try var(--border-radius)
|
||||
box-shadow: 2px 2px 5px var(--color-gray-4);
|
||||
background-color: var(--color-white);
|
||||
transition: width 2s;
|
||||
|
|
@ -158,7 +158,7 @@
|
|||
|
We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode. We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
I like this color, but maybe it should use var(--color-primary)? I like this color, but maybe it should use var(--color-primary)?
dark mode, unless my .env is messed up dark mode, unless my .env is messed up
http://getbem.com/naming/ http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container
having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app? having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
try var(--border-radius) try var(--border-radius)
try var(--border-radius) try var(--border-radius)
We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode. We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
I like this color, but maybe it should use var(--color-primary)? I like this color, but maybe it should use var(--color-primary)?
dark mode, unless my .env is messed up dark mode, unless my .env is messed up
http://getbem.com/naming/ http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container
having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app? having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
try var(--border-radius) try var(--border-radius)
try var(--border-radius) try var(--border-radius)
|
||||
color: var(--color-gray-6);
|
||||
width: 50px;
|
||||
height: 50px;
|
||||
border-radius: 10px;
|
||||
|
We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode. We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
I like this color, but maybe it should use var(--color-primary)? I like this color, but maybe it should use var(--color-primary)?
dark mode, unless my .env is messed up dark mode, unless my .env is messed up
http://getbem.com/naming/ http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container
having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app? having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
try var(--border-radius) try var(--border-radius)
try var(--border-radius) try var(--border-radius)
|
||||
border-radius: var(--border-radius);
|
||||
|
We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode. We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
I like this color, but maybe it should use var(--color-primary)? I like this color, but maybe it should use var(--color-primary)?
dark mode, unless my .env is messed up dark mode, unless my .env is messed up
http://getbem.com/naming/ http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container
having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app? having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
try var(--border-radius) try var(--border-radius)
try var(--border-radius) try var(--border-radius)
|
||||
box-shadow: 0px 5px 4px var(--color-gray-4);
|
||||
display: flex;
|
||||
justify-content: center;
|
||||
|
|
@ -183,6 +183,33 @@
|
|||
|
We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode. We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
I like this color, but maybe it should use var(--color-primary)? I like this color, but maybe it should use var(--color-primary)?
dark mode, unless my .env is messed up dark mode, unless my .env is messed up
http://getbem.com/naming/ http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container
having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app? having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
try var(--border-radius) try var(--border-radius)
try var(--border-radius) try var(--border-radius)
We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode. We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
I like this color, but maybe it should use var(--color-primary)? I like this color, but maybe it should use var(--color-primary)?
dark mode, unless my .env is messed up dark mode, unless my .env is messed up
http://getbem.com/naming/ http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container
having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app? having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
try var(--border-radius) try var(--border-radius)
try var(--border-radius) try var(--border-radius)
|
||||
animation-name: downloadcount;
|
||||
animation-duration: 1.3s;
|
||||
animation-iteration-count: infinite;
|
||||
|
||||
|
We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode. We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
I like this color, but maybe it should use var(--color-primary)? I like this color, but maybe it should use var(--color-primary)?
dark mode, unless my .env is messed up dark mode, unless my .env is messed up
http://getbem.com/naming/ http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container
having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app? having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
try var(--border-radius) try var(--border-radius)
try var(--border-radius) try var(--border-radius)
|
||||
.notification__bubble {
|
||||
|
We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode. We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
I like this color, but maybe it should use var(--color-primary)? I like this color, but maybe it should use var(--color-primary)?
dark mode, unless my .env is messed up dark mode, unless my .env is messed up
http://getbem.com/naming/ http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container
having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app? having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
try var(--border-radius) try var(--border-radius)
try var(--border-radius) try var(--border-radius)
|
||||
height: 1.5rem;
|
||||
|
We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode. We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
I like this color, but maybe it should use var(--color-primary)? I like this color, but maybe it should use var(--color-primary)?
dark mode, unless my .env is messed up dark mode, unless my .env is messed up
http://getbem.com/naming/ http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container
having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app? having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
try var(--border-radius) try var(--border-radius)
try var(--border-radius) try var(--border-radius)
|
||||
width: 1.5rem;
|
||||
|
We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode. We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
I like this color, but maybe it should use var(--color-primary)? I like this color, but maybe it should use var(--color-primary)?
dark mode, unless my .env is messed up dark mode, unless my .env is messed up
http://getbem.com/naming/ http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container
having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app? having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
try var(--border-radius) try var(--border-radius)
try var(--border-radius) try var(--border-radius)
|
||||
border-radius: 50%;
|
||||
|
We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode. We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
I like this color, but maybe it should use var(--color-primary)? I like this color, but maybe it should use var(--color-primary)?
dark mode, unless my .env is messed up dark mode, unless my .env is messed up
http://getbem.com/naming/ http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container
having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app? having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
try var(--border-radius) try var(--border-radius)
try var(--border-radius) try var(--border-radius)
|
||||
background-color: var(--color-editor-tag);
|
||||
|
We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode. We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
I like this color, but maybe it should use var(--color-primary)? I like this color, but maybe it should use var(--color-primary)?
dark mode, unless my .env is messed up dark mode, unless my .env is messed up
http://getbem.com/naming/ http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container
having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app? having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
try var(--border-radius) try var(--border-radius)
try var(--border-radius) try var(--border-radius)
|
||||
position: absolute;
|
||||
|
We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode. We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
I like this color, but maybe it should use var(--color-primary)? I like this color, but maybe it should use var(--color-primary)?
dark mode, unless my .env is messed up dark mode, unless my .env is messed up
http://getbem.com/naming/ http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container
having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app? having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
try var(--border-radius) try var(--border-radius)
try var(--border-radius) try var(--border-radius)
|
||||
top: -0.5rem;
|
||||
|
We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode. We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
I like this color, but maybe it should use var(--color-primary)? I like this color, but maybe it should use var(--color-primary)?
dark mode, unless my .env is messed up dark mode, unless my .env is messed up
http://getbem.com/naming/ http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container
having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app? having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
try var(--border-radius) try var(--border-radius)
try var(--border-radius) try var(--border-radius)
|
||||
right: -0.5rem;
|
||||
|
We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode. We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
I like this color, but maybe it should use var(--color-primary)? I like this color, but maybe it should use var(--color-primary)?
dark mode, unless my .env is messed up dark mode, unless my .env is messed up
http://getbem.com/naming/ http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container
having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app? having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
try var(--border-radius) try var(--border-radius)
try var(--border-radius) try var(--border-radius)
|
||||
color: white;
|
||||
|
We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode. We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
I like this color, but maybe it should use var(--color-primary)? I like this color, but maybe it should use var(--color-primary)?
dark mode, unless my .env is messed up dark mode, unless my .env is messed up
http://getbem.com/naming/ http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container
having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app? having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
try var(--border-radius) try var(--border-radius)
try var(--border-radius) try var(--border-radius)
|
||||
font-size: var(--font-small);
|
||||
|
We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode. We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
I like this color, but maybe it should use var(--color-primary)? I like this color, but maybe it should use var(--color-primary)?
dark mode, unless my .env is messed up dark mode, unless my .env is messed up
http://getbem.com/naming/ http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container
having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app? having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
try var(--border-radius) try var(--border-radius)
try var(--border-radius) try var(--border-radius)
|
||||
font-weight: bold;
|
||||
|
We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode. We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
I like this color, but maybe it should use var(--color-primary)? I like this color, but maybe it should use var(--color-primary)?
dark mode, unless my .env is messed up dark mode, unless my .env is messed up
http://getbem.com/naming/ http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container
having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app? having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
try var(--border-radius) try var(--border-radius)
try var(--border-radius) try var(--border-radius)
|
||||
line-height: 1;
|
||||
|
We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode. We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
I like this color, but maybe it should use var(--color-primary)? I like this color, but maybe it should use var(--color-primary)?
dark mode, unless my .env is messed up dark mode, unless my .env is messed up
http://getbem.com/naming/ http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container
having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app? having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
try var(--border-radius) try var(--border-radius)
try var(--border-radius) try var(--border-radius)
|
||||
display: flex;
|
||||
|
We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode. We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
I like this color, but maybe it should use var(--color-primary)? I like this color, but maybe it should use var(--color-primary)?
dark mode, unless my .env is messed up dark mode, unless my .env is messed up
http://getbem.com/naming/ http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container
having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app? having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
try var(--border-radius) try var(--border-radius)
try var(--border-radius) try var(--border-radius)
|
||||
align-items: center;
|
||||
|
We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode. We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
I like this color, but maybe it should use var(--color-primary)? I like this color, but maybe it should use var(--color-primary)?
dark mode, unless my .env is messed up dark mode, unless my .env is messed up
http://getbem.com/naming/ http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container
having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app? having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
try var(--border-radius) try var(--border-radius)
try var(--border-radius) try var(--border-radius)
|
||||
justify-content: center;
|
||||
|
We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode. We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
I like this color, but maybe it should use var(--color-primary)? I like this color, but maybe it should use var(--color-primary)?
dark mode, unless my .env is messed up dark mode, unless my .env is messed up
http://getbem.com/naming/ http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container
having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app? having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
try var(--border-radius) try var(--border-radius)
try var(--border-radius) try var(--border-radius)
|
||||
}
|
||||
|
We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode. We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
I like this color, but maybe it should use var(--color-primary)? I like this color, but maybe it should use var(--color-primary)?
dark mode, unless my .env is messed up dark mode, unless my .env is messed up
http://getbem.com/naming/ http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container
having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app? having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
try var(--border-radius) try var(--border-radius)
try var(--border-radius) try var(--border-radius)
|
||||
|
||||
|
We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode. We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
I like this color, but maybe it should use var(--color-primary)? I like this color, but maybe it should use var(--color-primary)?
dark mode, unless my .env is messed up dark mode, unless my .env is messed up
http://getbem.com/naming/ http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container
having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app? having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
try var(--border-radius) try var(--border-radius)
try var(--border-radius) try var(--border-radius)
|
||||
.notification__bubble--small {
|
||||
|
We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode. We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
I like this color, but maybe it should use var(--color-primary)? I like this color, but maybe it should use var(--color-primary)?
dark mode, unless my .env is messed up dark mode, unless my .env is messed up
http://getbem.com/naming/ http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container
having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app? having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
try var(--border-radius) try var(--border-radius)
try var(--border-radius) try var(--border-radius)
|
||||
font-size: var(--font-xsmall);
|
||||
|
We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode. We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
I like this color, but maybe it should use var(--color-primary)? I like this color, but maybe it should use var(--color-primary)?
dark mode, unless my .env is messed up dark mode, unless my .env is messed up
http://getbem.com/naming/ http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container
having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app? having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
try var(--border-radius) try var(--border-radius)
try var(--border-radius) try var(--border-radius)
|
||||
}
|
||||
|
We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode. We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
I like this color, but maybe it should use var(--color-primary)? I like this color, but maybe it should use var(--color-primary)?
dark mode, unless my .env is messed up dark mode, unless my .env is messed up
http://getbem.com/naming/ http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container
having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app? having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
try var(--border-radius) try var(--border-radius)
try var(--border-radius) try var(--border-radius)
|
||||
|
||||
|
We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode. We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
I like this color, but maybe it should use var(--color-primary)? I like this color, but maybe it should use var(--color-primary)?
dark mode, unless my .env is messed up dark mode, unless my .env is messed up
http://getbem.com/naming/ http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container
having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app? having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
try var(--border-radius) try var(--border-radius)
try var(--border-radius) try var(--border-radius)
|
||||
.notification__bubble--inline {
|
||||
|
We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode. We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
I like this color, but maybe it should use var(--color-primary)? I like this color, but maybe it should use var(--color-primary)?
dark mode, unless my .env is messed up dark mode, unless my .env is messed up
http://getbem.com/naming/ http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container
having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app? having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
try var(--border-radius) try var(--border-radius)
try var(--border-radius) try var(--border-radius)
|
||||
@extend .notification__bubble;
|
||||
|
We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode. We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
I like this color, but maybe it should use var(--color-primary)? I like this color, but maybe it should use var(--color-primary)?
dark mode, unless my .env is messed up dark mode, unless my .env is messed up
http://getbem.com/naming/ http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container
having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app? having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
try var(--border-radius) try var(--border-radius)
try var(--border-radius) try var(--border-radius)
|
||||
top: 0.75rem;
|
||||
|
We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode. We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
I like this color, but maybe it should use var(--color-primary)? I like this color, but maybe it should use var(--color-primary)?
dark mode, unless my .env is messed up dark mode, unless my .env is messed up
http://getbem.com/naming/ http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container
having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app? having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
try var(--border-radius) try var(--border-radius)
try var(--border-radius) try var(--border-radius)
|
||||
right: 1rem;
|
||||
|
We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode. We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
I like this color, but maybe it should use var(--color-primary)? I like this color, but maybe it should use var(--color-primary)?
dark mode, unless my .env is messed up dark mode, unless my .env is messed up
http://getbem.com/naming/ http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container
having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app? having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
try var(--border-radius) try var(--border-radius)
try var(--border-radius) try var(--border-radius)
|
||||
}
|
||||
|
We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode. We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
I like this color, but maybe it should use var(--color-primary)? I like this color, but maybe it should use var(--color-primary)?
dark mode, unless my .env is messed up dark mode, unless my .env is messed up
http://getbem.com/naming/ http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container
having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app? having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
try var(--border-radius) try var(--border-radius)
try var(--border-radius) try var(--border-radius)
|
||||
}
|
||||
@keyframes downloadcount {
|
||||
0% {
|
||||
|
|
|
|||
|
We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode. We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
I like this color, but maybe it should use var(--color-primary)? I like this color, but maybe it should use var(--color-primary)?
dark mode, unless my .env is messed up dark mode, unless my .env is messed up
http://getbem.com/naming/ http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container
having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app? having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
try var(--border-radius) try var(--border-radius)
try var(--border-radius) try var(--border-radius)
We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode. We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
I like this color, but maybe it should use var(--color-primary)? I like this color, but maybe it should use var(--color-primary)?
dark mode, unless my .env is messed up dark mode, unless my .env is messed up
http://getbem.com/naming/ http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container
having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app? having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
try var(--border-radius) try var(--border-radius)
try var(--border-radius) try var(--border-radius)
|
||||
(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)
does our Button component work here?
All strings can be wrapped in __('some text') for i18n
This could be <Button button="link" label={__('Yes')} /> if it works well.
This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like
Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
we can persist this using our usePersistedState() hook
something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you
yarn devand wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.