Issue/7152 #7214

Closed
billycolon wants to merge 9 commits from issue/7152 into master
19 changed files with 664 additions and 29 deletions

0
custom/homepages/.gitkeep Normal file → Executable file
View file

View file

@ -2178,6 +2178,16 @@
"Card Last 4": "Card Last 4", "Card Last 4": "Card Last 4",
"Search blocked channel name": "Search blocked channel name", "Search blocked channel name": "Search blocked channel name",
"Discuss": "Discuss", "Discuss": "Discuss",
"Play Next (SHIFT+N)": "Play Next (SHIFT+N)",
"Play Previous (SHIFT+P)": "Play Previous (SHIFT+P)",
"Finance": "Finance",
"You followed @veritasium!": "You followed @veritasium!",
"Downloading": "Downloading",
"Do you cancel download this file?": "Do you cancel download this file?",
"%remainingMinutes% minutes %remainSecond% seconds remaining": "%remainingMinutes% minutes %remainSecond% seconds remaining",
"%remainSecond% seconds remaining": "%remainSecond% seconds remaining",
"%written% of %total%": "%written% of %total%",
"(%speed%/sec)": "(%speed%/sec)",
"lbry.tv has been retired. You have been magically transported to Odysee.com. %more%": "lbry.tv has been retired. You have been magically transported to Odysee.com. %more%", "lbry.tv has been retired. You have been magically transported to Odysee.com. %more%": "lbry.tv has been retired. You have been magically transported to Odysee.com. %more%",
"Show more livestreams": "Show more livestreams", "Show more livestreams": "Show more livestreams",
"Creator": "Creator", "Creator": "Creator",

BIN
static/img/dark_loading.gif Normal file

Binary file not shown.

After

Width:  |  Height:  |  Size: 78 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 79 KiB

View file

@ -191,9 +191,11 @@ function ClaimPreviewTile(props: Props) {
</div> </div>
<div className="placeholder__wrapper"> <div className="placeholder__wrapper">
<div className="placeholder claim-tile__title" /> <div className="placeholder claim-tile__title" />
<div className={classnames('claim-tile__info placeholder', { <div
'contains_view_count': shouldShowViewCount, className={classnames('claim-tile__info placeholder', {
})} /> contains_view_count: shouldShowViewCount,
})}
/>
</div> </div>
</li> </li>
); );
@ -253,9 +255,11 @@ function ClaimPreviewTile(props: Props) {
<ClaimMenuList uri={uri} collectionId={listId} channelUri={channelUri} /> <ClaimMenuList uri={uri} collectionId={listId} channelUri={channelUri} />
</div> </div>
<div> <div>
<div className={classnames('claim-tile__info', { <div
'contains_view_count': shouldShowViewCount, className={classnames('claim-tile__info', {
})}> contains_view_count: shouldShowViewCount,
})}
>
{isChannel ? ( {isChannel ? (
<div className="claim-tile__about--channel"> <div className="claim-tile__about--channel">
<SubscribeButton uri={repostedChannelUri || uri} /> <SubscribeButton uri={repostedChannelUri || uri} />

View file

@ -104,7 +104,11 @@ class DateTime extends React.Component<Props, State> {
return null; return null;
} }
return <span className="date_time" title={moment(date).format(`MMMM Do, YYYY ${clockFormat}`)}>{DateTime.getTimeAgoStr(date)}</span>; return (
<span className="date_time" title={moment(date).format(`MMMM Do, YYYY ${clockFormat}`)}>
{DateTime.getTimeAgoStr(date)}
</span>
);
} }
return ( return (

View file

@ -0,0 +1,48 @@
import { connect } from 'react-redux';
import DownloadProgress from './view';
import { doSetPlayingUri, doStopDownload, doContinueDownloading, doPurchaseUriWrapper } from 'redux/actions/content';
import { selectFileInfosByOutpoint, SETTINGS } from 'lbry-redux';
import { selectPrimaryUri, selectPlayingUri } from 'redux/selectors/content';
import { makeSelectClientSetting } from 'redux/selectors/settings';
const select = (state) => {
jessopb commented 2021-10-01 22:58:12 +02:00 (Migrated from github.com)
Review

I think I'd prefer to use the selector for consistency
4c72a563da/ui/redux/selectors/file_info.js (L6)

return { downloadList: selectFileInfosByOutpoint(state) }

I think I'd prefer to use the selector for consistency https://github.com/lbryio/lbry-desktop/blob/4c72a563daf15502787bbada67958ab72f63db59/ui/redux/selectors/file_info.js#L6 return { downloadList: selectFileInfosByOutpoint(state) }
const byOutpoint = selectFileInfosByOutpoint(state);
const runningByOutpoint = [];
const primaryUri = selectPrimaryUri(state);
const playingUri = selectPlayingUri(state);
const uri = playingUri ? playingUri.uri : null;
let primaryOutpoint = null;
let playingOutpoint = null;
for (const key in byOutpoint) {
const item = byOutpoint[key];
if (item && primaryUri && primaryUri.includes(`/${item.claim_name}`)) primaryOutpoint = item.outpoint;
if (item && uri && uri.includes(`/${item.claim_name}`)) playingOutpoint = item.outpoint;
if (item && item.status === 'running') {
runningByOutpoint.push(item);
}
}
return {
byOutpoint: selectFileInfosByOutpoint(state),
primary: {
uri: primaryUri,
outpoint: primaryOutpoint,
},
playing: {
uri,
outpoint: playingOutpoint,
},
currentTheme: makeSelectClientSetting(SETTINGS.THEME)(state),
};
};
const perform = (dispatch) => ({
pause: () => dispatch(doSetPlayingUri({ uri: null })),
doContinueDownloading: (outpoint, force) => dispatch(doContinueDownloading(outpoint, force)),
stopDownload: (outpoint) => dispatch(doStopDownload(outpoint)),
download: (uri) => dispatch(doPurchaseUriWrapper(uri, false, true)),
});
export default connect(select, perform)(DownloadProgress);

View file

@ -0,0 +1,286 @@
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
// @flow
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
import React, { useState, useEffect } from 'react';
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
import { shell } from 'electron';
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
import Button from 'component/button';
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
import * as ICONS from 'constants/icons';
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
import { buildURI } from 'lbry-redux';
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
import { formatBytes } from 'util/format-bytes';
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
import { areEqual, removeItem } from 'util/array';
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
import loadingIcon from '../../../static/img/white_loading.gif';
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
import darkLoadingIcon from '../../../static/img/dark_loading.gif';
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
jessopb commented 2021-10-08 20:06:32 +02:00 (Migrated from github.com)
Review

I'm not sure I want the new loading gifs, but it might be ok. @kauffj will look by monday.

I'm not sure I want the new loading gifs, but it might be ok. @kauffj will look by monday.
import usePersistedState from 'effects/use-persisted-state';
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
type Props = {
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
byOutpoint: any,
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
primary: any,
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
playing: any,
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
currentTheme: string,
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
stopDownload: (outpoint: string) => void,
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
doContinueDownloading: (outpoint: string, force: boolean) => void,
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
download: (uri: string) => void,
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
};
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
function DownloadProgress({ byOutpoint, primary, playing, currentTheme, stopDownload, doContinueDownloading }: Props) {
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
const [isShow, setIsShow] = usePersistedState('download-progress', true);
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
const [downloading, setDownloading] = usePersistedState('download-progress-downloading', []);
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
const [cancelHash] = useState({});
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
const [initDownloadingHash] = useState({});
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
const [prevPlaying, setPrevPlaying] = useState({});
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
const [prevPrimary, setPrevPrimary] = useState({});
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
const handleCancel = (hash, value) => {
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
cancelHash[hash] = value;
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
};
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
const handleStopDownload = (outpoint) => {
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
const updated = [...downloading];
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
removeItem(updated, outpoint);
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
setDownloading(updated);
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
stopDownload(outpoint);
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
};
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
const runningByOutpoint = {};
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
const currentDownloading = [...downloading];
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
for (const key in byOutpoint) {
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
const item = byOutpoint[key];
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
if (item && item.status === 'running') runningByOutpoint[item.outpoint] = item;
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
}
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
Object.keys(runningByOutpoint)
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
.filter((outpoint) => downloading.indexOf(outpoint) === -1)
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
.map((outpoint) => {
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
if (primary.outpoint !== outpoint && playing.outpoint !== outpoint) {
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
currentDownloading.push(outpoint);
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
}
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
});
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
downloading
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
.filter((outpoint) => (byOutpoint[outpoint] && byOutpoint[outpoint].status !== 'running') || !byOutpoint[outpoint])
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
.map((outpoint) => {
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
removeItem(currentDownloading, outpoint);
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
});
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
if (!areEqual(downloading, currentDownloading)) setDownloading(currentDownloading);
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
if (currentDownloading.length === 0) return null;
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
if (playing.outpoint !== prevPlaying.outpoint) {
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
if (downloading.includes(prevPlaying.outpoint)) {
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
setTimeout(() => {
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
doContinueDownloading(prevPlaying.outpoint, true);
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
}, 1000);
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
}
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
setPrevPlaying(playing);
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
}
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
if (primary.outpoint !== prevPrimary.outpoint) {
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
if (downloading.includes(prevPrimary.outpoint)) {
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
setTimeout(() => {
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
doContinueDownloading(prevPrimary.outpoint, true);
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
}, 1000);
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
}
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
setPrevPrimary(primary);
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
}
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
currentDownloading.map((outpoint) => {
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
if (!initDownloadingHash[outpoint]) {
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
initDownloadingHash[outpoint] = true;
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
doContinueDownloading(outpoint, false);
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
}
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
});
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
if (!isShow) {
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
jessopb commented 2021-10-02 01:38:16 +02:00 (Migrated from github.com)
Review

non-blocker, but I wonder if a side-docked indicator component would be better than a floating circle.

non-blocker, but I wonder if a side-docked indicator component would be better than a floating circle.
return (
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
<>
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
<Button
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
iconSize={40}
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
icon={ICONS.DOWNLOAD}
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
className="download-progress__toggle-button"
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
onClick={() => setIsShow(true)}
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
>
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
<div className="download-progress__current-downloading">
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
<span className="notification__bubble">
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
jessopb commented 2021-10-08 20:31:51 +02:00 (Migrated from github.com)
Review

I think we want information about how many, but not urgent distraction of bouncing. And maybe not red (but maybe?)

I think we want information about how many, but not urgent distraction of bouncing. And maybe not red (but maybe?)
<span className="notification__count">{currentDownloading.length}</span>
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
</span>
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
</div>
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
</Button>
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
</>
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
);
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
}
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
return (
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
<div className="download-progress__header">
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
<Button className="download-progress__top-close-button" onClick={() => setIsShow(false)}>
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
<div />
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
</Button>
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
{currentDownloading.map((outpoint, index) => {
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
const item = runningByOutpoint[outpoint];
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
let releaseTime = '';
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
let isPlaying = false;
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
if (item.metadata && item.metadata.release_time) {
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
releaseTime = new Date(parseInt(item.metadata.release_time) * 1000).toISOString().split('T')[0];
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
}
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
if (outpoint === primary.outpoint || outpoint === playing.outpoint) {
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
isPlaying = true;
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
}
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
return (
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
<div key={item.outpoint}>
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
{index !== 0 && <hr className="download-progress__divider" />}
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
<DownloadProgressItem
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
fileName={item.suggested_file_name}
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
title={item.metadata.title}
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
releaseTime={releaseTime}
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
writtenBytes={item.written_bytes}
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
totalBytes={item.total_bytes}
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
addedOn={item.added_on}
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
directory={item.download_directory}
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
stopDownload={handleStopDownload}
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
outpoint={item.outpoint}
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
isCancel={cancelHash[item.outpoint]}
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
claimID={item.claim_id}
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
playing={isPlaying}
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
claimName={item.claim_name}
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
handleCancel={handleCancel}
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
currentTheme={currentTheme}
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
/>
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
</div>
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
);
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
})}
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
</div>
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
);
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
}
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
type DownloadProgressItemProps = {
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
fileName: string,
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
writtenBytes: number,
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
totalBytes: number,
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
addedOn: number,
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
title: string,
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
releaseTime: string,
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
directory: string,
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
outpoint: string,
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
isCancel: boolean,
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
claimID: string,
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
claimName: string,
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
playing: boolean,
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
currentTheme: string,
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
stopDownload: (outpoint: string) => void,
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
handleCancel: (hash: string, value: boolean) => void,
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
};
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
function DownloadProgressItem({
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
fileName,
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
writtenBytes,
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
totalBytes,
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
addedOn,
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
title,
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
releaseTime,
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
directory,
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
outpoint,
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
isCancel,
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
claimID,
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
claimName,
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
playing,
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
currentTheme,
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
stopDownload,
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
handleCancel,
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
}: DownloadProgressItemProps) {
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
const processStopDownload = () => {
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
handleCancel(outpoint, false);
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
stopDownload(outpoint);
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
};
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
const [percent, setPercent] = useState(0);
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
const [progressText, setProgressText] = useState('');
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
useEffect(() => {
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
const updatePercent = ((writtenBytes / totalBytes) * 100).toFixed(0);
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
setPercent(updatePercent);
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
let updateText = '';
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
const downloadSpeed = Math.ceil(writtenBytes / (Date.now() / 1000 - addedOn));
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
const remainingSecond = Math.ceil((totalBytes - writtenBytes) / downloadSpeed);
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
const remainingMinutes = Math.floor(remainingSecond / 60);
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
if (remainingMinutes > 0) {
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
updateText += __('%remainingMinutes% minutes %remainSecond% seconds remaining', {
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
remainingMinutes: remainingMinutes,
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
remainSecond: remainingSecond - 60 * remainingMinutes,
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
});
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
} else {
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
updateText += __('%remainSecond% seconds remaining', { remainSecond: remainingSecond - 60 * remainingMinutes });
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
}
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
updateText += ' -- ';
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
updateText += __('%written% of %total%', {
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
written: formatBytes(writtenBytes),
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
total: formatBytes(totalBytes),
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
});
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
updateText += ' ';
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
updateText += __('(%speed%/sec)', {
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
speed: formatBytes(downloadSpeed),
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
});
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
setProgressText(updateText);
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
}, [writtenBytes, totalBytes, addedOn]);
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
const openDownloadFolder = () => {
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
shell.openPath(directory);
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
};
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
return (
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
<div className="download-progress__state-container">
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
<div className="download-progress__state-bar">
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
<Button
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
label={title}
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
className="download-progress__state-filename"
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
navigate={buildURI({ claimName, claimID })}
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
/>
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
{playing ? (
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
currentTheme === 'light' ? (
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
<img src={loadingIcon} className="download-progress__playing-button" />
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
) : (
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
<img src={darkLoadingIcon} className="download-progress__playing-button" />
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
)
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
) : (
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
<div
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
className="download-progress__close-button"
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
onClick={() => {
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
handleCancel(outpoint, true);
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
}}
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
>
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
&times;
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
</div>
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
)}
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
</div>
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
<div className="download-progress__state-bar">
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
<a className="download-progress__state-filename-link" onClick={openDownloadFolder}>
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
{fileName}
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
</a>
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
<p className="download-progress__release-time">{releaseTime}</p>
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
</div>
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
<div className="download-progress__state-bar">
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
<div className="download-progress__bar-container">
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
<div className="download-progress__bar-content" style={{ width: `${percent}%` }} />
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
</div>
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
</div>
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
<p className="download-progress__count-time">{progressText}</p>
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
{isCancel && (
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
<div className="download-progress__cancel">
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
<p>{__('Do you cancel download this file?')}</p>
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
<div className="download-progress__cancel-confirm">
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
<Button label={__('Yes')} className="download-progress__cancel-ok" onClick={processStopDownload} />
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
jessopb commented 2021-10-08 20:26:51 +02:00 (Migrated from github.com)
Review

When this shows up it shifts the whole component - is it a good idea for this to take the place of the X?

When this shows up it shifts the whole component - is it a good idea for this to take the place of the X?
<Button
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
label={__('No')}
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
className="download-progress__cancel-ok"
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
onClick={() => handleCancel(outpoint, false)}
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
/>
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
</div>
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
</div>
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
)}
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
</div>
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
);
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
}
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment
export default DownloadProgress;
jessopb commented 2021-10-01 23:15:06 +02:00 (Migrated from github.com)
Review

(Object.keys(props.downloadList): any).map(..)
Will fix your inevitable flowtype complaint here :)

(Object.keys(props.downloadList): any).map(..) Will fix your inevitable flowtype complaint here :)
jessopb commented 2021-10-01 23:22:28 +02:00 (Migrated from github.com)
Review

does our Button component work here?

        <Button
          iconSize={24}
          button="close" <- or your className?
          aria-label={__('Close')}
          icon={ICONS.REMOVE}
          onClick={...}
        />
        ```
does our Button component work here? ``` <Button iconSize={24} button="close" <- or your className? aria-label={__('Close')} icon={ICONS.REMOVE} onClick={...} /> ```
jessopb commented 2021-10-01 23:24:46 +02:00 (Migrated from github.com)
Review

All strings can be wrapped in __('some text') for i18n

All strings can be wrapped in __('some text') for i18n
jessopb commented 2021-10-01 23:51:27 +02:00 (Migrated from github.com)
Review

This could be <Button button="link" label={__('Yes')} /> if it works well.

This could be <Button button="link" label={__('Yes')} /> if it works well.
jessopb commented 2021-10-02 01:42:48 +02:00 (Migrated from github.com)
Review

This {title} should probably link to the FilePage for the content url
Since an item in downloadList includes a claim_id and a claim_name, you can try using something like

<Button
...
navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id }))
>
This {title} should probably link to the FilePage for the content url Since an item in downloadList includes a claim_id and a claim_name, you can try using something like ``` <Button ... navigate={buildURI({ claimName: item.claim_name, claimID: item.claim_id })) > ```
jessopb commented 2021-10-02 02:09:01 +02:00 (Migrated from github.com)
Review

Neat to see this done from scratch and in about the same way!
We have this util function:
https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js

Neat to see this done from scratch and in about the same way! We have this util function: https://github.com/lbryio/lbry-desktop/blob/master/ui/util/format-bytes.js
jessopb commented 2021-10-02 06:00:24 +02:00 (Migrated from github.com)
Review

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.

I think DownloadProgressItem be clearer? The word "state" takes a second for me to disambiguate.
jessopb commented 2021-10-02 07:14:36 +02:00 (Migrated from github.com)
Review

we can persist this using our usePersistedState() hook

we can persist this using our usePersistedState() hook
jessopb commented 2021-10-02 08:03:23 +02:00 (Migrated from github.com)
Review

something weird happens here that crashes the app when I play a video.
"cannot read status of null"
redux devtools (which has a bug that sometimes doesn't load unless you yarn dev and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { : null } until file_list fetch comes back.

something weird happens here that crashes the app when I play a video. "cannot read status of null" redux devtools (which has a bug that sometimes doesn't load unless you `yarn dev` and wait for the app to finish before opening devtools) tells me initial state byOutpoint is { <outpoint>: null } until file_list fetch comes back.
jessopb commented 2021-10-08 20:03:24 +02:00 (Migrated from github.com)
Review

this name sounds like a function rather than an array.
downloadsToUpdate?

this name sounds like a function rather than an array. downloadsToUpdate?
jessopb commented 2021-10-08 20:07:16 +02:00 (Migrated from github.com)
Review

this could use a comment

this could use a comment

View file

@ -7,6 +7,7 @@ import SideNavigation from 'component/sideNavigation';
import SettingsSideNavigation from 'component/settingsSideNavigation'; import SettingsSideNavigation from 'component/settingsSideNavigation';
import Header from 'component/header'; import Header from 'component/header';
/* @if TARGET='app' */ /* @if TARGET='app' */
import DownloadProgress from '../downloadProgress';
import StatusBar from 'component/common/status-bar'; import StatusBar from 'component/common/status-bar';
/* @endif */ /* @endif */
import usePersistedState from 'effects/use-persisted-state'; import usePersistedState from 'effects/use-persisted-state';
@ -102,7 +103,7 @@ function Page(props: Props) {
setSidebarOpen(false); setSidebarOpen(false);
} }
// TODO: make sure setState callback for usePersistedState uses useCallback to it doesn't cause effect to re-run // TODO: make sure setState callback for usePersistedState uses useCallback to it doesn't cause effect to re-run
}, [isOnFilePage, isMediumScreen]); }, [isOnFilePage, isMediumScreen, setSidebarOpen]);
return ( return (
<Fragment> <Fragment>
@ -150,6 +151,9 @@ function Page(props: Props) {
</React.Suspense> </React.Suspense>
)} )}
{/* @endif */} {/* @endif */}
{/* @if TARGET='app' */}
<DownloadProgress />
{/* @endif */}
</Fragment> </Fragment>
); );
} }

View file

@ -178,7 +178,15 @@ function VideoViewer(props: Props) {
fetch(source, { method: 'HEAD', cache: 'no-store' }).then((response) => { fetch(source, { method: 'HEAD', cache: 'no-store' }).then((response) => {
let playerPoweredBy = response.headers.get('x-powered-by') || ''; let playerPoweredBy = response.headers.get('x-powered-by') || '';
analytics.videoStartEvent(claimId, timeToStart, playerPoweredBy, userId, claim.canonical_url, this, bitrateAsBitsPerSecond); analytics.videoStartEvent(
claimId,
timeToStart,
playerPoweredBy,
userId,
claim.canonical_url,
this,
bitrateAsBitsPerSecond
);
}); });
doAnalyticsView(uri, timeToStart).then(() => { doAnalyticsView(uri, timeToStart).then(() => {

View file

@ -18,27 +18,28 @@ import {
doToast, doToast,
makeSelectUrlsForCollectionId, makeSelectUrlsForCollectionId,
} from 'lbry-redux'; } from 'lbry-redux';
import { doPurchaseUri } from 'redux/actions/file'; import { doPurchaseUri, doDeleteFile } from 'redux/actions/file';
import { makeSelectCostInfoForUri, Lbryio } from 'lbryinc'; import { makeSelectCostInfoForUri, Lbryio } from 'lbryinc';
jessopb commented 2021-10-02 07:49:27 +02:00 (Migrated from github.com)
Review

on Refresh, doUpdateLoadStatus doesn't get restarted (I guess this was a noted TODO issue) :( which means the progress gets stuck.
uri passed in seems unused - it doesn't appear to play any role at all according to redux devtools so doUpdateLoadStatus(null, outpoint) should work fine to restart it. Stripping it out would be nice though.

on Refresh, doUpdateLoadStatus doesn't get restarted (I guess this was a noted TODO issue) :( which means the progress gets stuck. uri passed in seems unused - it doesn't appear to play any role at all according to redux devtools so `doUpdateLoadStatus(null, outpoint)` should work fine to restart it. Stripping it out would be nice though.
import { makeSelectClientSetting, selectosNotificationsEnabled, selectDaemonSettings } from 'redux/selectors/settings'; import { makeSelectClientSetting, selectosNotificationsEnabled, selectDaemonSettings } from 'redux/selectors/settings';
const DOWNLOAD_POLL_INTERVAL = 1000; const DOWNLOAD_POLL_INTERVAL = 1000;
var timeOutHash = {};
export function doUpdateLoadStatus(uri: string, outpoint: string) { export function doUpdateLoadStatus(uri: any, outpoint: string) {
// Updates the loading status for a uri as it's downloading // Updates the loading status for a uri as it's downloading
// Calls file_list and checks the written_bytes value to see if the number has increased // Calls file_list and checks the written_bytes value to see if the number has increased
// Not needed on web as users aren't actually downloading the file // Not needed on web as users aren't actually downloading the file
// @if TARGET='app' // @if TARGET='app'
jessopb commented 2021-10-02 07:15:27 +02:00 (Migrated from github.com)
Review

If I refresh, this gets cleared and the progress gets stuck.

If I refresh, this gets cleared and the progress gets stuck.
return (dispatch: Dispatch, getState: GetState) => { return (dispatch: Dispatch, getState: GetState) => {
const setNextStatusUpdate = () => const setNextStatusUpdate = () =>
setTimeout(() => { (timeOutHash[outpoint] = setTimeout(() => {
// We need to check if outpoint still exists first because user are able to delete file (outpoint) while downloading. // We need to check if outpoint still exists first because user are able to delete file (outpoint) while downloading.
// If a file is already deleted, no point to still try update load status // If a file is already deleted, no point to still try update load status
const byOutpoint = selectFileInfosByOutpoint(getState()); const byOutpoint = selectFileInfosByOutpoint(getState());
if (byOutpoint[outpoint]) { if (byOutpoint[outpoint]) {
dispatch(doUpdateLoadStatus(uri, outpoint)); dispatch(doUpdateLoadStatus(uri, outpoint));
} }
}, DOWNLOAD_POLL_INTERVAL); }, DOWNLOAD_POLL_INTERVAL));
Lbry.file_list({ Lbry.file_list({
outpoint, outpoint,
@ -53,6 +54,7 @@ export function doUpdateLoadStatus(uri: string, outpoint: string) {
setNextStatusUpdate(); setNextStatusUpdate();
} else if (fileInfo.completed) { } else if (fileInfo.completed) {
// TODO this isn't going to get called if they reload the client before // TODO this isn't going to get called if they reload the client before
// the download finished // the download finished
dispatch({ dispatch({
type: ACTIONS.DOWNLOADING_COMPLETED, type: ACTIONS.DOWNLOADING_COMPLETED,
@ -98,6 +100,25 @@ export function doUpdateLoadStatus(uri: string, outpoint: string) {
// @endif // @endif
} }
export function doContinueDownloading(outpoint: string, force: boolean) {
return (dispatch: Dispatch) => {
if (!timeOutHash[outpoint] || force) {
dispatch(doUpdateLoadStatus(null, outpoint));
}
};
}
export function doStopDownload(outpoint: string) {
return (dispatch: Dispatch) => {
if (timeOutHash[outpoint]) {
clearInterval(timeOutHash[outpoint]);
timeOutHash[outpoint] = undefined;
}
dispatch(doDeleteFile(outpoint, false, false, null));
};
}
export function doSetPrimaryUri(uri: ?string) { export function doSetPrimaryUri(uri: ?string) {
return (dispatch: Dispatch) => { return (dispatch: Dispatch) => {
dispatch({ dispatch({

View file

@ -1,11 +1,11 @@
import { selectClaimsByUri, selectIsFetchingClaimListMine, selectMyClaims } from 'lbry-redux'; import { selectClaimsByUri, selectIsFetchingClaimListMine, selectMyClaims } from 'lbry-redux';
import { createSelector } from 'reselect'; import { createSelector } from 'reselect';
export const selectState = state => state.fileInfo || {}; export const selectState = (state) => state.fileInfo || {};
export const selectFileInfosByOutpoint = createSelector(selectState, state => state.byOutpoint || {}); export const selectFileInfosByOutpoint = createSelector(selectState, (state) => state.byOutpoint || {});
export const selectIsFetchingFileList = createSelector(selectState, state => state.isFetchingFileList); export const selectIsFetchingFileList = createSelector(selectState, (state) => state.isFetchingFileList);
export const selectIsFetchingFileListDownloadedOrPublished = createSelector( export const selectIsFetchingFileListDownloadedOrPublished = createSelector(
selectIsFetchingFileList, selectIsFetchingFileList,
@ -13,31 +13,31 @@ export const selectIsFetchingFileListDownloadedOrPublished = createSelector(
(isFetchingFileList, isFetchingClaimListMine) => isFetchingFileList || isFetchingClaimListMine (isFetchingFileList, isFetchingClaimListMine) => isFetchingFileList || isFetchingClaimListMine
); );
export const makeSelectFileInfoForUri = uri => export const makeSelectFileInfoForUri = (uri) =>
createSelector(selectClaimsByUri, selectFileInfosByOutpoint, (claims, byOutpoint) => { createSelector(selectClaimsByUri, selectFileInfosByOutpoint, (claims, byOutpoint) => {
const claim = claims[uri]; const claim = claims[uri];
const outpoint = claim ? `${claim.txid}:${claim.nout}` : undefined; const outpoint = claim ? `${claim.txid}:${claim.nout}` : undefined;
return outpoint ? byOutpoint[outpoint] : undefined; return outpoint ? byOutpoint[outpoint] : undefined;
}); });
export const selectDownloadingByOutpoint = createSelector(selectState, state => state.downloadingByOutpoint || {}); export const selectDownloadingByOutpoint = createSelector(selectState, (state) => state.downloadingByOutpoint || {});
export const makeSelectDownloadingForUri = uri => export const makeSelectDownloadingForUri = (uri) =>
createSelector(selectDownloadingByOutpoint, makeSelectFileInfoForUri(uri), (byOutpoint, fileInfo) => { createSelector(selectDownloadingByOutpoint, makeSelectFileInfoForUri(uri), (byOutpoint, fileInfo) => {
if (!fileInfo) return false; if (!fileInfo) return false;
return byOutpoint[fileInfo.outpoint]; return byOutpoint[fileInfo.outpoint];
}); });
export const selectUrisLoading = createSelector(selectState, state => state.urisLoading || {}); export const selectUrisLoading = createSelector(selectState, (state) => state.urisLoading || {});
export const makeSelectLoadingForUri = uri => createSelector(selectUrisLoading, byUri => byUri && byUri[uri]); export const makeSelectLoadingForUri = (uri) => createSelector(selectUrisLoading, (byUri) => byUri && byUri[uri]);
export const selectFileInfosDownloaded = createSelector( export const selectFileInfosDownloaded = createSelector(
selectFileInfosByOutpoint, selectFileInfosByOutpoint,
selectMyClaims, selectMyClaims,
(byOutpoint, myClaims) => (byOutpoint, myClaims) =>
Object.values(byOutpoint).filter(fileInfo => { Object.values(byOutpoint).filter((fileInfo) => {
const myClaimIds = myClaims.map(claim => claim.claim_id); const myClaimIds = myClaims.map((claim) => claim.claim_id);
return fileInfo && myClaimIds.indexOf(fileInfo.claim_id) === -1 && (fileInfo.completed || fileInfo.written_bytes); return fileInfo && myClaimIds.indexOf(fileInfo.claim_id) === -1 && (fileInfo.completed || fileInfo.written_bytes);
}) })
@ -59,7 +59,7 @@ export const selectDownloadingFileInfos = createSelector(
const outpoints = Object.keys(downloadingByOutpoint); const outpoints = Object.keys(downloadingByOutpoint);
const fileInfos = []; const fileInfos = [];
outpoints.forEach(outpoint => { outpoints.forEach((outpoint) => {
const fileInfo = fileInfosByOutpoint[outpoint]; const fileInfo = fileInfosByOutpoint[outpoint];
if (fileInfo) fileInfos.push(fileInfo); if (fileInfo) fileInfos.push(fileInfo);
@ -69,10 +69,10 @@ export const selectDownloadingFileInfos = createSelector(
} }
); );
export const selectTotalDownloadProgress = createSelector(selectDownloadingFileInfos, fileInfos => { export const selectTotalDownloadProgress = createSelector(selectDownloadingFileInfos, (fileInfos) => {
const progress = []; const progress = [];
fileInfos.forEach(fileInfo => { fileInfos.forEach((fileInfo) => {
progress.push((fileInfo.written_bytes / fileInfo.total_bytes) * 100); progress.push((fileInfo.written_bytes / fileInfo.total_bytes) * 100);
}); });
@ -82,4 +82,4 @@ export const selectTotalDownloadProgress = createSelector(selectDownloadingFileI
return -1; return -1;
}); });
export const selectFileInfoErrors = createSelector(selectState, state => state.errors || {}); export const selectFileInfoErrors = createSelector(selectState, (state) => state.errors || {});

View file

@ -68,3 +68,4 @@
@import 'component/empty'; @import 'component/empty';
@import 'component/stripe-card'; @import 'component/stripe-card';
@import 'component/wallet-tip-send'; @import 'component/wallet-tip-send';
@import 'component/download-progress';

View file

@ -720,6 +720,7 @@
margin: 0 0; margin: 0 0;
padding: var(--spacing-xxs) var(--spacing-xxs); padding: var(--spacing-xxs) var(--spacing-xxs);
height: unset; height: unset;
background-color: var(--color-header-background);
// label (with 'Add' text) hidden by default // label (with 'Add' text) hidden by default
.button__label { .button__label {

View file

@ -0,0 +1,224 @@
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
.download-progress__header {
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
padding: 15px;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
position: fixed;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
bottom: 0;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
right: 0;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
width: 400px;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
display: flex;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
flex-direction: column;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
background-color: var(--color-header-background); //var(--color-gray-9):dark-mode
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
border-radius: var(--border-radius);
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
// border: 1px solid var(--color-gray-3);
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
z-index: 9999;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
}
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
.download-progress__top-close-button {
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
position: absolute;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
top: 7px;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
right: 15px;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
font-size: 35px;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
background-color: transparent;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
width: 15px;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
height: 15px;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
div {
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
height: 2px;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
width: 13px;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
background-color: var(--color-gray-4);
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
border-radius: var(--border-radius);
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
}
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
}
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
.download-progress__state-container {
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
margin-top: 10px;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
padding-bottom: 10px;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
display: flex;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
flex-direction: column;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
width: 100%;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
}
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
.download-progress__state-filename {
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
margin: 0;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
font-weight: 800;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
font-size: 13px;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
flex: 1;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
overflow: hidden;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
white-space: nowrap;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
text-overflow: ellipsis;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
margin-right: 10px;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
span.button__label {
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
color: var(--color-text);
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
}
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
}
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
.download-progress__state-filename-link {
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
margin: 0;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
font-weight: 800;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
font-size: 13px;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
flex: 1;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
overflow: hidden;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
white-space: nowrap;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
text-overflow: ellipsis;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
margin-right: 10px;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
text-decoration: underline;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
cursor: pointer;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
}
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
.download-progress__release-time {
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
margin: 0;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
font-weight: 800;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
font-size: 12px;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
margin-left: auto;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
font-style: italic;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
}
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
.download-progress__state-bar {
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
display: flex;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
flex-direction: row;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
width: 100%;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
align-items: center;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
margin-bottom: 2px;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
}
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
.download-progress__bar-container {
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
width: 100%;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
background-color: var(--color-gray-5);
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
height: 6px;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
border-radius: var(--border-radius);
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
}
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
.download-progress__bar-content {
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
border-radius: var(--border-radius);
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
height: 100%;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
background-color: var(--color-primary);
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
}
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
.download-progress__close-button {
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
flex-shrink: 0;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
margin-left: auto;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
font-size: 20px;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
cursor: pointer;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
}
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
.download-progress__playing-button {
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
flex-shrink: 0;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
margin-left: auto;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
width: 29.6px;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
height: 29.6px;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
}
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
.download-progress__count-time {
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
font-size: 11px;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
letter-spacing: -0.6px;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
}
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
.download-progress__divider {
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
border-top: 1px solid var(--color-gray-6);
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
margin-left: -15px;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
width: 110%;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
}
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
.download-progress__cancel {
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
margin-top: 7px;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
display: flex;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
flex-direction: row;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
align-items: center;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
justify-content: space-between;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
}
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
.download-progress__cancel p {
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
margin: 0;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
font-size: 12px;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
margin: 0;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
white-space: nowrap;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
width: 285px;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
overflow: hidden;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
text-overflow: ellipsis;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
}
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
.download-progress__cancel b {
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
font-size: 13px;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
}
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
.download-progress__cancel-confirm {
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
width: 90px;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
display: flex;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
justify-content: space-around;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
align-items: center;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
}
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
.download-progress__cancel-ok {
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
border: none;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
background-color: transparent;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
font-size: 13px;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
color: var(--color-text);
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
}
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
.download-progress__cancel-ok:hover {
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
color: var(--color-primary);
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
}
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
.download__container {
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
position: fixed;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
bottom: 10px;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
right: 10px;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
width: 400px;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
height: 300px;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
border-radius: var(--border-radius);
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
box-shadow: 2px 2px 5px var(--color-gray-4);
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
background-color: var(--color-white);
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
transition: width 2s;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
}
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
.download-progress__toggle-button {
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
position: fixed;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
bottom: 10px;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
right: 10px;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
border: none;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
background: var(--color-header-background);
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
color: var(--color-gray-6);
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
width: 50px;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
height: 50px;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
border-radius: var(--border-radius);
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
box-shadow: 0px 5px 4px var(--color-gray-4);
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
display: flex;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
justify-content: center;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
align-items: center;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
}
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
.download_close_modal {
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
float: right;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
margin-right: 10px;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
font-size: 25px;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
}
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
.download-progress__current-downloading {
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
position: fixed;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
bottom: 25px;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
right: 15px;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
border: none;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
width: 30px;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
height: 30px;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
display: flex;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
justify-content: center;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
align-items: center;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
margin: 0;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
animation-name: downloadcount;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
animation-duration: 1.3s;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
animation-iteration-count: infinite;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
.notification__bubble {
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
height: 1.5rem;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
width: 1.5rem;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
border-radius: 50%;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
background-color: var(--color-editor-tag);
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
position: absolute;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
top: -0.5rem;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
right: -0.5rem;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
color: white;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
font-size: var(--font-small);
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
font-weight: bold;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
line-height: 1;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
display: flex;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
align-items: center;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
justify-content: center;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
}
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
.notification__bubble--small {
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
font-size: var(--font-xsmall);
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
}
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
.notification__bubble--inline {
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
@extend .notification__bubble;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
top: 0.75rem;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
right: 1rem;
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
}
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
}
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
@keyframes downloadcount {
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
0% {
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
transform: translateY(-10px);
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
}
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
50% {
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
transform: translateY(-3px);
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
}
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
100% {
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
transform: translateY(-10px);
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
}
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
}
jessopb commented 2021-10-01 23:38:11 +02:00 (Migrated from github.com)
Review

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.

We'll probably want to replace a lot of values with some existing vars at polishing time. This will also make it support dark mode.
jessopb commented 2021-10-01 23:58:10 +02:00 (Migrated from github.com)
Review

I like this color, but maybe it should use var(--color-primary)?

I like this color, but maybe it should use var(--color-primary)?
jessopb commented 2021-10-02 06:49:48 +02:00 (Migrated from github.com)
Review

dark mode, unless my .env is messed up
image

dark mode, unless my .env is messed up ![image](https://user-images.githubusercontent.com/36554050/135703949-ec59f91e-6512-43b7-8a08-4376ab509243.png)
jessopb commented 2021-10-02 07:07:15 +02:00 (Migrated from github.com)
Review

http://getbem.com/naming/
This is our css naming convention, so
download-progress__bar-container

http://getbem.com/naming/ This is our css naming convention, so download-progress__bar-container
jessopb commented 2021-10-08 20:25:59 +02:00 (Migrated from github.com)
Review

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?

having a border, especially high contrast, is a somewhat new pattern. what would make it more consistent with the rest of the app?
jessopb commented 2021-10-08 20:34:40 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)
jessopb commented 2021-10-08 20:36:36 +02:00 (Migrated from github.com)
Review

try var(--border-radius)

try var(--border-radius)

View file

@ -121,6 +121,11 @@
overflow-x: hidden; overflow-x: hidden;
} }
.menu__link-disable {
@extend .menu__link;
color: var(--color-text-subtitle) !important;
}
.menu__link--notification { .menu__link--notification {
width: 100%; width: 100%;
display: flex; display: flex;

18
ui/util/array.js Normal file
View file

@ -0,0 +1,18 @@
export function areEqual(first, second) {
if (first.length !== second.length) {
return false;
}
for (let i = 0; i < first.length; i++) {
if (!second.includes(first[i])) {
return false;
}
}
return true;
}
export function removeItem(array, item) {
const index = array.indexOf(item);
if (index > -1) {
array.splice(index, 1);
}
}

View file

@ -3,14 +3,14 @@ const downloadSize = 1093957; // this must match with the image above
let startTime, endTime; let startTime, endTime;
async function measureConnectionSpeed() { async function measureConnectionSpeed() {
startTime = (new Date()).getTime(); startTime = new Date().getTime();
const cacheBuster = '?nnn=' + startTime; const cacheBuster = '?nnn=' + startTime;
const download = new Image(); const download = new Image();
download.src = imageAddr + cacheBuster; download.src = imageAddr + cacheBuster;
// this returns when the image is finished downloading // this returns when the image is finished downloading
await download.decode(); await download.decode();
endTime = (new Date()).getTime(); endTime = new Date().getTime();
const duration = (endTime - startTime) / 1000; const duration = (endTime - startTime) / 1000;
const bitsLoaded = downloadSize * 8; const bitsLoaded = downloadSize * 8;
const speedBps = (bitsLoaded / duration).toFixed(2); const speedBps = (bitsLoaded / duration).toFixed(2);

View file

@ -69,3 +69,4 @@
@import '../../ui/scss/component/empty'; @import '../../ui/scss/component/empty';
@import '../../ui/scss/component/stripe-card'; @import '../../ui/scss/component/stripe-card';
@import '../../ui/scss/component/wallet-tip-send'; @import '../../ui/scss/component/wallet-tip-send';
@import '../../ui/scss/component/download-progress';