Add ability to search through publishes. #7535

Merged
Ruk33 merged 8 commits from 3139-ability-to-search-through-publishes into master 2022-04-15 05:06:00 +02:00
6 changed files with 106 additions and 33 deletions
Showing only changes of commit e15bc0e8b8 - Show all commits

View file

@ -128,6 +128,8 @@ export const FETCH_CHANNEL_CLAIMS_COMPLETED = 'FETCH_CHANNEL_CLAIMS_COMPLETED';
export const FETCH_CHANNEL_CLAIM_COUNT_STARTED = 'FETCH_CHANNEL_CLAIM_COUNT_STARTED'; export const FETCH_CHANNEL_CLAIM_COUNT_STARTED = 'FETCH_CHANNEL_CLAIM_COUNT_STARTED';
export const FETCH_CLAIM_LIST_MINE_STARTED = 'FETCH_CLAIM_LIST_MINE_STARTED'; export const FETCH_CLAIM_LIST_MINE_STARTED = 'FETCH_CLAIM_LIST_MINE_STARTED';
export const FETCH_CLAIM_LIST_MINE_COMPLETED = 'FETCH_CLAIM_LIST_MINE_COMPLETED'; export const FETCH_CLAIM_LIST_MINE_COMPLETED = 'FETCH_CLAIM_LIST_MINE_COMPLETED';
export const FETCH_ALL_CLAIM_LIST_MINE_STARTED = 'FETCH_ALL_CLAIM_LIST_MINE_STARTED';
export const FETCH_ALL_CLAIM_LIST_MINE_COMPLETED = 'FETCH_ALL_CLAIM_LIST_MINE_COMPLETED';
export const ABANDON_CLAIM_STARTED = 'ABANDON_CLAIM_STARTED'; export const ABANDON_CLAIM_STARTED = 'ABANDON_CLAIM_STARTED';
export const ABANDON_CLAIM_SUCCEEDED = 'ABANDON_CLAIM_SUCCEEDED'; export const ABANDON_CLAIM_SUCCEEDED = 'ABANDON_CLAIM_SUCCEEDED';
export const FETCH_CHANNEL_LIST_STARTED = 'FETCH_CHANNEL_LIST_STARTED'; export const FETCH_CHANNEL_LIST_STARTED = 'FETCH_CHANNEL_LIST_STARTED';

View file

@ -1,11 +1,10 @@
import { connect } from 'react-redux'; import { connect } from 'react-redux';
import { import {
selectIsFetchingClaimListMine, selectIsFetchingAllMyClaims,
selectMyClaimsPage,
selectMyClaimsPageItemCount,
selectFetchingMyClaimsPageError, selectFetchingMyClaimsPageError,
selectAllMyClaims,
} from 'redux/selectors/claims'; } from 'redux/selectors/claims';
import { doFetchClaimListMine, doCheckPendingClaims } from 'redux/actions/claims'; import { doCheckPendingClaims, doFetchAllClaimListMine } from 'redux/actions/claims';
import { doClearPublish } from 'redux/actions/publish'; import { doClearPublish } from 'redux/actions/publish';
import FileListPublished from './view'; import FileListPublished from './view';
import { withRouter } from 'react-router'; import { withRouter } from 'react-router';
@ -20,18 +19,16 @@ const select = (state, props) => {
return { return {
page, page,
pageSize, pageSize,
fetching: selectIsFetchingClaimListMine(state), fetching: selectIsFetchingAllMyClaims(state),
urls: selectMyClaimsPage(state),
urlTotal: selectMyClaimsPageItemCount(state),
error: selectFetchingMyClaimsPageError(state), error: selectFetchingMyClaimsPageError(state),
myClaims: selectAllMyClaims(state),
}; };
}; };
const perform = (dispatch) => ({ const perform = (dispatch) => ({
checkPendingPublishes: () => dispatch(doCheckPendingClaims()), checkPendingPublishes: () => dispatch(doCheckPendingClaims()),
fetchClaimListMine: (page, pageSize, resolve, filterBy) =>
dispatch(doFetchClaimListMine(page, pageSize, resolve, filterBy)),
clearPublish: () => dispatch(doClearPublish()), clearPublish: () => dispatch(doClearPublish()),
fetchAllMyClaims: () => dispatch(doFetchAllClaimListMine()),
}); });
export default withRouter(connect(select, perform)(FileListPublished)); export default withRouter(connect(select, perform)(FileListPublished));

View file

@ -1,7 +1,7 @@
// @flow // @flow
import * as PAGES from 'constants/pages'; import * as PAGES from 'constants/pages';
import * as ICONS from 'constants/icons'; import * as ICONS from 'constants/icons';
import React, { useEffect } from 'react'; import React, { useEffect, useMemo } from 'react';
import Button from 'component/button'; import Button from 'component/button';
import ClaimList from 'component/claimList'; import ClaimList from 'component/claimList';
import Page from 'component/page'; import Page from 'component/page';
@ -9,6 +9,8 @@ import Paginate from 'component/common/paginate';
import { PAGE_PARAM, PAGE_SIZE_PARAM } from 'constants/claim'; import { PAGE_PARAM, PAGE_SIZE_PARAM } from 'constants/claim';
import Spinner from 'component/spinner'; import Spinner from 'component/spinner';
import Yrbl from 'component/yrbl'; import Yrbl from 'component/yrbl';
import { FormField, Form } from 'component/common/form';
import Icon from 'component/common/icon';
import classnames from 'classnames'; import classnames from 'classnames';
const FILTER_ALL = 'stream,repost'; const FILTER_ALL = 'stream,repost';
@ -18,19 +20,19 @@ const FILTER_REPOSTS = 'repost';
type Props = { type Props = {
checkPendingPublishes: () => void, checkPendingPublishes: () => void,
clearPublish: () => void, clearPublish: () => void,
fetchClaimListMine: (number, number, boolean, Array<string>) => void,
fetching: boolean, fetching: boolean,
urls: Array<string>,
urlTotal: number,
history: { replace: (string) => void, push: (string) => void }, history: { replace: (string) => void, push: (string) => void },
page: number, page: number,
pageSize: number, pageSize: number,
myClaims: any,
fetchAllMyClaims: () => void,
}; };
function FileListPublished(props: Props) { function FileListPublished(props: Props) {
const { checkPendingPublishes, clearPublish, fetchClaimListMine, fetching, urls, urlTotal, page, pageSize } = props; const { checkPendingPublishes, clearPublish, fetching, page, pageSize, myClaims, fetchAllMyClaims } = props;
const [filterBy, setFilterBy] = React.useState(FILTER_ALL); const [filterBy, setFilterBy] = React.useState(FILTER_ALL);
const [searchText, setSearchText] = React.useState('');
const params = {}; const params = {};
params[PAGE_PARAM] = Number(page); params[PAGE_PARAM] = Number(page);
@ -42,12 +44,44 @@ function FileListPublished(props: Props) {
checkPendingPublishes(); checkPendingPublishes();
}, [checkPendingPublishes]); }, [checkPendingPublishes]);
useEffect(() => { const filteredClaims = useMemo(() => {
if (paramsString && fetchClaimListMine) { if (fetching) {
const params = JSON.parse(paramsString); return [];
fetchClaimListMine(params.page, params.page_size, true, filterBy.split(','));
} }
}, [paramsString, filterBy, fetchClaimListMine]);
return myClaims.filter((claim) => {
const value = claim.value || {};
const src = value.source || {};
const title = (value.title || '').toLowerCase();
const description = (value.description || '').toLowerCase();
const tags = (value.tags || []).join('').toLowerCase();
Ruk33 commented 2022-04-06 17:41:52 +02:00 (Migrated from github.com)
Review

@jessopb I'm not entirely happy with this but I couldn't think of a better way to work around this issue.

@jessopb I'm not entirely happy with this but I couldn't think of a better way to work around this issue.
jessopb commented 2022-04-07 15:05:19 +02:00 (Migrated from github.com)
Review

Seems to work really well. I don't think you need "disableHistory" - that mostly doesn't exist except if it's passed to <Paginate as a prop, and only on one page.

Seems to work really well. I don't think you need "disableHistory" - that mostly doesn't exist except if it's passed to <Paginate as a prop, and only on one page.
Ruk33 commented 2022-04-15 02:42:44 +02:00 (Migrated from github.com)
Review

Updated. Thanks @jessopb for the comment.

Updated. Thanks @jessopb for the comment.
const srcName = (src.name || '').toLowerCase();
const lowerCaseSearchText = searchText.toLowerCase();
const textMatches =
!searchText ||
title.indexOf(lowerCaseSearchText) !== -1 ||
description.indexOf(lowerCaseSearchText) !== -1 ||
tags.indexOf(lowerCaseSearchText) !== -1 ||
srcName.indexOf(lowerCaseSearchText) !== -1;
return textMatches && filterBy.includes(claim.value_type);
});
}, [fetching, myClaims, filterBy, searchText]);
const urlTotal = filteredClaims.length;
const urls = useMemo(() => {
const params = JSON.parse(paramsString);
const zeroIndexPage = Math.max(0, params.page - 1);
const paginated = filteredClaims.slice(
zeroIndexPage * params.page_size,
zeroIndexPage * params.page_size + params.page_size
);
return paginated.map((claim) => claim.permanent_url);
}, [filteredClaims, paramsString]);
useEffect(() => {
fetchAllMyClaims();
}, [fetchAllMyClaims]);
return ( return (
<Page> <Page>
@ -89,20 +123,18 @@ function FileListPublished(props: Props) {
<div className="card__actions--inline"> <div className="card__actions--inline">
{fetching && <Spinner type="small" />} {fetching && <Spinner type="small" />}
{!fetching && ( {!fetching && (
<Button <Button button="alt" label={__('Refresh')} icon={ICONS.REFRESH} onClick={fetchAllMyClaims} />
button="alt"
label={__('Refresh')}
icon={ICONS.REFRESH}
onClick={() => fetchClaimListMine(params.page, params.page_size, true, filterBy.split(','))}
/>
)} )}
<Button <Form onSubmit={() => {}} className="wunderbar--inline">
icon={ICONS.PUBLISH} <Icon icon={ICONS.SEARCH} />
button="secondary" <FormField
label={__('Upload')} className="wunderbar__input--inline"
navigate={`/$/${PAGES.UPLOAD}`} value={searchText}
onClick={() => clearPublish()} onChange={(e) => setSearchText(e.target.value)}
/> type="text"
placeholder={__('Search')}
/>
</Form>
</div> </div>
} }
persistedStorageKey="claim-list-published" persistedStorageKey="claim-list-published"
@ -112,7 +144,7 @@ function FileListPublished(props: Props) {
</> </>
)} )}
</div> </div>
{!(urls && urls.length) && ( {!fetching && myClaims.length === 0 && (
<React.Fragment> <React.Fragment>
{!fetching ? ( {!fetching ? (
<section className="main--empty"> <section className="main--empty">

View file

@ -184,6 +184,29 @@ export function doFetchClaimListMine(
}; };
} }
export function doFetchAllClaimListMine() {
return (dispatch: Dispatch) => {
dispatch({
type: ACTIONS.FETCH_ALL_CLAIM_LIST_MINE_STARTED,
});
// $FlowFixMe
Lbry.claim_list({
page: 1,
page_size: 99999,
claim_type: ['stream', 'repost'],
resolve: true,
}).then((result: StreamListResponse) => {
dispatch({
type: ACTIONS.FETCH_ALL_CLAIM_LIST_MINE_COMPLETED,
data: {
result,
},
});
});
};
}
export function doAbandonTxo(txo: Txo, cb: (string) => void) { export function doAbandonTxo(txo: Txo, cb: (string) => void) {
return (dispatch: Dispatch) => { return (dispatch: Dispatch) => {
if (cb) cb(ABANDON_STATES.PENDING); if (cb) cb(ABANDON_STATES.PENDING);

View file

@ -61,6 +61,8 @@ type State = {
isCheckingNameForPublish: boolean, isCheckingNameForPublish: boolean,
checkingPending: boolean, checkingPending: boolean,
checkingReflecting: boolean, checkingReflecting: boolean,
isFetchingAllClaimListMine: boolean,
allClaimListMine: ?ClaimListResponse,
}; };
const reducers = {}; const reducers = {};
@ -109,6 +111,8 @@ const defaultState = {
isCheckingNameForPublish: false, isCheckingNameForPublish: false,
checkingPending: false, checkingPending: false,
checkingReflecting: false, checkingReflecting: false,
isFetchingAllClaimListMine: false,
allClaimListMine: undefined,
}; };
function handleClaimAction(state: State, action: any): State { function handleClaimAction(state: State, action: any): State {
@ -273,6 +277,17 @@ reducers[ACTIONS.FETCH_CLAIM_LIST_MINE_COMPLETED] = (state: State, action: any):
}); });
}; };
reducers[ACTIONS.FETCH_ALL_CLAIM_LIST_MINE_STARTED] = (state: State): State =>
Object.assign({}, state, {
isFetchingAllClaimListMine: true,
});
reducers[ACTIONS.FETCH_ALL_CLAIM_LIST_MINE_COMPLETED] = (state: State, action: any): State =>
Object.assign({}, state, {
isFetchingAllClaimListMine: false,
allClaimListMine: action.data.result.items,
});
reducers[ACTIONS.FETCH_CHANNEL_LIST_STARTED] = (state: State): State => reducers[ACTIONS.FETCH_CHANNEL_LIST_STARTED] = (state: State): State =>
Object.assign({}, state, { fetchingMyChannels: true }); Object.assign({}, state, { fetchingMyChannels: true });

View file

@ -410,6 +410,10 @@ export const selectIsFetchingClaimListMine = (state: State) => selectState(state
export const selectMyClaimsPage = createSelector(selectState, (state) => state.myClaimsPageResults || []); export const selectMyClaimsPage = createSelector(selectState, (state) => state.myClaimsPageResults || []);
export const selectAllMyClaims = createSelector(selectState, (state) => state.allClaimListMine || []);
export const selectIsFetchingAllMyClaims = createSelector(selectState, (state) => state.isFetchingAllClaimListMine);
export const selectMyClaimsPageNumber = createSelector( export const selectMyClaimsPageNumber = createSelector(
selectState, selectState,
(state) => (state.claimListMinePage && state.claimListMinePage.items) || [], (state) => (state.claimListMinePage && state.claimListMinePage.items) || [],