LBRYCommunity/lbry-desktop
1
0
Fork 0
Code Issues 596 Pull requests 6 Projects Releases 238 Packages Wiki Activity

fix hover style for char count field #7620

Merged
ByronEricPerez merged 6 commits from 7564-comment-box-hides-icon-when-hovering-over-button into master 2022-07-07 22:55:31 +02:00
Conversation 7 Commits 6 Files changed 3 -8
1 changed files with 0 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit d7fecafacf - Show all commits

8
ui/scss/component/_button.scss
View file

@ -393,14 +393,6 @@ a.button--alt {
height: initial;
padding: 5px;
jessopb commented 2022-07-05 17:28:45 +02:00 (Migrated from github.com)
Review
Copy link

I know it's not super D.R.Y. but I would duplicate the button--file-action class contents here.

Then we can get rid of commented out lines.

I know it's not super D.R.Y. but I would duplicate the button--file-action class contents here. Then we can get rid of commented out lines.
&.button--comment-icons-active {
.icon {
fill: var(--color-primary-alt);
stroke: var(--color-primary) !important; //fixme
color: var(--color-primary);
}
}
@media (max-width: $breakpoint-small) {
jessopb commented 2022-07-06 00:01:02 +02:00 (Migrated from github.com)
Review
Copy link

There's a duplicate padding: line here. Also, whenever possible, we're trying to use vars for spacing, as above. Does one of those work?

There's a duplicate padding: line here. Also, whenever possible, we're trying to use vars for spacing, as above. Does one of those work?
padding: 0 0;
}