LBRYCommunity/lbry-desktop
1
0
Fork 0
Code Issues 596 Pull requests 6 Projects Releases 238 Packages Wiki Activity

Added checkbox to enable/disable background #7630

Merged
ByronEricPerez merged 4 commits from Add_a_setting_to_disable_the_background_image_#7616 into master 2022-06-28 22:01:19 +02:00
Conversation 0 Commits 4 Files changed 7 +11 -11
7 changed files with 11 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit b77ae9b0ea - Show all commits

1
static/app-strings.json
View file

@ -2313,7 +2313,6 @@
"Top content in %language%": "Top content in %language%", "Top content in %language%": "Top content in %language%",
"Apply": "Apply", "Apply": "Apply",
"24-hour clock": "24-hour clock", "24-hour clock": "24-hour clock",
"background": "background",
"Disable background": "Disable background", "Disable background": "Disable background",
"--end--": "--end--" "--end--": "--end--"
} }

2
ui/component/settingAppearance/index.js
View file

@ -5,7 +5,7 @@ import { makeSelectClientSetting } from 'redux/selectors/settings';
import SettingAppearance from './view'; import SettingAppearance from './view';
const select = (state) => ({ const select = (state) => ({
background: makeSelectClientSetting(SETTINGS.BACKGROUND)(state), disableBackground: makeSelectClientSetting(SETTINGS.DISABLE_BACKGROUND)(state),
clock24h: makeSelectClientSetting(SETTINGS.CLOCK_24H)(state), clock24h: makeSelectClientSetting(SETTINGS.CLOCK_24H)(state),
searchInLanguage: makeSelectClientSetting(SETTINGS.SEARCH_IN_LANGUAGE)(state), searchInLanguage: makeSelectClientSetting(SETTINGS.SEARCH_IN_LANGUAGE)(state),
hideBalance: makeSelectClientSetting(SETTINGS.HIDE_BALANCE)(state), hideBalance: makeSelectClientSetting(SETTINGS.HIDE_BALANCE)(state),

8
ui/component/settingAppearance/view.jsx
View file

@ -12,7 +12,7 @@ import ThemeSelector from 'component/themeSelector';
import homepages from 'homepages'; import homepages from 'homepages';
type Props = { type Props = {
background: boolean, disableBackground: boolean,
clock24h: boolean, clock24h: boolean,
searchInLanguage: boolean, searchInLanguage: boolean,
hideBalance: boolean, hideBalance: boolean,
@ -21,7 +21,7 @@ type Props = {
}; };
export default function SettingAppearance(props: Props) { export default function SettingAppearance(props: Props) {
const { clock24h, background, searchInLanguage, hideBalance, setClientSetting, setSearchInLanguage } = props; const { clock24h, disableBackground, searchInLanguage, hideBalance, setClientSetting, setSearchInLanguage } = props;
return ( return (
<> <>
@ -68,8 +68,8 @@ export default function SettingAppearance(props: Props) {
<FormField <FormField
type="checkbox" type="checkbox"
name="background" name="background"
onChange={() => setClientSetting(SETTINGS.BACKGROUND, !background)} onChange={() => setClientSetting(SETTINGS.DISABLE_BACKGROUND, !disableBackground)}
checked={background} checked={disableBackground}
/> />
</SettingsRow> </SettingsRow>
<SettingsRow title={__('Hide wallet balance in header')}> <SettingsRow title={__('Hide wallet balance in header')}>

2
ui/component/wallpaper/index.js
View file

@ -4,7 +4,7 @@ import * as SETTINGS from 'constants/settings';
import { makeSelectClientSetting } from 'redux/selectors/settings'; import { makeSelectClientSetting } from 'redux/selectors/settings';
jessopb commented 2022-06-28 19:38:34 +02:00 (Migrated from github.com)
Review
Copy link

https://github.com/lbryio/lbry-desktop/blob/master/ui/redux/reducers/settings.js we've been making sure client settings have defaults

https://github.com/lbryio/lbry-desktop/blob/master/ui/redux/reducers/settings.js we've been making sure client settings have defaults
const select = (state) => ({ const select = (state) => ({
background: makeSelectClientSetting(SETTINGS.BACKGROUND)(state), disableBackground: makeSelectClientSetting(SETTINGS.DISABLE_BACKGROUND)(state),
}); });
const perform = {}; const perform = {};

6
ui/component/wallpaper/view.jsx
View file

@ -8,11 +8,11 @@ type Props = {
// cover: ?string, // cover: ?string,
// avatar: ?string, // avatar: ?string,
reset: ?boolean, reset: ?boolean,
background: ?boolean, disableBackground: ?boolean,
}; };
const Wallpaper = (props: Props) => { const Wallpaper = (props: Props) => {
const { background } = props; const { disableBackground } = props;
/* /*
if (avatar) { if (avatar) {
@ -234,7 +234,7 @@ const Wallpaper = (props: Props) => {
<div <div
className={'background-image'} className={'background-image'}
style={{ style={{
backgroundImage: background ? `none` : `url(${freeezepeach})`, backgroundImage: disableBackground ? `none` : `url(${freeezepeach})`,
}} }}
/> />
<div className={'theme'} /> <div className={'theme'} />

2
ui/constants/settings.js
View file

@ -14,7 +14,7 @@ export const THEME = 'theme';
export const THEMES = 'themes'; export const THEMES = 'themes';
export const AUTOMATIC_DARK_MODE_ENABLED = 'automatic_dark_mode_enabled'; export const AUTOMATIC_DARK_MODE_ENABLED = 'automatic_dark_mode_enabled';
export const CLOCK_24H = 'clock_24h'; export const CLOCK_24H = 'clock_24h';
export const BACKGROUND = 'background'; export const DISABLE_BACKGROUND = 'disableBackground';
export const AUTOPLAY_MEDIA = 'autoplay'; export const AUTOPLAY_MEDIA = 'autoplay';
export const AUTOPLAY_NEXT = 'autoplay_next'; export const AUTOPLAY_NEXT = 'autoplay_next';
export const OS_NOTIFICATIONS_ENABLED = 'os_notifications_enabled'; export const OS_NOTIFICATIONS_ENABLED = 'os_notifications_enabled';

1
ui/redux/reducers/settings.js
View file

@ -40,6 +40,7 @@ const defaultState = {
[SETTINGS.OS_NOTIFICATIONS_ENABLED]: true, [SETTINGS.OS_NOTIFICATIONS_ENABLED]: true,
[SETTINGS.AUTOMATIC_DARK_MODE_ENABLED]: false, [SETTINGS.AUTOMATIC_DARK_MODE_ENABLED]: false,
[SETTINGS.CLOCK_24H]: false, [SETTINGS.CLOCK_24H]: false,
[SETTINGS.DISABLE_BACKGROUND]: false,
[SETTINGS.TILE_LAYOUT]: true, [SETTINGS.TILE_LAYOUT]: true,
[SETTINGS.VIDEO_THEATER_MODE]: false, [SETTINGS.VIDEO_THEATER_MODE]: false,
[SETTINGS.VIDEO_PLAYBACK_RATE]: 1, [SETTINGS.VIDEO_PLAYBACK_RATE]: 1,