Added checkbox to enable/disable background #7630

Merged
ByronEricPerez merged 4 commits from Add_a_setting_to_disable_the_background_image_#7616 into master 2022-06-28 22:01:19 +02:00
7 changed files with 11 additions and 11 deletions
Showing only changes of commit b77ae9b0ea - Show all commits

View file

@ -2313,7 +2313,6 @@
"Top content in %language%": "Top content in %language%",
"Apply": "Apply",
"24-hour clock": "24-hour clock",
"background": "background",
"Disable background": "Disable background",
"--end--": "--end--"
}

View file

@ -5,7 +5,7 @@ import { makeSelectClientSetting } from 'redux/selectors/settings';
import SettingAppearance from './view';
const select = (state) => ({
background: makeSelectClientSetting(SETTINGS.BACKGROUND)(state),
disableBackground: makeSelectClientSetting(SETTINGS.DISABLE_BACKGROUND)(state),
clock24h: makeSelectClientSetting(SETTINGS.CLOCK_24H)(state),
searchInLanguage: makeSelectClientSetting(SETTINGS.SEARCH_IN_LANGUAGE)(state),
hideBalance: makeSelectClientSetting(SETTINGS.HIDE_BALANCE)(state),

View file

@ -12,7 +12,7 @@ import ThemeSelector from 'component/themeSelector';
import homepages from 'homepages';
type Props = {
background: boolean,
disableBackground: boolean,
clock24h: boolean,
searchInLanguage: boolean,
hideBalance: boolean,
@ -21,7 +21,7 @@ type Props = {
};
export default function SettingAppearance(props: Props) {
const { clock24h, background, searchInLanguage, hideBalance, setClientSetting, setSearchInLanguage } = props;
const { clock24h, disableBackground, searchInLanguage, hideBalance, setClientSetting, setSearchInLanguage } = props;
return (
<>
@ -68,8 +68,8 @@ export default function SettingAppearance(props: Props) {
<FormField
type="checkbox"
name="background"
onChange={() => setClientSetting(SETTINGS.BACKGROUND, !background)}
checked={background}
onChange={() => setClientSetting(SETTINGS.DISABLE_BACKGROUND, !disableBackground)}
checked={disableBackground}
/>
</SettingsRow>
<SettingsRow title={__('Hide wallet balance in header')}>

View file

@ -4,7 +4,7 @@ import * as SETTINGS from 'constants/settings';
import { makeSelectClientSetting } from 'redux/selectors/settings';
jessopb commented 2022-06-28 19:38:34 +02:00 (Migrated from github.com)
Review

https://github.com/lbryio/lbry-desktop/blob/master/ui/redux/reducers/settings.js we've been making sure client settings have defaults

https://github.com/lbryio/lbry-desktop/blob/master/ui/redux/reducers/settings.js we've been making sure client settings have defaults
const select = (state) => ({
background: makeSelectClientSetting(SETTINGS.BACKGROUND)(state),
disableBackground: makeSelectClientSetting(SETTINGS.DISABLE_BACKGROUND)(state),
});
const perform = {};

View file

@ -8,11 +8,11 @@ type Props = {
// cover: ?string,
// avatar: ?string,
reset: ?boolean,
background: ?boolean,
disableBackground: ?boolean,
};
const Wallpaper = (props: Props) => {
const { background } = props;
const { disableBackground } = props;
/*
if (avatar) {
@ -234,7 +234,7 @@ const Wallpaper = (props: Props) => {
<div
className={'background-image'}
style={{
backgroundImage: background ? `none` : `url(${freeezepeach})`,
backgroundImage: disableBackground ? `none` : `url(${freeezepeach})`,
}}
/>
<div className={'theme'} />

View file

@ -14,7 +14,7 @@ export const THEME = 'theme';
export const THEMES = 'themes';
export const AUTOMATIC_DARK_MODE_ENABLED = 'automatic_dark_mode_enabled';
export const CLOCK_24H = 'clock_24h';
export const BACKGROUND = 'background';
export const DISABLE_BACKGROUND = 'disableBackground';
export const AUTOPLAY_MEDIA = 'autoplay';
export const AUTOPLAY_NEXT = 'autoplay_next';
export const OS_NOTIFICATIONS_ENABLED = 'os_notifications_enabled';

View file

@ -40,6 +40,7 @@ const defaultState = {
[SETTINGS.OS_NOTIFICATIONS_ENABLED]: true,
[SETTINGS.AUTOMATIC_DARK_MODE_ENABLED]: false,
[SETTINGS.CLOCK_24H]: false,
[SETTINGS.DISABLE_BACKGROUND]: false,
[SETTINGS.TILE_LAYOUT]: true,
[SETTINGS.VIDEO_THEATER_MODE]: false,
[SETTINGS.VIDEO_PLAYBACK_RATE]: 1,