LBRYCommunity/lbry-desktop
1
0
Fork 0
Code Issues 596 Pull requests 6 Projects Releases 238 Packages Wiki Activity

Update documentation for DevTools and fix some ESLint warnings #911

Merged
IGassmann merged 8 commits from issue/763 into master 2018-01-02 06:41:40 +01:00
Conversation 0 Commits 8 Files changed 42 +6
1 changed files with 6 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit a7aef67d68 - Show all commits

6
README.md
View file

@ -43,6 +43,12 @@ This will download and install the LBRY app and its dependencies, including
liamcardenas commented 2017-12-28 19:57:18 +01:00 (Migrated from github.com)
Review
Copy link

Why did you take out this section? I don't see any explanation for how people are supposed to do ongoing dev

Why did you take out this section? I don't see any explanation for how people are supposed to do ongoing dev
liamcardenas commented 2017-12-28 19:59:09 +01:00 (Migrated from github.com)
Review
Copy link

ah nvm i see that its in contributing.md, but I think its still worth mentioning in this doc

ah nvm i see that its in contributing.md, but I think its still worth mentioning in this doc
IGassmann commented 2017-12-29 03:46:29 +01:00 (Migrated from github.com)
Review
Copy link

I've added a "Running" section. Eventually, we will be able to run the app without HMR by using yarn start. For the meantime, it's only yarn dev.

I've added a "Running" section. Eventually, we will be able to run the app without HMR by using yarn start. For the meantime, it's only yarn dev.
liamcardenas commented 2017-12-28 19:57:18 +01:00 (Migrated from github.com)
Review
Copy link

Why did you take out this section? I don't see any explanation for how people are supposed to do ongoing dev

Why did you take out this section? I don't see any explanation for how people are supposed to do ongoing dev
liamcardenas commented 2017-12-28 19:59:09 +01:00 (Migrated from github.com)
Review
Copy link

ah nvm i see that its in contributing.md, but I think its still worth mentioning in this doc

ah nvm i see that its in contributing.md, but I think its still worth mentioning in this doc
IGassmann commented 2017-12-29 03:46:29 +01:00 (Migrated from github.com)
Review
Copy link

I've added a "Running" section. Eventually, we will be able to run the app without HMR by using yarn start. For the meantime, it's only yarn dev.

I've added a "Running" section. Eventually, we will be able to run the app without HMR by using yarn start. For the meantime, it's only yarn dev.
The LBRY app requires Node >= 6; if you have an earlier version of Node installed and want to keep
it, you can use [nvm](https://github.com/creationix/nvm) to switch back and forth.
### Running
liamcardenas commented 2017-12-28 19:57:18 +01:00 (Migrated from github.com)
Review
Copy link

Why did you take out this section? I don't see any explanation for how people are supposed to do ongoing dev

Why did you take out this section? I don't see any explanation for how people are supposed to do ongoing dev
liamcardenas commented 2017-12-28 19:59:09 +01:00 (Migrated from github.com)
Review
Copy link

ah nvm i see that its in contributing.md, but I think its still worth mentioning in this doc

ah nvm i see that its in contributing.md, but I think its still worth mentioning in this doc
IGassmann commented 2017-12-29 03:46:29 +01:00 (Migrated from github.com)
Review
Copy link

I've added a "Running" section. Eventually, we will be able to run the app without HMR by using yarn start. For the meantime, it's only yarn dev.

I've added a "Running" section. Eventually, we will be able to run the app without HMR by using yarn start. For the meantime, it's only yarn dev.
liamcardenas commented 2017-12-28 19:57:18 +01:00 (Migrated from github.com)
Review
Copy link

Why did you take out this section? I don't see any explanation for how people are supposed to do ongoing dev

Why did you take out this section? I don't see any explanation for how people are supposed to do ongoing dev
liamcardenas commented 2017-12-28 19:59:09 +01:00 (Migrated from github.com)
Review
Copy link

ah nvm i see that its in contributing.md, but I think its still worth mentioning in this doc

ah nvm i see that its in contributing.md, but I think its still worth mentioning in this doc
IGassmann commented 2017-12-29 03:46:29 +01:00 (Migrated from github.com)
Review
Copy link

I've added a "Running" section. Eventually, we will be able to run the app without HMR by using yarn start. For the meantime, it's only yarn dev.

I've added a "Running" section. Eventually, we will be able to run the app without HMR by using yarn start. For the meantime, it's only yarn dev.
The app can be run from the sources using the following command:
liamcardenas commented 2017-12-28 19:57:18 +01:00 (Migrated from github.com)
Review
Copy link

Why did you take out this section? I don't see any explanation for how people are supposed to do ongoing dev

Why did you take out this section? I don't see any explanation for how people are supposed to do ongoing dev
liamcardenas commented 2017-12-28 19:59:09 +01:00 (Migrated from github.com)
Review
Copy link

ah nvm i see that its in contributing.md, but I think its still worth mentioning in this doc

ah nvm i see that its in contributing.md, but I think its still worth mentioning in this doc
IGassmann commented 2017-12-29 03:46:29 +01:00 (Migrated from github.com)
Review
Copy link

I've added a "Running" section. Eventually, we will be able to run the app without HMR by using yarn start. For the meantime, it's only yarn dev.

I've added a "Running" section. Eventually, we will be able to run the app without HMR by using yarn start. For the meantime, it's only yarn dev.
liamcardenas commented 2017-12-28 19:57:18 +01:00 (Migrated from github.com)
Review
Copy link

Why did you take out this section? I don't see any explanation for how people are supposed to do ongoing dev

Why did you take out this section? I don't see any explanation for how people are supposed to do ongoing dev
liamcardenas commented 2017-12-28 19:59:09 +01:00 (Migrated from github.com)
Review
Copy link

ah nvm i see that its in contributing.md, but I think its still worth mentioning in this doc

ah nvm i see that its in contributing.md, but I think its still worth mentioning in this doc
IGassmann commented 2017-12-29 03:46:29 +01:00 (Migrated from github.com)
Review
Copy link

I've added a "Running" section. Eventually, we will be able to run the app without HMR by using yarn start. For the meantime, it's only yarn dev.

I've added a "Running" section. Eventually, we will be able to run the app without HMR by using yarn start. For the meantime, it's only yarn dev.
`yarn dev`
liamcardenas commented 2017-12-28 19:57:18 +01:00 (Migrated from github.com)
Review
Copy link

Why did you take out this section? I don't see any explanation for how people are supposed to do ongoing dev

Why did you take out this section? I don't see any explanation for how people are supposed to do ongoing dev
liamcardenas commented 2017-12-28 19:59:09 +01:00 (Migrated from github.com)
Review
Copy link

ah nvm i see that its in contributing.md, but I think its still worth mentioning in this doc

ah nvm i see that its in contributing.md, but I think its still worth mentioning in this doc
IGassmann commented 2017-12-29 03:46:29 +01:00 (Migrated from github.com)
Review
Copy link

I've added a "Running" section. Eventually, we will be able to run the app without HMR by using yarn start. For the meantime, it's only yarn dev.

I've added a "Running" section. Eventually, we will be able to run the app without HMR by using yarn start. For the meantime, it's only yarn dev.
liamcardenas commented 2017-12-28 19:57:18 +01:00 (Migrated from github.com)
Review
Copy link

Why did you take out this section? I don't see any explanation for how people are supposed to do ongoing dev

Why did you take out this section? I don't see any explanation for how people are supposed to do ongoing dev
liamcardenas commented 2017-12-28 19:59:09 +01:00 (Migrated from github.com)
Review
Copy link

ah nvm i see that its in contributing.md, but I think its still worth mentioning in this doc

ah nvm i see that its in contributing.md, but I think its still worth mentioning in this doc
IGassmann commented 2017-12-29 03:46:29 +01:00 (Migrated from github.com)
Review
Copy link

I've added a "Running" section. Eventually, we will be able to run the app without HMR by using yarn start. For the meantime, it's only yarn dev.

I've added a "Running" section. Eventually, we will be able to run the app without HMR by using yarn start. For the meantime, it's only yarn dev.
### On Windows
#### Windows Dependency

liamcardenas commented 2017-12-28 19:57:18 +01:00 (Migrated from github.com)
Review
Copy link

Why did you take out this section? I don't see any explanation for how people are supposed to do ongoing dev

Why did you take out this section? I don't see any explanation for how people are supposed to do ongoing dev
liamcardenas commented 2017-12-28 19:59:09 +01:00 (Migrated from github.com)
Review
Copy link

ah nvm i see that its in contributing.md, but I think its still worth mentioning in this doc

ah nvm i see that its in contributing.md, but I think its still worth mentioning in this doc
IGassmann commented 2017-12-29 03:46:29 +01:00 (Migrated from github.com)
Review
Copy link

I've added a "Running" section. Eventually, we will be able to run the app without HMR by using yarn start. For the meantime, it's only yarn dev.

I've added a "Running" section. Eventually, we will be able to run the app without HMR by using yarn start. For the meantime, it's only yarn dev.
liamcardenas commented 2017-12-28 19:57:18 +01:00 (Migrated from github.com)
Review
Copy link

Why did you take out this section? I don't see any explanation for how people are supposed to do ongoing dev

Why did you take out this section? I don't see any explanation for how people are supposed to do ongoing dev
liamcardenas commented 2017-12-28 19:59:09 +01:00 (Migrated from github.com)
Review
Copy link

ah nvm i see that its in contributing.md, but I think its still worth mentioning in this doc

ah nvm i see that its in contributing.md, but I think its still worth mentioning in this doc
IGassmann commented 2017-12-29 03:46:29 +01:00 (Migrated from github.com)
Review
Copy link

I've added a "Running" section. Eventually, we will be able to run the app without HMR by using yarn start. For the meantime, it's only yarn dev.

I've added a "Running" section. Eventually, we will be able to run the app without HMR by using yarn start. For the meantime, it's only yarn dev.