fc7edc875b
- [x] (6332) The IntersectionObserver method of lazy-loading loads cached images visibly late on slower devices. Previously, it was also showing the "broken image" icon briefly, which we mended by placing a dummy transparent image as the initial src. - Reverted that ugly transparent image fix. - Use the browser's built-in `loading="lazy"` instead. Sorry, Safari. - [x] Size-optimization did not take "device pixel ratio" into account. - When resizing an image through the CDN, we can't just take the dimensions of the tag in pixels directly -- we need to take zooming into account, otherwise the image ends up blurry. - Previously, we quickly disabled optimization for the channel avatar in the Channel Page because of this. Now that we know the root-cause, the change was reverted and we now go through the CDN with appropriate sizes. This also improves our Web Vital scores. - [x] Size-optimization wasn't really implemented for all ChannelThumbnail instances. - The CDN-optimized size was hardcoded to the largest instance, so small images like sidebar thumbnails are still loading images that are unnecessarily larger. - There's a little-bit of hardcoding of values from CSS here, but I think it's a ok compromise (not something we change often). It also doesn't need to be exact -- the "device pixel ratio" calculate will ensure it's slightly larger than what we need. - [x] Set `width` and `height` of `<img>` to improve CLS. - Addresses Ligthhouse complaints, although technically the shifting was addressed at the `ClaimPreviewTile` level (sub-container dimensions are well defined). - Notes: the values don't need to be the final CSS-adjusted sizes. It just needs to be in the right aspect ratio to help the browser pre-allocate space to avoid shifts. - [x] Add option to disable lazy-load Channel Thumbnails - The guidelines mentioned that items that are already in the viewport should not enable `loading="lazy"`. - We have a few areas where it doesn't make sense to lazy-load (e.g. thumbnail in Header, channel selector dropdown, publish preview, etc.).
115 lines
3.6 KiB
JavaScript
115 lines
3.6 KiB
JavaScript
// @flow
|
|
import { ENABLE_CREATOR_REACTIONS } from 'config';
|
|
import * as ICONS from 'constants/icons';
|
|
import * as PAGES from 'constants/pages';
|
|
import * as REACTION_TYPES from 'constants/reactions';
|
|
import React from 'react';
|
|
import classnames from 'classnames';
|
|
import Button from 'component/button';
|
|
import ChannelThumbnail from 'component/channelThumbnail';
|
|
import { useHistory } from 'react-router';
|
|
|
|
type Props = {
|
|
myReacts: Array<string>,
|
|
othersReacts: any,
|
|
react: (string, string) => void,
|
|
commentId: string,
|
|
pendingCommentReacts: Array<string>,
|
|
claimIsMine: boolean,
|
|
activeChannelId: ?string,
|
|
claim: ?ChannelClaim,
|
|
doToast: ({ message: string }) => void,
|
|
};
|
|
|
|
export default function CommentReactions(props: Props) {
|
|
const { myReacts, othersReacts, commentId, react, claimIsMine, claim, activeChannelId, doToast } = props;
|
|
const {
|
|
push,
|
|
location: { pathname },
|
|
} = useHistory();
|
|
const canCreatorReact =
|
|
claim &&
|
|
claimIsMine &&
|
|
(claim.value_type === 'channel'
|
|
? claim.claim_id === activeChannelId
|
|
: claim.signing_channel && claim.signing_channel.claim_id === activeChannelId);
|
|
const authorUri =
|
|
claim && claim.value_type === 'channel'
|
|
? claim.canonical_url
|
|
: claim && claim.signing_channel && claim.signing_channel.canonical_url;
|
|
|
|
const getCountForReact = (type) => {
|
|
let count = 0;
|
|
if (othersReacts && othersReacts[type]) {
|
|
count += othersReacts[type];
|
|
}
|
|
if (myReacts && myReacts.includes(type)) {
|
|
count += 1;
|
|
}
|
|
return count;
|
|
};
|
|
|
|
const creatorLiked = getCountForReact(REACTION_TYPES.CREATOR_LIKE) > 0;
|
|
|
|
function handleCommentLike() {
|
|
if (activeChannelId) {
|
|
react(commentId, REACTION_TYPES.LIKE);
|
|
} else {
|
|
promptForChannel();
|
|
}
|
|
}
|
|
|
|
function handleCommentDislike() {
|
|
if (activeChannelId) {
|
|
react(commentId, REACTION_TYPES.DISLIKE);
|
|
} else {
|
|
promptForChannel();
|
|
}
|
|
}
|
|
|
|
function promptForChannel() {
|
|
push(`/$/${PAGES.CHANNEL_NEW}?redirect=${pathname}&lc=${commentId}`);
|
|
doToast({ message: __('A channel is required to throw fire and slime') });
|
|
}
|
|
|
|
return (
|
|
<>
|
|
<Button
|
|
requiresAuth={IS_WEB}
|
|
title={__('Upvote')}
|
|
icon={ICONS.UPVOTE}
|
|
className={classnames('comment__action', {
|
|
'comment__action--active': myReacts && myReacts.includes(REACTION_TYPES.LIKE),
|
|
})}
|
|
onClick={handleCommentLike}
|
|
label={<span className="comment__reaction-count">{getCountForReact(REACTION_TYPES.LIKE)}</span>}
|
|
/>
|
|
<Button
|
|
requiresAuth={IS_WEB}
|
|
title={__('Downvote')}
|
|
icon={ICONS.DOWNVOTE}
|
|
className={classnames('comment__action', {
|
|
'comment__action--active': myReacts && myReacts.includes(REACTION_TYPES.DISLIKE),
|
|
})}
|
|
onClick={handleCommentDislike}
|
|
label={<span className="comment__reaction-count">{getCountForReact(REACTION_TYPES.DISLIKE)}</span>}
|
|
/>
|
|
|
|
{ENABLE_CREATOR_REACTIONS && (canCreatorReact || creatorLiked) && (
|
|
<Button
|
|
iconOnly
|
|
disabled={!canCreatorReact || !claimIsMine}
|
|
requiresAuth={IS_WEB}
|
|
title={claimIsMine ? __('You loved this') : __('Creator loved this')}
|
|
icon={creatorLiked ? ICONS.CREATOR_LIKE : ICONS.SUBSCRIBE}
|
|
className={classnames('comment__action comment__action--creator-like')}
|
|
onClick={() => react(commentId, REACTION_TYPES.CREATOR_LIKE)}
|
|
>
|
|
{creatorLiked && (
|
|
<ChannelThumbnail xsmall uri={authorUri} hideStakedIndicator className="comment__creator-like" />
|
|
)}
|
|
</Button>
|
|
)}
|
|
</>
|
|
);
|
|
}
|