ece2312ec5
## Issue `normalizeUri` | `parseURI` is expensive and has been causing sluggish operations when called repeatedly or within a loop. ## Change Since I'm not confident enough to remove the call entirely from makeSelectClaimIsMine (although I've yet to find a scenario that the uri is not already normalized), we'll try caching the calls instead. ## Results - in a simple test of toggling between 2 category pages, we saved 20ms from `parseURI` calls alone. - in a test of opening all categories one time, the memory usage remained similar. This makes sense since we removed a `makeSelect*` (which creates a selector for each call + not memoizing), and replaced that with a cached selector that's actually memoizing.
68 lines
3.1 KiB
JavaScript
68 lines
3.1 KiB
JavaScript
import { connect } from 'react-redux';
|
|
import {
|
|
selectClaimForUri,
|
|
makeSelectIsUriResolving,
|
|
selectClaimIsMineForUri,
|
|
makeSelectClaimIsPending,
|
|
makeSelectClaimIsNsfw,
|
|
makeSelectReflectingClaimForUri,
|
|
makeSelectClaimWasPurchased,
|
|
makeSelectClaimIsStreamPlaceholder,
|
|
makeSelectTitleForUri,
|
|
selectDateForUri,
|
|
} from 'redux/selectors/claims';
|
|
import { makeSelectStreamingUrlForUri } from 'redux/selectors/file_info';
|
|
import {
|
|
makeSelectCollectionIsMine,
|
|
makeSelectUrlsForCollectionId,
|
|
makeSelectIndexForUrlInCollection,
|
|
} from 'redux/selectors/collections';
|
|
|
|
import { doResolveUri } from 'redux/actions/claims';
|
|
import { doCollectionEdit } from 'redux/actions/collections';
|
|
import { doFileGet } from 'redux/actions/file';
|
|
import { selectBanStateForUri } from 'lbryinc';
|
|
import { makeSelectIsActiveLivestream } from 'redux/selectors/livestream';
|
|
import { selectShowMatureContent } from 'redux/selectors/settings';
|
|
import { makeSelectHasVisitedUri } from 'redux/selectors/content';
|
|
import { makeSelectIsSubscribed } from 'redux/selectors/subscriptions';
|
|
import ClaimPreview from './view';
|
|
import formatMediaDuration from 'util/formatMediaDuration';
|
|
|
|
const select = (state, props) => {
|
|
const claim = props.uri && selectClaimForUri(state, props.uri);
|
|
const media = claim && claim.value && (claim.value.video || claim.value.audio);
|
|
const mediaDuration = media && media.duration && formatMediaDuration(media.duration, { screenReader: true });
|
|
|
|
return {
|
|
claim,
|
|
mediaDuration,
|
|
date: props.uri && selectDateForUri(state, props.uri),
|
|
title: props.uri && makeSelectTitleForUri(props.uri)(state),
|
|
pending: props.uri && makeSelectClaimIsPending(props.uri)(state),
|
|
reflectingProgress: props.uri && makeSelectReflectingClaimForUri(props.uri)(state),
|
|
obscureNsfw: selectShowMatureContent(state) === false,
|
|
claimIsMine: props.uri && selectClaimIsMineForUri(state, props.uri),
|
|
isResolvingUri: props.uri && makeSelectIsUriResolving(props.uri)(state),
|
|
isResolvingRepost: props.uri && makeSelectIsUriResolving(props.repostUrl)(state),
|
|
nsfw: props.uri && makeSelectClaimIsNsfw(props.uri)(state),
|
|
banState: selectBanStateForUri(state, props.uri),
|
|
hasVisitedUri: props.uri && makeSelectHasVisitedUri(props.uri)(state),
|
|
isSubscribed: props.uri && makeSelectIsSubscribed(props.uri, true)(state),
|
|
streamingUrl: props.uri && makeSelectStreamingUrlForUri(props.uri)(state),
|
|
wasPurchased: props.uri && makeSelectClaimWasPurchased(props.uri)(state),
|
|
isLivestream: makeSelectClaimIsStreamPlaceholder(props.uri)(state),
|
|
isLivestreamActive: makeSelectIsActiveLivestream(props.uri)(state),
|
|
isCollectionMine: makeSelectCollectionIsMine(props.collectionId)(state),
|
|
collectionUris: makeSelectUrlsForCollectionId(props.collectionId)(state),
|
|
collectionIndex: makeSelectIndexForUrlInCollection(props.uri, props.collectionId)(state),
|
|
};
|
|
};
|
|
|
|
const perform = (dispatch) => ({
|
|
resolveUri: (uri) => dispatch(doResolveUri(uri)),
|
|
getFile: (uri) => dispatch(doFileGet(uri, false)),
|
|
editCollection: (id, params) => dispatch(doCollectionEdit(id, params)),
|
|
});
|
|
|
|
export default connect(select, perform)(ClaimPreview);
|