lbry-desktop/ui/component
infinite-persistence 4d01452447 Fix reaction-selector reference invalidation
When comments are refreshed, each `Comment` gets rendered 4-5 times due to reference invalidation for `othersReacts` (the data didn't actually change).

For selectors without transformation, there is no need to memoize using `createSelector` -- just access it directly. Also, don't do things like `return a[id] || {}` in a reducer, because the reference to the empty object will be different on each call.

Always return directly from the state so that the same reference is returned.

This simple change avoided the wasted resources needed for `createSelector`, and reduced to render to just 2 (initial render, and when reactions are fetched).
2021-12-03 15:22:32 -05:00
..
abandonedChannelPreview integrate all the things 2021-10-15 23:49:41 -04:00
app remove lbryinc web, update sitename, etc 2021-10-21 21:20:59 -04:00
autoplayCountdown integrate all the things 2021-10-15 23:49:41 -04:00
blockList Blocklist: don't show pagination widget when searching. 2021-09-11 21:16:42 +08:00
button support embed preference (#7114) 2021-09-18 10:23:30 -04:00
cardVerify updated code 2021-07-03 14:42:37 -04:00
channelAbout cut SIMPLE_SITE 2021-10-20 17:05:37 -04:00
channelBlockButton integrate all the things 2021-10-15 23:49:41 -04:00
channelContent strip out livestreams 2021-10-20 17:05:37 -04:00
channelDiscussion integrate all the things 2021-10-15 23:49:41 -04:00
channelEdit improve channel cover upload ux 2021-10-28 15:17:18 -04:00
channelMentionSuggestion integrate all the things 2021-10-15 23:49:41 -04:00
channelMentionSuggestions strip out livestreams 2021-10-20 17:05:37 -04:00
channelMentionTopSuggestion integrate all the things 2021-10-15 23:49:41 -04:00
channelMuteButton Rename default import/exports for clarity in text search (no functional change) 2021-07-09 08:40:26 +08:00
channelSelector integrate all the things 2021-10-15 23:49:41 -04:00
channelStakedIndicator integrate all the things 2021-10-15 23:49:41 -04:00
channelThumbnail more flow 2021-10-15 23:49:41 -04:00
channelTitle integrate all the things 2021-10-15 23:49:41 -04:00
claimAbandonButton integrate all the things 2021-10-15 23:49:41 -04:00
claimAuthor integrate all the things 2021-10-15 23:49:41 -04:00
claimCollectionAdd integrate all the things 2021-10-15 23:49:41 -04:00
claimCollectionAddButton integrate all the things 2021-10-15 23:49:41 -04:00
claimEffectiveAmount integrate all the things 2021-10-15 23:49:41 -04:00
claimInsufficientCredits integrate all the things 2021-10-15 23:49:41 -04:00
claimLink cut SIMPLE_SITE 2021-10-20 17:05:37 -04:00
claimList collection reordering changes 2021-12-02 15:08:24 -05:00
claimListDiscover cut SIMPLE_SITE 2021-10-20 17:05:37 -04:00
claimListHeader cleaner discover filters display 2021-12-02 20:43:32 -05:00
claimMenuList more flow 2021-10-15 23:49:41 -04:00
claimPreview re-reselect proof of concept + fix Date selector as first example 2021-12-03 15:22:32 -05:00
claimPreviewSubtitle strip out livestreams 2021-10-20 17:05:37 -04:00
claimPreviewTile re-reselect proof of concept + fix Date selector as first example 2021-12-03 15:22:32 -05:00
claimPreviewTitle integrate all the things 2021-10-15 23:49:41 -04:00
claimProperties integrate all the things 2021-10-15 23:49:41 -04:00
claimRepostAuthor integrate all the things 2021-10-15 23:49:41 -04:00
claimSupportButton integrate all the things 2021-10-15 23:49:41 -04:00
claimTags Optimize tags and followedTags 2021-12-03 15:22:32 -05:00
claimTilesDiscover cut SIMPLE_SITE 2021-10-20 17:05:37 -04:00
claimType strip out livestreams 2021-10-20 17:05:37 -04:00
claimUri integrate all the things 2021-10-15 23:49:41 -04:00
collectionActions list editing behind toggle button 2021-12-02 20:43:19 -05:00
collectionContentSidebar integrate all the things 2021-10-15 23:49:41 -04:00
collectionEdit list publish page listview type 2021-12-02 15:08:24 -05:00
collectionMenuList integrate all the things 2021-10-15 23:49:41 -04:00
collectionPreviewOverlay Fix missing state 2021-11-16 16:23:17 -05:00
collectionPreviewTile Fix missing state 2021-11-16 16:23:17 -05:00
collectionSelectItem integrate all the things 2021-10-15 23:49:41 -04:00
collectionsListMine carry collection active tab to playlists page 2021-11-07 14:59:35 -05:00
comment Fix reaction-selector reference invalidation 2021-12-03 15:22:32 -05:00
commentCreate strip out livestreams 2021-10-20 17:05:37 -04:00
commentMenuList lint 2021-10-15 23:49:41 -04:00
commentReactions Fix reaction-selector reference invalidation 2021-12-03 15:22:32 -05:00
commentsList Fix reaction-selector reference invalidation 2021-12-03 15:22:32 -05:00
commentsReplies integrate all the things 2021-10-15 23:49:41 -04:00
common collection reordering changes 2021-12-02 15:08:24 -05:00
copyableText Restore "Stream Key Button (#7127)" + lint and modifications 2021-09-23 20:13:02 +08:00
creatorAnalytics integrate all the things 2021-10-15 23:49:41 -04:00
dateTime re-reselect proof of concept + fix Date selector as first example 2021-12-03 15:22:32 -05:00
emailCollection integrate all the things 2021-10-15 23:49:41 -04:00
embedPlayButton integrate all the things 2021-10-15 23:49:41 -04:00
embedTextArea add referral code to embed links 2020-10-07 16:23:53 -04:00
errorBoundary cut SIMPLE_SITE 2021-10-20 17:05:37 -04:00
expandable
fileActions strip out livestreams 2021-10-20 17:05:37 -04:00
fileDescription collection reordering changes 2021-12-02 15:08:24 -05:00
fileDetails cut SIMPLE_SITE 2021-10-20 17:05:37 -04:00
fileDownloadLink cut SIMPLE_SITE 2021-10-20 17:05:37 -04:00
fileDrop integrate all the things 2021-10-15 23:49:41 -04:00
filePrice integrate all the things 2021-10-15 23:49:41 -04:00
fileReactions strip out livestreams 2021-10-20 17:05:37 -04:00
fileRender remove web and embed 2021-10-22 11:20:22 -04:00
fileRenderDownload fixes restoring wallet page and removing lbry.tv references 2021-11-28 15:06:11 -05:00
fileRenderFloating Floating player position-listener fixes (#289) 2021-11-28 12:12:12 -05:00
fileRenderInitiator integrate all the things 2021-10-15 23:49:41 -04:00
fileRenderInline integrate all the things 2021-10-15 23:49:41 -04:00
fileSubtitle restore file release time 2021-10-29 12:24:33 -04:00
fileThumbnail integrate all the things 2021-10-15 23:49:41 -04:00
fileTitle integrate all the things 2021-10-15 23:49:41 -04:00
fileTitleSection strip out livestreams 2021-10-20 17:05:37 -04:00
fileType strip out livestreams 2021-10-20 17:05:37 -04:00
fileValues integrate all the things 2021-10-15 23:49:41 -04:00
fileViewCount strip out livestreams 2021-10-20 17:05:37 -04:00
fileViewCountInline strip out livestreams 2021-10-20 17:05:37 -04:00
fileViewerEmbeddedTitle integrate all the things 2021-10-15 23:49:41 -04:00
fileWatchLaterLink integrate all the things 2021-10-15 23:49:41 -04:00
formFieldPrice
header cloud connect 2021-10-22 16:39:45 -04:00
hiddenNsfwClaims integrate all the things 2021-10-15 23:49:41 -04:00
homepageSelector Move combobox to right | Move "Search only in language" into separate row 2021-08-23 23:45:09 +08:00
i18nMessage Fix <i18nMessage> not localizing the message. 2020-05-25 10:18:08 -04:00
IframeReact re-enable pdfs on web 2021-04-05 15:06:56 -04:00
invited more flow 2021-10-15 23:49:41 -04:00
inviteList update app-strings 2020-10-08 13:15:22 -04:00
inviteNew integrate all the things 2021-10-15 23:49:41 -04:00
lastReleaseChanges prevent release notes from extending beyond height of app 2021-03-18 18:17:10 -04:00
loadingBarOneOff Use env for loading-bar color instead of hardcoded. 2021-06-29 21:01:14 +08:00
loginGraphic FileThumbnail: don't go through optimizer if GIF 2021-06-23 14:15:37 -04:00
logo cut SIMPLE_SITE 2021-10-20 17:05:37 -04:00
markdownLink integrate all the things 2021-10-15 23:49:41 -04:00
maxPurchasePrice [Content] refactor and grab Max Purchase Price 2021-08-23 23:45:10 +08:00
nagContinueFirstRun integrate all the things 2021-10-15 23:49:41 -04:00
navigationButton Allow double-clicking in header to maximize the app. 2020-05-17 21:26:30 -07:00
navigationHistory
navigationHistoryItem integrate all the things 2021-10-15 23:49:41 -04:00
navigationHistoryRecent
notification strip out livestreams 2021-10-20 17:05:37 -04:00
notificationBubble recon notify components 2021-07-19 22:16:29 -04:00
notificationContentChannelMenu lint 2021-10-15 23:49:41 -04:00
notificationHeaderButton recon notify components 2021-07-19 22:16:29 -04:00
nudgeFloating move nudge to FileReactions and add src param to sign up redirects 2020-11-17 14:32:53 -05:00
optimizedImage Fix channel-selector thumbnail not updating 2021-07-21 16:38:54 +08:00
page strip out livestreams 2021-10-20 17:05:37 -04:00
playlistsMine carry collection active tab to playlists page 2021-11-07 14:59:35 -05:00
postEditor integrate all the things 2021-10-15 23:49:41 -04:00
postViewer integrate all the things 2021-10-15 23:49:41 -04:00
previewLink integrate all the things 2021-10-15 23:49:41 -04:00
previewOverlayProperties integrate all the things 2021-10-15 23:49:41 -04:00
privacyAgreement fixes restoring wallet page and removing lbry.tv references 2021-11-28 15:06:11 -05:00
publishAdditionalOptions integrate all the things 2021-10-15 23:49:41 -04:00
publishBid integrate all the things 2021-10-15 23:49:41 -04:00
publishDescription cut SIMPLE_SITE 2021-10-20 17:05:37 -04:00
publishFile strip out livestreams 2021-10-20 17:05:37 -04:00
publishForm strip out livestreams 2021-10-20 17:05:37 -04:00
publishFormErrors lint 2021-10-15 23:49:41 -04:00
publishName integrate all the things 2021-10-15 23:49:41 -04:00
publishPending integrate all the things 2021-10-15 23:49:41 -04:00
publishPrice integrate all the things 2021-10-15 23:49:41 -04:00
publishReleaseDate integrate all the things 2021-10-15 23:49:41 -04:00
recommendedContent remove more web folder stuff 2021-10-20 17:05:37 -04:00
reportContent integrate all the things 2021-10-15 23:49:41 -04:00
repostCreate lint 2021-10-15 23:49:41 -04:00
rewardAuthIntro add youtube sync to first run 2020-09-29 17:12:32 -04:00
rewardLink fix accessibility issue on rewards page #5991 2021-07-20 12:14:28 -05:00
rewardListClaimed table alignment fixes 2020-09-29 17:12:32 -04:00
rewardSummary Use sentence case for all card titles 2020-09-29 17:12:32 -04:00
rewardTile fix accessibility issue on rewards page #5991 2021-07-20 12:14:28 -05:00
rewardTotal new lbc icon 2020-09-29 17:12:32 -04:00
router fixes restoring wallet page and removing lbry.tv references 2021-11-28 15:06:11 -05:00
searchChannelField integrate all the things 2021-10-15 23:49:41 -04:00
searchOptions Remove unused items 2021-07-14 11:13:13 +08:00
searchTopClaim more flow 2021-10-15 23:49:41 -04:00
selectAsset improve channel cover upload ux 2021-10-28 15:17:18 -04:00
selectChannel integrate all the things 2021-10-15 23:49:41 -04:00
selectThumbnail integrate all the things 2021-10-15 23:49:41 -04:00
settingAccount tip modal no fiat 2021-10-20 17:05:37 -04:00
settingAccountPassword Move 'update password' into a subpage 2021-08-23 23:45:31 +08:00
settingAppearance integrate all the things 2021-10-15 23:49:41 -04:00
settingAutoLaunch integrate all the things 2021-10-15 23:49:41 -04:00
settingClosingBehavior integrate all the things 2021-10-15 23:49:41 -04:00
settingCommentsServer integrate all the things 2021-10-15 23:49:41 -04:00
settingContent cut SIMPLE_SITE 2021-10-20 17:05:37 -04:00
settingLanguage Fix jumpy ui when changing language 2021-09-13 15:44:29 +08:00
settingShareUrl custom share url 2021-10-21 22:58:33 -04:00
settingsRow Styles for new Settings Page 2021-08-23 23:45:04 +08:00
settingsSideNavigation Settings: use 'smooth' instead of 'instant' scroll. 2021-09-13 09:59:11 +08:00
settingSystem fixes restoring wallet page and removing lbry.tv references 2021-11-28 15:06:11 -05:00
settingUnauthenticated integrate all the things 2021-10-15 23:49:41 -04:00
settingWalletServer fixes restoring wallet page and removing lbry.tv references 2021-11-28 15:06:11 -05:00
shareButton bring in 'notifications' state from lbry-redux 2020-06-16 09:56:32 -04:00
sideNavigation remove lbryinc web, update sitename, etc 2021-10-21 21:20:59 -04:00
skipNavigationButton add SkipNavigationButton to its own file 2021-07-20 19:31:26 -05:00
snackBar adjust css for toast message so that it behaves as expected (text truncation via ellipsis) (#7213) 2021-10-04 09:21:59 -04:00
socialShare custom share url 2021-10-21 22:58:33 -04:00
spinner refactor floatingUri to allow inline players in comments/markdown 2020-10-21 15:29:29 -04:00
splash integrate all the things 2021-10-15 23:49:41 -04:00
subscribeButton more flow 2021-10-15 23:49:41 -04:00
supportsLiquidate integrate all the things 2021-10-15 23:49:41 -04:00
syncEnableFlow integrate all the things 2021-10-15 23:49:41 -04:00
syncFatalError remove more web folder stuff 2021-10-20 17:05:37 -04:00
syncPassword More master reconciliation 2021-04-27 23:05:38 -04:00
syncToggle integrate all the things 2021-10-15 23:49:41 -04:00
tag integrate all the things 2021-10-15 23:49:41 -04:00
tagsSearch Moderator Delegation GUI 2021-06-18 15:46:51 -04:00
tagsSelect sync reducer stuff 2020-10-27 10:17:11 -04:00
theme flow fixes 2020-12-16 10:52:22 -05:00
themeSelector integrate all the things 2021-10-15 23:49:41 -04:00
transactionListTable integrate all the things 2021-10-15 23:49:41 -04:00
transactionListTableItem integrate all the things 2021-10-15 23:49:41 -04:00
txoList export all 2021-10-20 17:05:37 -04:00
uriIndicator integrate all the things 2021-10-15 23:49:41 -04:00
userChannelFollowIntro cut SIMPLE_SITE 2021-10-20 17:05:37 -04:00
userEmail fixes restoring wallet page and removing lbry.tv references 2021-11-28 15:06:11 -05:00
userEmailNew fixes restoring wallet page and removing lbry.tv references 2021-11-28 15:06:11 -05:00
userEmailReturning cloud connect 2021-10-22 16:39:45 -04:00
userEmailVerify More master reconciliation 2021-04-27 23:05:38 -04:00
userFirstChannel lint 2021-10-15 23:49:41 -04:00
userPasswordReset Use sentence case for all card titles 2020-09-29 17:12:32 -04:00
userPasswordSet Use sentence case for all card titles 2020-09-29 17:12:32 -04:00
userPhoneNew Use sentence case for all card titles 2020-09-29 17:12:32 -04:00
userPhoneVerify More master reconciliation 2021-04-27 23:05:38 -04:00
userSignIn sync changes 2020-09-10 14:20:02 -04:00
userSignInPassword Add SITE_HELP_EMAIL in strings to ease Odysee string merge and maintenance. 2021-03-08 11:33:33 -05:00
userSignOutButton add user + rewards redux code from lbryinc 2020-06-16 09:56:32 -04:00
userSignUp integrate all the things 2021-10-15 23:49:41 -04:00
userTagFollowIntro sync reducer stuff 2020-10-27 10:17:11 -04:00
userVerify sms copy 2021-07-21 08:11:33 -04:00
videoDuration integrate all the things 2021-10-15 23:49:41 -04:00
viewers Debounce volume and muted state update. 2021-11-29 16:19:38 -05:00
walletAddress integrate all the things 2021-10-15 23:49:41 -04:00
walletBackup rc fixes for electron 9 2020-10-15 19:06:47 -04:00
walletBalance fixes restoring wallet page and removing lbry.tv references 2021-11-28 15:06:11 -05:00
walletSend integrate all the things 2021-10-15 23:49:41 -04:00
walletSendTip tip modal no fiat 2021-10-20 17:05:37 -04:00
walletSpendableBalanceHelp integrate all the things 2021-10-15 23:49:41 -04:00
walletSwap integrate all the things 2021-10-15 23:49:41 -04:00
walletTipAmountSelector integrate all the things 2021-10-15 23:49:41 -04:00
wunderbar remove lazy import 2021-10-20 17:05:37 -04:00
wunderbarSuggestion integrate all the things 2021-10-15 23:49:41 -04:00
wunderbarSuggestions integrate all the things 2021-10-15 23:49:41 -04:00
wunderbarTopSuggestion integrate all the things 2021-10-15 23:49:41 -04:00
youtubeBadge move youtube badge to 'channel about' section 2020-10-06 16:30:03 -04:00
youtubeTransferStatus integrate all the things 2021-10-15 23:49:41 -04:00
yrbl winning claim style pass 2020-12-16 14:58:30 -05:00
yrblWalletEmpty integrate all the things 2021-10-15 23:49:41 -04:00
zoomableImage Zoomable image viewer in Markdown (posts and comments) 2021-01-27 10:06:31 -05:00