a3398843c2
Frequently used; top in perf profile Most of the time, you already have the claim object in the current context. `selectClaimIsMineForUri` will retrieve the claim again, which is wasteful, even if it is memoized (looking up the cache still takes time). Break apart the logic and added the alternative `selectClaimIsMine` for faster lookup. Co-authored-by: infinite-persistence <inf.persistence@gmail.com>
36 lines
1.3 KiB
JavaScript
36 lines
1.3 KiB
JavaScript
import { connect } from 'react-redux';
|
|
import CollectionContent from './view';
|
|
import { selectClaimForUri, selectClaimIsMine } from 'redux/selectors/claims';
|
|
import {
|
|
makeSelectUrlsForCollectionId,
|
|
makeSelectNameForCollectionId,
|
|
makeSelectCollectionForId,
|
|
} from 'redux/selectors/collections';
|
|
import { selectPlayingUri, selectListLoop, selectListShuffle } from 'redux/selectors/content';
|
|
import { doToggleLoopList, doToggleShuffleList } from 'redux/actions/content';
|
|
|
|
const select = (state, props) => {
|
|
const playingUri = selectPlayingUri(state);
|
|
const playingUrl = playingUri && playingUri.uri;
|
|
const claim = selectClaimForUri(state, playingUrl);
|
|
const url = claim && claim.permanent_url;
|
|
const loopList = selectListLoop(state);
|
|
const loop = loopList && loopList.collectionId === props.id && loopList.loop;
|
|
const shuffleList = selectListShuffle(state);
|
|
const shuffle = shuffleList && shuffleList.collectionId === props.id && shuffleList.newUrls;
|
|
|
|
return {
|
|
url,
|
|
collection: makeSelectCollectionForId(props.id)(state),
|
|
collectionUrls: makeSelectUrlsForCollectionId(props.id)(state),
|
|
collectionName: makeSelectNameForCollectionId(props.id)(state),
|
|
isMine: selectClaimIsMine(state, claim),
|
|
loop,
|
|
shuffle,
|
|
};
|
|
};
|
|
|
|
export default connect(select, {
|
|
doToggleLoopList,
|
|
doToggleShuffleList,
|
|
})(CollectionContent);
|