dbb9ee7ac6
* DRY up membership selector Selectors should be chained up, not copy/pasted. * PremiumBadge: retrieve membership db internally instead of from parent ## Ticket 1753 odyseeMembershipByUri function causing unnecessary renders ## Issue While the rendering issue in the ticket is due to the way the props are defined, it also surfaced a prop-drilling issue with PremiumBadge. Instead of asking the parent for the membership db, it can retrieve from Redux itself. This prevents the prop from polluting 2 levels of components and causing unnecessary renders. ## Approach - Make `PremiumBadge` accept `uri` like most other components. - I still leave the `membership` prop as (i.e. parent can still pass it directly). In some cases (e.g. `livestreamComment`, `page/odyseeMembership`), the parent itself needs the same data, so we don't need to derive it twice.
30 lines
1.1 KiB
JavaScript
30 lines
1.1 KiB
JavaScript
import { connect } from 'react-redux';
|
|
import { selectMyChannelClaims, selectClaimsByUri } from 'redux/selectors/claims';
|
|
import { selectActiveChannelClaim, selectIncognito } from 'redux/selectors/app';
|
|
import { doSetActiveChannel, doSetIncognito } from 'redux/actions/app';
|
|
import { doFetchUserMemberships } from 'redux/actions/user';
|
|
import { doSetDefaultChannel } from 'redux/actions/settings';
|
|
import { selectDefaultChannelClaim } from 'redux/selectors/settings';
|
|
import ChannelSelector from './view';
|
|
|
|
const select = (state, props) => {
|
|
const { storeSelection } = props;
|
|
const activeChannelClaim = selectActiveChannelClaim(state);
|
|
const defaultChannelClaim = selectDefaultChannelClaim(state);
|
|
|
|
return {
|
|
channels: selectMyChannelClaims(state),
|
|
activeChannelClaim: storeSelection ? defaultChannelClaim : activeChannelClaim,
|
|
incognito: selectIncognito(state),
|
|
claimsByUri: selectClaimsByUri(state),
|
|
};
|
|
};
|
|
|
|
const perform = {
|
|
doSetActiveChannel,
|
|
doSetIncognito,
|
|
doFetchUserMemberships,
|
|
doSetDefaultChannel,
|
|
};
|
|
|
|
export default connect(select, perform)(ChannelSelector);
|