dbb9ee7ac6
* DRY up membership selector Selectors should be chained up, not copy/pasted. * PremiumBadge: retrieve membership db internally instead of from parent ## Ticket 1753 odyseeMembershipByUri function causing unnecessary renders ## Issue While the rendering issue in the ticket is due to the way the props are defined, it also surfaced a prop-drilling issue with PremiumBadge. Instead of asking the parent for the membership db, it can retrieve from Redux itself. This prevents the prop from polluting 2 levels of components and causing unnecessary renders. ## Approach - Make `PremiumBadge` accept `uri` like most other components. - I still leave the `membership` prop as (i.e. parent can still pass it directly). In some cases (e.g. `livestreamComment`, `page/odyseeMembership`), the parent itself needs the same data, so we don't need to derive it twice.
32 lines
1.3 KiB
JavaScript
32 lines
1.3 KiB
JavaScript
import { connect } from 'react-redux';
|
|
import { doFetchLastActiveSubs } from 'redux/actions/subscriptions';
|
|
import { selectLastActiveSubscriptions, selectSubscriptions } from 'redux/selectors/subscriptions';
|
|
import { doClearClaimSearch } from 'redux/actions/claims';
|
|
import { doClearPurchasedUriSuccess } from 'redux/actions/file';
|
|
import { selectFollowedTags } from 'redux/selectors/tags';
|
|
import { selectUserVerifiedEmail, selectUser, selectOdyseeMembershipName } from 'redux/selectors/user';
|
|
import { selectHomepageData } from 'redux/selectors/settings';
|
|
import { doSignOut } from 'redux/actions/app';
|
|
import { selectUnseenNotificationCount } from 'redux/selectors/notifications';
|
|
import { selectPurchaseUriSuccess } from 'redux/selectors/claims';
|
|
|
|
import SideNavigation from './view';
|
|
|
|
const select = (state) => ({
|
|
subscriptions: selectSubscriptions(state),
|
|
lastActiveSubs: selectLastActiveSubscriptions(state),
|
|
followedTags: selectFollowedTags(state),
|
|
email: selectUserVerifiedEmail(state),
|
|
purchaseSuccess: selectPurchaseUriSuccess(state),
|
|
unseenCount: selectUnseenNotificationCount(state),
|
|
user: selectUser(state),
|
|
homepageData: selectHomepageData(state),
|
|
odyseeMembership: selectOdyseeMembershipName(state),
|
|
});
|
|
|
|
export default connect(select, {
|
|
doClearClaimSearch,
|
|
doSignOut,
|
|
doClearPurchasedUriSuccess,
|
|
doFetchLastActiveSubs,
|
|
})(SideNavigation);
|