ece2312ec5
## Issue `normalizeUri` | `parseURI` is expensive and has been causing sluggish operations when called repeatedly or within a loop. ## Change Since I'm not confident enough to remove the call entirely from makeSelectClaimIsMine (although I've yet to find a scenario that the uri is not already normalized), we'll try caching the calls instead. ## Results - in a simple test of toggling between 2 category pages, we saved 20ms from `parseURI` calls alone. - in a test of opening all categories one time, the memory usage remained similar. This makes sense since we removed a `makeSelect*` (which creates a selector for each call + not memoizing), and replaced that with a cached selector that's actually memoizing.
29 lines
1 KiB
JavaScript
29 lines
1 KiB
JavaScript
import { connect } from 'react-redux';
|
|
import {
|
|
selectClaimIsMineForUri,
|
|
makeSelectIsAbandoningClaimForUri,
|
|
makeSelectClaimForClaimId,
|
|
} from 'redux/selectors/claims';
|
|
import { doCollectionDelete } from 'redux/actions/collections';
|
|
import { makeSelectNameForCollectionId } from 'redux/selectors/collections';
|
|
import { doHideModal } from 'redux/actions/app';
|
|
import ModalRemoveCollection from './view';
|
|
|
|
const select = (state, props) => {
|
|
const claim = makeSelectClaimForClaimId(props.collectionId)(state);
|
|
const uri = (claim && (claim.canonical_url || claim.permanent_url)) || null;
|
|
return {
|
|
claim,
|
|
uri,
|
|
claimIsMine: selectClaimIsMineForUri(state, uri),
|
|
isAbandoning: makeSelectIsAbandoningClaimForUri(uri)(state),
|
|
collectionName: makeSelectNameForCollectionId(props.collectionId)(state),
|
|
};
|
|
};
|
|
|
|
const perform = (dispatch) => ({
|
|
closeModal: () => dispatch(doHideModal()),
|
|
collectionDelete: (id) => dispatch(doCollectionDelete(id)),
|
|
});
|
|
|
|
export default connect(select, perform)(ModalRemoveCollection);
|