ece2312ec5
## Issue `normalizeUri` | `parseURI` is expensive and has been causing sluggish operations when called repeatedly or within a loop. ## Change Since I'm not confident enough to remove the call entirely from makeSelectClaimIsMine (although I've yet to find a scenario that the uri is not already normalized), we'll try caching the calls instead. ## Results - in a simple test of toggling between 2 category pages, we saved 20ms from `parseURI` calls alone. - in a test of opening all categories one time, the memory usage remained similar. This makes sense since we removed a `makeSelect*` (which creates a selector for each call + not memoizing), and replaced that with a cached selector that's actually memoizing.
20 lines
663 B
JavaScript
20 lines
663 B
JavaScript
import { connect } from 'react-redux';
|
|
import { selectActiveChannelClaim } from 'redux/selectors/app';
|
|
import { selectClaimIsMineForUri } from 'redux/selectors/claims';
|
|
import { doToast } from 'redux/actions/notifications';
|
|
import ClaimPreviewReset from './view';
|
|
|
|
const select = (state, props) => {
|
|
const { claim_id: channelId, name: channelName } = selectActiveChannelClaim(state) || {};
|
|
return {
|
|
channelName,
|
|
channelId,
|
|
claimIsMine: props.uri && selectClaimIsMineForUri(state, props.uri),
|
|
};
|
|
};
|
|
|
|
const perform = (dispatch) => ({
|
|
doToast: (props) => dispatch(doToast(props)),
|
|
});
|
|
|
|
export default connect(select, perform)(ClaimPreviewReset);
|