ece2312ec5
## Issue `normalizeUri` | `parseURI` is expensive and has been causing sluggish operations when called repeatedly or within a loop. ## Change Since I'm not confident enough to remove the call entirely from makeSelectClaimIsMine (although I've yet to find a scenario that the uri is not already normalized), we'll try caching the calls instead. ## Results - in a simple test of toggling between 2 category pages, we saved 20ms from `parseURI` calls alone. - in a test of opening all categories one time, the memory usage remained similar. This makes sense since we removed a `makeSelect*` (which creates a selector for each call + not memoizing), and replaced that with a cached selector that's actually memoizing.
42 lines
1.8 KiB
JavaScript
42 lines
1.8 KiB
JavaScript
import { connect } from 'react-redux';
|
|
import {
|
|
selectClaimIsMineForUri,
|
|
makeSelectTitleForUri,
|
|
makeSelectThumbnailForUri,
|
|
makeSelectCoverForUri,
|
|
selectCurrentChannelPage,
|
|
makeSelectClaimForUri,
|
|
makeSelectClaimIsPending,
|
|
} from 'redux/selectors/claims';
|
|
import { selectMyUnpublishedCollections } from 'redux/selectors/collections';
|
|
import { selectBlackListedOutpoints, doFetchSubCount, makeSelectSubCountForUri } from 'lbryinc';
|
|
import { selectYoutubeChannels } from 'redux/selectors/user';
|
|
import { makeSelectIsSubscribed } from 'redux/selectors/subscriptions';
|
|
import { selectModerationBlockList } from 'redux/selectors/comments';
|
|
import { selectMutedChannels } from 'redux/selectors/blocked';
|
|
import { doOpenModal } from 'redux/actions/app';
|
|
import ChannelPage from './view';
|
|
|
|
const select = (state, props) => ({
|
|
title: makeSelectTitleForUri(props.uri)(state),
|
|
thumbnail: makeSelectThumbnailForUri(props.uri)(state),
|
|
cover: makeSelectCoverForUri(props.uri)(state),
|
|
channelIsMine: selectClaimIsMineForUri(state, props.uri),
|
|
page: selectCurrentChannelPage(state),
|
|
claim: makeSelectClaimForUri(props.uri)(state),
|
|
isSubscribed: makeSelectIsSubscribed(props.uri, true)(state),
|
|
blackListedOutpoints: selectBlackListedOutpoints(state),
|
|
subCount: makeSelectSubCountForUri(props.uri)(state),
|
|
pending: makeSelectClaimIsPending(props.uri)(state),
|
|
youtubeChannels: selectYoutubeChannels(state),
|
|
blockedChannels: selectModerationBlockList(state),
|
|
mutedChannels: selectMutedChannels(state),
|
|
unpublishedCollections: selectMyUnpublishedCollections(state),
|
|
});
|
|
|
|
const perform = (dispatch) => ({
|
|
openModal: (modal, props) => dispatch(doOpenModal(modal, props)),
|
|
fetchSubCount: (claimId) => dispatch(doFetchSubCount(claimId)),
|
|
});
|
|
|
|
export default connect(select, perform)(ChannelPage);
|