ece2312ec5
## Issue `normalizeUri` | `parseURI` is expensive and has been causing sluggish operations when called repeatedly or within a loop. ## Change Since I'm not confident enough to remove the call entirely from makeSelectClaimIsMine (although I've yet to find a scenario that the uri is not already normalized), we'll try caching the calls instead. ## Results - in a simple test of toggling between 2 category pages, we saved 20ms from `parseURI` calls alone. - in a test of opening all categories one time, the memory usage remained similar. This makes sense since we removed a `makeSelect*` (which creates a selector for each call + not memoizing), and replaced that with a cached selector that's actually memoizing.
27 lines
1.2 KiB
JavaScript
27 lines
1.2 KiB
JavaScript
import { connect } from 'react-redux';
|
|
import { doResolveUris } from 'redux/actions/claims';
|
|
import { selectClaimIsMineForUri, selectMyChannelClaimIds, makeSelectClaimForUri } from 'redux/selectors/claims';
|
|
import { selectIsFetchingCommentsByParentId, selectRepliesForParentId } from 'redux/selectors/comments';
|
|
import { selectUserVerifiedEmail } from 'redux/selectors/user';
|
|
import CommentsReplies from './view';
|
|
|
|
const select = (state, props) => {
|
|
const fetchedReplies = selectRepliesForParentId(state, props.parentId);
|
|
const resolvedReplies =
|
|
fetchedReplies && fetchedReplies.length > 0
|
|
? fetchedReplies.filter(({ channel_url }) => makeSelectClaimForUri(channel_url)(state) !== undefined)
|
|
: [];
|
|
|
|
return {
|
|
fetchedReplies,
|
|
resolvedReplies,
|
|
claimIsMine: selectClaimIsMineForUri(state, props.uri),
|
|
userCanComment: IS_WEB ? Boolean(selectUserVerifiedEmail(state)) : true,
|
|
myChannelIds: selectMyChannelClaimIds(state),
|
|
isFetchingByParentId: selectIsFetchingCommentsByParentId(state),
|
|
};
|
|
};
|
|
|
|
const perform = (dispatch) => ({ doResolveUris: (uris) => dispatch(doResolveUris(uris, true)) });
|
|
|
|
export default connect(select, perform)(CommentsReplies);
|