a3398843c2
Frequently used; top in perf profile Most of the time, you already have the claim object in the current context. `selectClaimIsMineForUri` will retrieve the claim again, which is wasteful, even if it is memoized (looking up the cache still takes time). Break apart the logic and added the alternative `selectClaimIsMine` for faster lookup. Co-authored-by: infinite-persistence <inf.persistence@gmail.com>
31 lines
1.3 KiB
JavaScript
31 lines
1.3 KiB
JavaScript
import { connect } from 'react-redux';
|
|
import Comment from './view';
|
|
import { selectClaimIsMine, selectClaimForUri } from 'redux/selectors/claims';
|
|
import { doResolveUri } from 'redux/actions/claims';
|
|
import { doToast } from 'redux/actions/notifications';
|
|
import { selectMyReactsForComment, selectOthersReactsForComment } from 'redux/selectors/comments';
|
|
import { doCommentReact } from 'redux/actions/comments';
|
|
import { selectActiveChannelClaim } from 'redux/selectors/app';
|
|
|
|
const select = (state, props) => {
|
|
const activeChannelClaim = selectActiveChannelClaim(state);
|
|
const activeChannelId = activeChannelClaim && activeChannelClaim.claim_id;
|
|
const reactionKey = activeChannelId ? `${props.commentId}:${activeChannelId}` : props.commentId;
|
|
const claim = selectClaimForUri(state, props.uri);
|
|
|
|
return {
|
|
claim,
|
|
claimIsMine: selectClaimIsMine(state, claim),
|
|
myReacts: selectMyReactsForComment(state, reactionKey),
|
|
othersReacts: selectOthersReactsForComment(state, reactionKey),
|
|
activeChannelId,
|
|
};
|
|
};
|
|
|
|
const perform = (dispatch) => ({
|
|
resolve: (uri) => dispatch(doResolveUri(uri)),
|
|
react: (commentId, type) => dispatch(doCommentReact(commentId, type)),
|
|
doToast: (params) => dispatch(doToast(params)),
|
|
});
|
|
|
|
export default connect(select, perform)(Comment);
|