ece2312ec5
## Issue `normalizeUri` | `parseURI` is expensive and has been causing sluggish operations when called repeatedly or within a loop. ## Change Since I'm not confident enough to remove the call entirely from makeSelectClaimIsMine (although I've yet to find a scenario that the uri is not already normalized), we'll try caching the calls instead. ## Results - in a simple test of toggling between 2 category pages, we saved 20ms from `parseURI` calls alone. - in a test of opening all categories one time, the memory usage remained similar. This makes sense since we removed a `makeSelect*` (which creates a selector for each call + not memoizing), and replaced that with a cached selector that's actually memoizing.
49 lines
2.1 KiB
JavaScript
49 lines
2.1 KiB
JavaScript
import { connect } from 'react-redux';
|
|
import {
|
|
selectClaimIsMineForUri,
|
|
makeSelectClaimForUri,
|
|
selectHasChannels,
|
|
makeSelectClaimIsStreamPlaceholder,
|
|
makeSelectTagInClaimOrChannelForUri,
|
|
} from 'redux/selectors/claims';
|
|
import { makeSelectStreamingUrlForUri, makeSelectFileInfoForUri } from 'redux/selectors/file_info';
|
|
import { doPrepareEdit } from 'redux/actions/publish';
|
|
import { DISABLE_COMMENTS_TAG } from 'constants/tags';
|
|
import { makeSelectCostInfoForUri } from 'lbryinc';
|
|
import { doSetPlayingUri, doPlayUri } from 'redux/actions/content';
|
|
import { doToast } from 'redux/actions/notifications';
|
|
import { doOpenModal, doSetActiveChannel, doSetIncognito, doAnalyticsView } from 'redux/actions/app';
|
|
import fs from 'fs';
|
|
import FileActions from './view';
|
|
import { makeSelectFileRenderModeForUri } from 'redux/selectors/content';
|
|
|
|
const select = (state, props) => ({
|
|
claim: makeSelectClaimForUri(props.uri)(state),
|
|
claimIsMine: selectClaimIsMineForUri(state, props.uri),
|
|
fileInfo: makeSelectFileInfoForUri(props.uri)(state),
|
|
renderMode: makeSelectFileRenderModeForUri(props.uri)(state),
|
|
costInfo: makeSelectCostInfoForUri(props.uri)(state),
|
|
hasChannels: selectHasChannels(state),
|
|
isLivestreamClaim: makeSelectClaimIsStreamPlaceholder(props.uri)(state),
|
|
reactionsDisabled: makeSelectTagInClaimOrChannelForUri(props.uri, DISABLE_COMMENTS_TAG)(state),
|
|
streamingUrl: makeSelectStreamingUrlForUri(props.uri)(state),
|
|
});
|
|
|
|
const perform = (dispatch) => ({
|
|
openModal: (modal, props) => dispatch(doOpenModal(modal, props)),
|
|
prepareEdit: (publishData, uri, fileInfo) => {
|
|
if (publishData.signing_channel) {
|
|
dispatch(doSetIncognito(false));
|
|
dispatch(doSetActiveChannel(publishData.signing_channel.claim_id));
|
|
} else {
|
|
dispatch(doSetIncognito(true));
|
|
}
|
|
|
|
dispatch(doPrepareEdit(publishData, uri, fileInfo, fs));
|
|
},
|
|
clearPlayingUri: () => dispatch(doSetPlayingUri({ uri: null })),
|
|
doToast: (options) => dispatch(doToast(options)),
|
|
download: (uri) => dispatch(doPlayUri(uri, false, true, () => dispatch(doAnalyticsView(uri)))),
|
|
});
|
|
|
|
export default connect(select, perform)(FileActions);
|