ece2312ec5
## Issue `normalizeUri` | `parseURI` is expensive and has been causing sluggish operations when called repeatedly or within a loop. ## Change Since I'm not confident enough to remove the call entirely from makeSelectClaimIsMine (although I've yet to find a scenario that the uri is not already normalized), we'll try caching the calls instead. ## Results - in a simple test of toggling between 2 category pages, we saved 20ms from `parseURI` calls alone. - in a test of opening all categories one time, the memory usage remained similar. This makes sense since we removed a `makeSelect*` (which creates a selector for each call + not memoizing), and replaced that with a cached selector that's actually memoizing.
18 lines
730 B
JavaScript
18 lines
730 B
JavaScript
import { connect } from 'react-redux';
|
|
import { makeSelectClaimForUri, makeSelectMetadataForUri, selectClaimIsMineForUri } from 'redux/selectors/claims';
|
|
import { makeSelectPendingAmountByUri } from 'redux/selectors/wallet';
|
|
import { doOpenModal } from 'redux/actions/app';
|
|
import { selectUser } from 'redux/selectors/user';
|
|
import FileDescription from './view';
|
|
|
|
const select = (state, props) => ({
|
|
claim: makeSelectClaimForUri(props.uri)(state),
|
|
claimIsMine: selectClaimIsMineForUri(state, props.uri),
|
|
metadata: makeSelectMetadataForUri(props.uri)(state),
|
|
user: selectUser(state),
|
|
pendingAmount: makeSelectPendingAmountByUri(props.uri)(state),
|
|
});
|
|
|
|
export default connect(select, {
|
|
doOpenModal,
|
|
})(FileDescription);
|