ece2312ec5
## Issue `normalizeUri` | `parseURI` is expensive and has been causing sluggish operations when called repeatedly or within a loop. ## Change Since I'm not confident enough to remove the call entirely from makeSelectClaimIsMine (although I've yet to find a scenario that the uri is not already normalized), we'll try caching the calls instead. ## Results - in a simple test of toggling between 2 category pages, we saved 20ms from `parseURI` calls alone. - in a test of opening all categories one time, the memory usage remained similar. This makes sense since we removed a `makeSelect*` (which creates a selector for each call + not memoizing), and replaced that with a cached selector that's actually memoizing.
31 lines
1 KiB
JavaScript
31 lines
1 KiB
JavaScript
import { connect } from 'react-redux';
|
|
import {
|
|
selectClaimIsMineForUri,
|
|
makeSelectTitleForUri,
|
|
makeSelectThumbnailForUri,
|
|
makeSelectClaimForUri,
|
|
makeSelectIsUriResolving,
|
|
makeSelectMetadataItemForUri,
|
|
} from 'redux/selectors/claims';
|
|
import { doResolveUri } from 'redux/actions/claims';
|
|
import { selectBlackListedOutpoints } from 'lbryinc';
|
|
import PreviewLink from './view';
|
|
|
|
const select = (state, props) => {
|
|
return {
|
|
uri: props.uri,
|
|
claim: makeSelectClaimForUri(props.uri)(state),
|
|
title: makeSelectTitleForUri(props.uri)(state),
|
|
thumbnail: makeSelectThumbnailForUri(props.uri)(state),
|
|
description: makeSelectMetadataItemForUri(props.uri, 'description')(state),
|
|
channelIsMine: selectClaimIsMineForUri(state, props.uri),
|
|
isResolvingUri: makeSelectIsUriResolving(props.uri)(state),
|
|
blackListedOutpoints: selectBlackListedOutpoints(state),
|
|
};
|
|
};
|
|
|
|
const perform = (dispatch) => ({
|
|
resolveUri: (uri) => dispatch(doResolveUri(uri)),
|
|
});
|
|
|
|
export default connect(select, perform)(PreviewLink);
|