c7021a08ad
* Attempt to speed up sidebar menu for mobile (#283) * Exclude default homepage data at compile time The youtuber IDs alone is pretty huge, and is unused in the `CUSTOM_HOMEPAGE=true` configuration. * Remove Desktop items and other cleanup - Moved constants out of the component. - Remove SIMPLE_SITE check. - Remove Desktop-only items * Sidebar: limit subscription and tag section Too slow for huge lists Limit to 10 initially, and load everything on "Show more" * Fix makeSelectThumbnailForUri - Fix memo - Expose function to extract directly from claim if client already have it. * Fix and optimize makeSelectIsSubscribed (#273) - It will not return true if the uri provided is canonical, because the compared subscription uri is in permanent form. This was causing certain elements like the Heart to not appear in claim tiles. - It is super slow for large subscriptions not just because of the array size + being a hot selector, but also because it is looking up the claim twice (not memo'd) and also calling `parseURI` to determine if it's a channel, which is unnecessary if you already have the claim. - Optimize the selector to only look up the claim once, and make operations using already-obtained info. * Simplify makeSelectTitleForUri No need to memo given no transformation. * Simplify makeSelectIsUriResolving - Memo not required. `resolvingUris` is very dynamic and is a short array anyways. - Changeg from using `indexOf` to `includes`, which is more concise. * Cost Info selector fixes - no memo required since they are just directly accessing the store. Co-authored-by: infinite-persistence <64950861+infinite-persistence@users.noreply.github.com> Co-authored-by: infinite-persistence <inf.persistence@gmail.com>
33 lines
1.5 KiB
JavaScript
33 lines
1.5 KiB
JavaScript
import { connect } from 'react-redux';
|
|
import { selectIsUriResolving, selectClaimIdForUri, makeSelectClaimForClaimId } from 'redux/selectors/claims';
|
|
import {
|
|
makeSelectUrlsForCollectionId,
|
|
makeSelectNameForCollectionId,
|
|
makeSelectPendingCollectionForId,
|
|
makeSelectCountForCollectionId,
|
|
} from 'redux/selectors/collections';
|
|
import { doFetchItemsInCollection } from 'redux/actions/collections';
|
|
import CollectionPreviewOverlay from './view';
|
|
|
|
const select = (state, props) => {
|
|
const collectionId = props.collectionId || (props.uri && selectClaimIdForUri(state, props.uri));
|
|
const claim = props.collectionId && makeSelectClaimForClaimId(props.collectionId)(state);
|
|
const collectionUri = props.uri || (claim && (claim.canonical_url || claim.permanent_url)) || null;
|
|
|
|
return {
|
|
collectionId,
|
|
uri: collectionUri,
|
|
collectionCount: makeSelectCountForCollectionId(collectionId)(state),
|
|
collectionName: makeSelectNameForCollectionId(collectionId)(state),
|
|
collectionItemUrls: makeSelectUrlsForCollectionId(collectionId)(state), // ForId || ForUri
|
|
pendingCollection: makeSelectPendingCollectionForId(collectionId)(state),
|
|
claim,
|
|
isResolvingUri: collectionUri && selectIsUriResolving(state, collectionUri),
|
|
};
|
|
};
|
|
|
|
const perform = (dispatch) => ({
|
|
fetchCollectionItems: (claimId) => dispatch(doFetchItemsInCollection({ collectionId: claimId })), // if collection not resolved, resolve it
|
|
});
|
|
|
|
export default connect(select, perform)(CollectionPreviewOverlay);
|