1e7e7a7b7a
* Fix avatar occasionally stuck in spaceman ## Issue Sometimes, we'll see a channel profile (e.g. in upper-right, in channel selector) stuck in the fallback Spaceman image. This is due to OptimizedImage always starting with a blank src, and updated later when the mounted size has been determined. ChannelThumbnail, which uses OptimizedImage, captured the `onError` due to blank src. ## Fix Don't mount the <img> until the optimum size has been determined. * FileThumbnail: skip resolve if thumbnail url is specified * UriIndicator: skip resolve if channel info is specified * Notifications: disable batch resolve + use fetched data if available + fallback to resolve if n/a The fallback is using the individual resolve when no direct data is provided and claim is undefined.
76 lines
2.2 KiB
JavaScript
76 lines
2.2 KiB
JavaScript
// @flow
|
|
import type { Node } from 'react';
|
|
import { getThumbnailCdnUrl } from 'util/thumbnail';
|
|
import React from 'react';
|
|
import FreezeframeWrapper from './FreezeframeWrapper';
|
|
import Placeholder from './placeholder.png';
|
|
import { MISSING_THUMB_DEFAULT } from 'config';
|
|
import classnames from 'classnames';
|
|
import Thumb from './thumb';
|
|
|
|
type Props = {
|
|
uri: string,
|
|
thumbnail: ?string, // externally sourced image
|
|
children?: Node,
|
|
allowGifs: boolean,
|
|
claim: ?StreamClaim,
|
|
doResolveUri: (string) => void,
|
|
className?: string,
|
|
};
|
|
|
|
function FileThumbnail(props: Props) {
|
|
const { claim, uri, doResolveUri, thumbnail: rawThumbnail, children, allowGifs = false, className } = props;
|
|
|
|
const passedThumbnail = rawThumbnail && rawThumbnail.trim().replace(/^http:\/\//i, 'https://');
|
|
const thumbnailFromClaim =
|
|
uri && claim && claim.value && claim.value.thumbnail ? claim.value.thumbnail.url : undefined;
|
|
const thumbnail = passedThumbnail || thumbnailFromClaim;
|
|
|
|
const hasResolvedClaim = claim !== undefined;
|
|
const isGif = thumbnail && thumbnail.endsWith('gif');
|
|
|
|
React.useEffect(() => {
|
|
if (!hasResolvedClaim && uri && !passedThumbnail) {
|
|
doResolveUri(uri);
|
|
}
|
|
}, [hasResolvedClaim, uri, doResolveUri, passedThumbnail]);
|
|
|
|
if (!allowGifs && isGif) {
|
|
return (
|
|
<FreezeframeWrapper src={thumbnail} className={classnames('media__thumb', className)}>
|
|
{children}
|
|
</FreezeframeWrapper>
|
|
);
|
|
}
|
|
|
|
const fallback = MISSING_THUMB_DEFAULT ? getThumbnailCdnUrl({ thumbnail: MISSING_THUMB_DEFAULT }) : undefined;
|
|
|
|
let url = thumbnail || (hasResolvedClaim ? Placeholder : '');
|
|
// @if TARGET='web'
|
|
// Pass image urls through a compression proxy
|
|
if (thumbnail && !(isGif && allowGifs)) {
|
|
url = getThumbnailCdnUrl({ thumbnail });
|
|
}
|
|
// @endif
|
|
|
|
const thumbnailUrl = url ? url.replace(/'/g, "\\'") : '';
|
|
|
|
if (hasResolvedClaim || thumbnailUrl) {
|
|
return (
|
|
<Thumb thumb={thumbnailUrl} fallback={fallback} className={className}>
|
|
{children}
|
|
</Thumb>
|
|
);
|
|
}
|
|
return (
|
|
<div
|
|
className={classnames('media__thumb', className, {
|
|
'media__thumb--resolving': !hasResolvedClaim,
|
|
})}
|
|
>
|
|
{children}
|
|
</div>
|
|
);
|
|
}
|
|
|
|
export default FileThumbnail;
|