dbb9ee7ac6
* DRY up membership selector Selectors should be chained up, not copy/pasted. * PremiumBadge: retrieve membership db internally instead of from parent ## Ticket 1753 odyseeMembershipByUri function causing unnecessary renders ## Issue While the rendering issue in the ticket is due to the way the props are defined, it also surfaced a prop-drilling issue with PremiumBadge. Instead of asking the parent for the membership db, it can retrieve from Redux itself. This prevents the prop from polluting 2 levels of components and causing unnecessary renders. ## Approach - Make `PremiumBadge` accept `uri` like most other components. - I still leave the `membership` prop as (i.e. parent can still pass it directly). In some cases (e.g. `livestreamComment`, `page/odyseeMembership`), the parent itself needs the same data, so we don't need to derive it twice.
24 lines
647 B
JavaScript
24 lines
647 B
JavaScript
import { connect } from 'react-redux';
|
|
import { normalizeURI } from 'util/lbryURI';
|
|
import { doResolveUri } from 'redux/actions/claims';
|
|
import { selectIsUriResolving, selectClaimForUri } from 'redux/selectors/claims';
|
|
import UriIndicator from './view';
|
|
|
|
const select = (state, props) => {
|
|
let uri = null;
|
|
try {
|
|
uri = normalizeURI(props.uri);
|
|
} catch {}
|
|
|
|
return {
|
|
claim: selectClaimForUri(state, props.uri),
|
|
isResolvingUri: selectIsUriResolving(state, props.uri),
|
|
uri,
|
|
};
|
|
};
|
|
|
|
const perform = (dispatch) => ({
|
|
resolveUri: (uri) => dispatch(doResolveUri(uri)),
|
|
});
|
|
|
|
export default connect(select, perform)(UriIndicator);
|