ece2312ec5
## Issue `normalizeUri` | `parseURI` is expensive and has been causing sluggish operations when called repeatedly or within a loop. ## Change Since I'm not confident enough to remove the call entirely from makeSelectClaimIsMine (although I've yet to find a scenario that the uri is not already normalized), we'll try caching the calls instead. ## Results - in a simple test of toggling between 2 category pages, we saved 20ms from `parseURI` calls alone. - in a test of opening all categories one time, the memory usage remained similar. This makes sense since we removed a `makeSelect*` (which creates a selector for each call + not memoizing), and replaced that with a cached selector that's actually memoizing.
36 lines
1.3 KiB
JavaScript
36 lines
1.3 KiB
JavaScript
import { connect } from 'react-redux';
|
|
import CollectionContent from './view';
|
|
import { makeSelectClaimForUri, selectClaimIsMineForUri } from 'redux/selectors/claims';
|
|
import {
|
|
makeSelectUrlsForCollectionId,
|
|
makeSelectNameForCollectionId,
|
|
makeSelectCollectionForId,
|
|
} from 'redux/selectors/collections';
|
|
import { selectPlayingUri, selectListLoop, selectListShuffle } from 'redux/selectors/content';
|
|
import { doToggleLoopList, doToggleShuffleList } from 'redux/actions/content';
|
|
|
|
const select = (state, props) => {
|
|
const playingUri = selectPlayingUri(state);
|
|
const playingUrl = playingUri && playingUri.uri;
|
|
const claim = makeSelectClaimForUri(playingUrl)(state);
|
|
const url = claim && claim.permanent_url;
|
|
const loopList = selectListLoop(state);
|
|
const loop = loopList && loopList.collectionId === props.id && loopList.loop;
|
|
const shuffleList = selectListShuffle(state);
|
|
const shuffle = shuffleList && shuffleList.collectionId === props.id && shuffleList.newUrls;
|
|
|
|
return {
|
|
url,
|
|
collection: makeSelectCollectionForId(props.id)(state),
|
|
collectionUrls: makeSelectUrlsForCollectionId(props.id)(state),
|
|
collectionName: makeSelectNameForCollectionId(props.id)(state),
|
|
isMine: selectClaimIsMineForUri(state, url),
|
|
loop,
|
|
shuffle,
|
|
};
|
|
};
|
|
|
|
export default connect(select, {
|
|
doToggleLoopList,
|
|
doToggleShuffleList,
|
|
})(CollectionContent);
|