ece2312ec5
## Issue `normalizeUri` | `parseURI` is expensive and has been causing sluggish operations when called repeatedly or within a loop. ## Change Since I'm not confident enough to remove the call entirely from makeSelectClaimIsMine (although I've yet to find a scenario that the uri is not already normalized), we'll try caching the calls instead. ## Results - in a simple test of toggling between 2 category pages, we saved 20ms from `parseURI` calls alone. - in a test of opening all categories one time, the memory usage remained similar. This makes sense since we removed a `makeSelect*` (which creates a selector for each call + not memoizing), and replaced that with a cached selector that's actually memoizing.
20 lines
890 B
JavaScript
20 lines
890 B
JavaScript
import { connect } from 'react-redux';
|
|
import { selectClaimIsMineForUri, makeSelectClaimForUri } from 'redux/selectors/claims';
|
|
import { makeSelectFilePartlyDownloaded } from 'redux/selectors/file_info';
|
|
import { makeSelectEditedCollectionForId } from 'redux/selectors/collections';
|
|
import { makeSelectIsSubscribed } from 'redux/selectors/subscriptions';
|
|
import PreviewOverlayProperties from './view';
|
|
|
|
const select = (state, props) => {
|
|
const claim = makeSelectClaimForUri(props.uri)(state);
|
|
const claimId = claim && claim.claim_id;
|
|
return {
|
|
claim,
|
|
editedCollection: makeSelectEditedCollectionForId(claimId)(state),
|
|
downloaded: makeSelectFilePartlyDownloaded(props.uri)(state),
|
|
isSubscribed: makeSelectIsSubscribed(props.uri)(state),
|
|
claimIsMine: selectClaimIsMineForUri(state, props.uri),
|
|
};
|
|
};
|
|
|
|
export default connect(select, null)(PreviewOverlayProperties);
|