ece2312ec5
## Issue `normalizeUri` | `parseURI` is expensive and has been causing sluggish operations when called repeatedly or within a loop. ## Change Since I'm not confident enough to remove the call entirely from makeSelectClaimIsMine (although I've yet to find a scenario that the uri is not already normalized), we'll try caching the calls instead. ## Results - in a simple test of toggling between 2 category pages, we saved 20ms from `parseURI` calls alone. - in a test of opening all categories one time, the memory usage remained similar. This makes sense since we removed a `makeSelect*` (which creates a selector for each call + not memoizing), and replaced that with a cached selector that's actually memoizing.
30 lines
1.3 KiB
JavaScript
30 lines
1.3 KiB
JavaScript
import { connect } from 'react-redux';
|
|
import {
|
|
makeSelectTitleForUri,
|
|
makeSelectClaimForUri,
|
|
selectClaimIsMineForUri,
|
|
selectFetchingMyChannels,
|
|
} from 'redux/selectors/claims';
|
|
import { doHideModal } from 'redux/actions/app';
|
|
import { doSendTip, doSendCashTip } from 'redux/actions/wallet';
|
|
import { makeSelectClientSetting } from 'redux/selectors/settings';
|
|
import { selectActiveChannelClaim, selectIncognito } from 'redux/selectors/app';
|
|
import { selectBalance, selectIsSendingSupport } from 'redux/selectors/wallet';
|
|
import { withRouter } from 'react-router';
|
|
import * as SETTINGS from 'constants/settings';
|
|
import WalletSendTip from './view';
|
|
|
|
const select = (state, props) => ({
|
|
activeChannelClaim: selectActiveChannelClaim(state),
|
|
balance: selectBalance(state),
|
|
claim: makeSelectClaimForUri(props.uri, false)(state),
|
|
claimIsMine: selectClaimIsMineForUri(state, props.uri),
|
|
fetchingChannels: selectFetchingMyChannels(state),
|
|
incognito: selectIncognito(state),
|
|
instantTipEnabled: makeSelectClientSetting(SETTINGS.INSTANT_PURCHASE_ENABLED)(state),
|
|
instantTipMax: makeSelectClientSetting(SETTINGS.INSTANT_PURCHASE_MAX)(state),
|
|
isPending: selectIsSendingSupport(state),
|
|
title: makeSelectTitleForUri(props.uri)(state),
|
|
});
|
|
|
|
export default withRouter(connect(select, { doHideModal, doSendTip, doSendCashTip })(WalletSendTip));
|