WIP Chainquery mysqlsocket #66

Closed

Leopere wants to merge 3 commits from chainquery-2019-04-28-mysqlsocket into master

Leopere commented

2019-04-28 23:34:58 +02:00

(Migrated from github.com)

Just an update for chainqueries container to add a direct mysql.socket connection instead of using TCP connectivity on the localhost. This improves reliability, security, and speed.

Finished local testing.
Have someone else test and verify this update.

Just an update for chainqueries container to add a direct mysql.socket connection instead of using TCP connectivity on the localhost. This improves reliability, security, and speed. * [ ] Finished local testing. * [ ] Have someone else test and verify this update.

EnigmaCurry (Migrated from github.com) requested changes

2019-04-29 14:28:40 +02:00

EnigmaCurry (Migrated from github.com) left a comment

I think start.sh needs to be configurable as to whether to run in socket mode or TCP mode. So another environment variable? MYSQL_USE_SOCKET=true ?

TCP is the only way that will work in a multi-host environment where mysql and chainquery live on seperate hosts.

I think start.sh needs to be configurable as to whether to run in socket mode or TCP mode. So another environment variable? MYSQL_USE_SOCKET=true ? TCP is the only way that will work in a multi-host environment where mysql and chainquery live on seperate hosts.

Leopere commented

2019-04-30 17:08:49 +02:00

(Migrated from github.com)

Migrating to Percona #69 will stop this from being useful.

Pull request closed

This pull request cannot be reopened because the branch was deleted.

No reviewers

EnigmaCurry

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-docker#66

No description provided.

Rows
Columns