LBRYCommunity/lbry-docker
1
0
Fork 0
Code Issues 2 Pull requests 2 Projects Releases 1 Packages Wiki Activity

lbrynet refactorings #72

Merged
EnigmaCurry merged 1 commit from lbrynet-start.sh into master 2019-05-04 22:33:46 +02:00
Conversation 7 Commits 1 Files changed 4 +24 -20
EnigmaCurry commented 2019-05-01 18:37:56 +02:00 (Migrated from github.com)
Copy link

Various lbrynet container additions:

  • Production: Multi-stage Dockerfile.
  • Production: Adds VERSION ARG to specify the lbrynet version to download.
  • Compiler: Adds REPO ARG to specify alternate git repository to build from.
  • Fixes checkmount arg passing.
  • Adds correct binding IP address to start.sh
  • Adds mountable config to start.sh
  • Does not yet add any Layered Config like #70 (it's harder 'cause yaml)
Various lbrynet container additions: * Production: Multi-stage Dockerfile. * Production: Adds VERSION ARG to specify the lbrynet version to download. * Compiler: Adds REPO ARG to specify alternate git repository to build from. * Fixes checkmount arg passing. * Adds correct binding IP address to start.sh * Adds mountable config to start.sh * Does not yet add any Layered Config like #70 (it's harder 'cause yaml)
❤️ 1
Leopere commented 2019-05-03 13:36:23 +02:00 (Migrated from github.com)
Copy link

Are you certain that 127.0.0.1 isn't going to just bind it to the internal container processes IP only? Otherwise, this is great work thanks again!

Are you certain that 127.0.0.1 isn't going to just bind it to the internal container processes IP only? Otherwise, this is great work thanks again!
👍 1
EnigmaCurry commented 2019-05-03 14:56:32 +02:00 (Migrated from github.com)
Copy link

@Leopere Yes thank you I changed it to 0.0.0.0

@Leopere Yes thank you I changed it to 0.0.0.0
Leopere (Migrated from github.com) reviewed 2019-05-04 22:27:19 +02:00
lbrynet/Dockerfile-linux-multiarch-compiler
@ -39,10 +39,11 @@ RUN apt-get update && \
FROM dependencies as compile
ARG REPO=https://github.com/lbryio/lbry.git
Leopere (Migrated from github.com) commented 2019-05-03 13:43:51 +02:00
Copy link

This will be wonderfully useful, however, lbry's release schema isn't via branches as much as it is via tagged releases. So if this can be adjusted to pull tags automagically it would be extra useful.

This will be wonderfully useful, however, lbry's release schema isn't via branches as much as it is via tagged releases. So if this can be adjusted to pull tags automagically it would be extra useful.
lbrynet/Dockerfile-linux-x86_64-production
@ -6,2 +7,3 @@
ADD https://lbry.io/get/lbrynet.linux.zip /lbrynet/lbrynet.linux.zip
ARG VERSION=latest
RUN URL=$(curl -s https://api.github.com/repos/lbryio/lbry/releases/$(if [ "${VERSION}" = 'latest' ]; then echo "latest"; else echo "tags/${VERSION}"; fi) | grep browser_download_url | grep lbrynet-linux.zip | cut -d'"' -f4) && echo $URL && curl -L -o /lbrynet.linux.zip $URL
Leopere (Migrated from github.com) commented 2019-05-03 13:44:26 +02:00
Copy link

Same as above down here.

Same as above down here.
lbrynet/stuff/checkmount.sh
@ -10,3 +10,3 @@
else
`$@`
bash -c "$*"
fi
Leopere (Migrated from github.com) commented 2019-05-03 13:47:46 +02:00
Copy link

I'm curious about the thoughts behind this change.

I'm curious about the thoughts behind this change.
lbrynet/stuff/start.sh
Leopere (Migrated from github.com) commented 2019-05-03 13:39:44 +02:00
Copy link

I would be wary of 127.0.0.1 as that should perspectively only accept connections from inside of the container itself and not on the external.

I would be wary of 127.0.0.1 as that should perspectively only accept connections from inside of the container itself and not on the external.
EnigmaCurry (Migrated from github.com) reviewed 2019-05-04 22:28:13 +02:00
lbrynet/stuff/start.sh
EnigmaCurry (Migrated from github.com) commented 2019-05-04 22:28:13 +02:00
Copy link

yes my mistake, fixed.

yes my mistake, fixed.
EnigmaCurry (Migrated from github.com) reviewed 2019-05-04 22:29:45 +02:00
lbrynet/Dockerfile-linux-multiarch-compiler
@ -39,10 +39,11 @@ RUN apt-get update && \
FROM dependencies as compile
ARG REPO=https://github.com/lbryio/lbry.git
EnigmaCurry (Migrated from github.com) commented 2019-05-04 22:29:45 +02:00
Copy link

This case will work with branches and tags. git checkout v0.37.0rc5 works for instance.

This case will work with branches and tags. ```git checkout v0.37.0rc5``` works for instance.
EnigmaCurry (Migrated from github.com) reviewed 2019-05-04 22:32:39 +02:00
lbrynet/stuff/checkmount.sh
@ -10,3 +10,3 @@
else
`$@`
bash -c "$*"
fi
EnigmaCurry (Migrated from github.com) commented 2019-05-04 22:32:39 +02:00
Copy link

$@ was not accepting additional arguments beyond the first one. "$*" captures the entire argument string. You showed me the page https://eklitzke.org/bash-$%2A-and-$@ and he outlines the case for "$*" translating to "$1 $2 $3 ..." which is exactly what we want to pass to bash -c

`$@` was not accepting additional arguments beyond the first one. "$\*" captures the entire argument string. You showed me the page https://eklitzke.org/bash-$%2A-and-$@ and he outlines the case for "$*" translating to "$1 $2 $3 ..." which is exactly what we want to pass to `bash -c`
Leopere (Migrated from github.com) reviewed 2019-05-04 22:32:49 +02:00
lbrynet/Dockerfile-linux-multiarch-compiler
@ -39,10 +39,11 @@ RUN apt-get update && \
FROM dependencies as compile
ARG REPO=https://github.com/lbryio/lbry.git
Leopere (Migrated from github.com) commented 2019-05-04 22:32:48 +02:00
Copy link

I wonder if we can find a way to do new tag releases with magic.

I wonder if we can find a way to do new tag releases with magic.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Accepted

Just for marking accepted PR's

  
area: devops

   
area: discovery

   
area: docs

   
area: livestream

   
area: proposal

Work is part of a proposal

  
consider soon

Discuss this issue at the next planning meeting, then remove this label

  
Epic

   
good first issue

Good for newcomers

  
hacktoberfest

Welcome to Hacktoberfest

  
help wanted

Extra attention is needed

  
icebox

Long-term storage

  
In Review

Pull Requests that are currently in review and potentially waiting tweaks or feedback for clarity.

  
level: 1

No knowledge of the existing code required

  
level: 2

Some knowledge of the existing code is recommended

  
level: 3

Significant knowledge of the existing code is recommended

  
level: 4

Intimate knowledge of the existing code is recommended

  
needs: exploration

Solution unclear, needs research

  
needs: grooming

Issue needs to be groomed before work can start

  
needs: priority

Priority level needs to be defined

  
needs: repro

Issue needs step-by-step instructions on how to reproduce in latest code

  
needs: tech design

Needs technical design signoff before implementation can begin

  
on hold

Temporarily paused

  
priority: blocker

Issue is blocking release, do ASAP

  
priority: high

Work needs to be moved into sprint ASAP

  
priority: low

Work should be done but can stay in the backlog for now

  
priority: medium

Work needs to be done within 2-3 sprints

  
resilience

   
Tom's Wishlist

   
type: bug

Existing functionality is wrong or broken

  
type: discussion

A conversation. No specific changes requested

  
type: improvement

Existing (or partially existing) functionality needs to be changed

  
type: new feature

New functionality that does not exist yet

  
type: refactor

Minimal user-visible changes, but significant internal work

  
type: task

Either work that's not related to the code, or a small chore that does not fit into other categories

  
type: testing

Solution needs additional user testing

  
unplanned

Work that was not planned into the spirnt, took priority over planned work

No labels
Accepted
area: devops
area: discovery
area: docs
area: livestream
area: proposal
consider soon
Epic
good first issue
hacktoberfest
help wanted
icebox
In Review
level: 1
level: 2
level: 3
level: 4
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
on hold
priority: blocker
priority: high
priority: low
priority: medium
resilience
Tom's Wishlist
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-docker#72
No description provided.
Delete branch "lbrynet-start.sh"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?