LBRYCommunity/lbry-docker

Fork 0

Multi-stage Dockerfile for spee.ch #74

Open

EnigmaCurry wants to merge 1 commit from EnigmaCurry/k8s-lbry-speech into master

EnigmaCurry commented

2019-05-31 01:05:43 +02:00

(Migrated from github.com)

This creates a spee.ch container.

Spee.ch imports its configuration from its own bundle. This means that we need to have the whole configuration at bundle time. Since we don't have the configuration until runtime, this force us to create the bundle at runtime.

Ideally, the final image would not even have npm in it. Simply copying the node_modules from the prep stage over to the app stage, and mounting the configuration files should be sufficient. However, this would require a change to how spee.ch imports its configuration.

For now, this works with the way spee.ch currently works.

This creates a spee.ch container. Spee.ch imports its configuration from its own bundle. This means that we need to have the whole configuration at bundle time. Since we don't have the configuration until runtime, this force us to create the bundle at runtime. Ideally, the final image would not even have npm in it. Simply copying the node_modules from the `prep` stage over to the `app` stage, and mounting the configuration files should be sufficient. However, this would require a change to how spee.ch imports its configuration. For now, this works with the way spee.ch currently works.

EnigmaCurry commented

2019-05-31 14:59:30 +02:00

(Migrated from github.com)

This should not run as root.

Leopere (Migrated from github.com) approved these changes 2019-06-14 23:18:29 +02:00

Leopere (Migrated from github.com) left a comment

This is a good baseline and will function however I would not consider it stable or up to spec with the other containers. I do not recommend using this in production yet but I'll consider it merge-able for now to help along the process of other things like the K8's stuff in #71

Leopere (Migrated from github.com) requested changes 2019-06-14 23:20:46 +02:00

Leopere (Migrated from github.com) left a comment

This should have it's own README.md to explain the state that this container is in and it's current goals.

This pull request can be merged automatically.

You are not authorized to merge this pull request.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin EnigmaCurry/k8s-lbry-speech:EnigmaCurry/k8s-lbry-speech

git checkout EnigmaCurry/k8s-lbry-speech

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git checkout master

git merge --no-ff EnigmaCurry/k8s-lbry-speech

git checkout EnigmaCurry/k8s-lbry-speech

git rebase master

git checkout master

git merge --ff-only EnigmaCurry/k8s-lbry-speech

git checkout EnigmaCurry/k8s-lbry-speech

git rebase master

git checkout master

git merge --no-ff EnigmaCurry/k8s-lbry-speech

git checkout master

git merge --squash EnigmaCurry/k8s-lbry-speech

git checkout master

git merge --ff-only EnigmaCurry/k8s-lbry-speech

git checkout master

git merge EnigmaCurry/k8s-lbry-speech

git push origin master

No reviewers

Leopere

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-docker#74

No description provided.