LBRYCommunity/lbry-fdroid
1
0
Fork 0
Code Issues 4 Pull requests Packages Projects Releases Wiki Activity

Remove Google Cast feature as it depends on GMS #7

Merged
kekkyojin merged 1 commit from remove-gms-cast into master 2020-12-28 11:16:12 +01:00
Conversation 0 Commits 1 Files changed 15 -79
kekkyojin commented 2020-12-28 11:14:46 +01:00 (Migrated from github.com)
Copy link

PR Type

What kind of change does this PR introduce?

  • Bugfix

Fixes

Issue Number: #6

What is the current behavior?

Offers content to be "casted" into compatible devices, but it uses Google Messaging Services, which cannot be used or its dependencies included on any app available on F-Droid.

What is the new behavior?

User is not going to be able to "cast" any content to any compatible device.

Other information

I ran VirusTotal on an APK from this code: https://www.virustotal.com/gui/file/189c5f506135f1d6c32cb5d083a0f237e08b869df6953bf515592f95084c0ef0/details

## PR Type What kind of change does this PR introduce? - [x] Bugfix ## Fixes Issue Number: #6 ## What is the current behavior? Offers content to be "casted" into compatible devices, but it uses Google Messaging Services, which cannot be used or its dependencies included on any app available on F-Droid. ## What is the new behavior? User is not going to be able to "cast" any content to any compatible device. ## Other information I ran VirusTotal on an APK from this code: https://www.virustotal.com/gui/file/189c5f506135f1d6c32cb5d083a0f237e08b869df6953bf515592f95084c0ef0/details
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-fdroid#7
No description provided.
Delete branch "remove-gms-cast"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?