LBRYCommunity/lbry-sdk
1
0
Fork 1
Code Issues Pull requests Projects Releases 282 Packages Wiki Activity

Updated Development Process & Standards (markdown)

Jack Robison 2017-07-24 14:57:19 -04:00
parent ed1278d28f
commit f4ca51ae1d
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
Development-Process-&-Standards.md

@ -5,6 +5,7 @@
1. squash/rebase code for sharing, write quality commit messages
1. run automated linting/testing suite. if there are issues, goto 1
1. test the code yourself (on every OS/platform/environment we support)
1. document your changes in the [changelog](https://github.com/lbryio/lbry/wiki/Changelog-format)
1. create PR (or update existing PR)
1. assign someone to review and approve your PR. if reviewer raises any issues, goto 1
1. squash fixup commits; merge your PR into master; delete branch
@ -17,7 +18,7 @@
3. Commit messages should be informative, usable for release notes, and provide context/explanation for the change being made
4. Commits on master should stand-alone
5. Force pushes on feature branches are allowed; please commit early and often, but clean-up the mess before merging into master.
6. Pull requests should have an informative changelog entry (see [changelog format](https://github.com/lbryio/lbry/wiki/Changelog-format)).
# Code Review