LBRYCommunity/lbrycrd
1
0
Fork 0
Code Issues29 Pull requests1 Projects Releases32 Packages Wiki Activity

Lbrycrd claimtrie unit test improvements #83

New issue
Closed
opened 2018-01-23 15:56:03 +01:00 by kaykurokawa · 1 comment
kaykurokawa commented 2018-01-23 15:56:03 +01:00 (Migrated from github.com)

Old tests for the claimtrie ( https://github.com/lbryio/lbrycrd/blob/master/src/test/claimtrie_tests.cpp ) should be merged with new tests which contains fixtures and functions to make the expansion of unit tests easier: https://github.com/lbryio/lbrycrd/blob/master/src/test/claimtriebranching_tests.cpp

The new tests could also be improved more, it is mainly testing for the best claim, and we should test other things in the claim trie such as the number of claims in the trie, check if the claimtrie root merkle hash is being updated, check that supports are present in the claim trie directly, etc..

Old tests for the claimtrie ( https://github.com/lbryio/lbrycrd/blob/master/src/test/claimtrie_tests.cpp ) should be merged with new tests which contains fixtures and functions to make the expansion of unit tests easier: https://github.com/lbryio/lbrycrd/blob/master/src/test/claimtriebranching_tests.cpp The new tests could also be improved more, it is mainly testing for the best claim, and we should test other things in the claim trie such as the number of claims in the trie, check if the claimtrie root merkle hash is being updated, check that supports are present in the claim trie directly, etc..
BrannonKing commented 2018-08-08 00:04:26 +02:00 (Migrated from github.com)

done via

done via #183
Sign in to join this conversation.
No labels
area: devops
area: discovery
area: docs
area: livestream
area: proposal
consider soon
Epic
good first issue
hacktoberfest
hard fork
help wanted
icebox
Invalid
level: 0
level: 1
level: 2
level: 3
level: 4
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
on hold
priority: blocker
priority: high
priority: low
priority: medium
resilience
soft fork
Tom's Wishlist
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
work in progress
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbrycrd#83
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?