LBRYCommunity/lbrycrd
1
0
Fork 0
Code Issues 29 Pull requests 1 Packages Projects Releases 32 Wiki Activity
lbrycrd/src/qt
History
Wladimir J. van der Laan f19ca129ff
Merge #11605: [Wallet] Enable RBF by default in QT 
5cbbbd7 [Wallet] Use RBF by default in QT only (Sjors Provoost)

Pull request description:

  ~If there are no objections, this would supersede #11556.~

  Enabling RBF by default avoids the need to explain all possible use cases of RBF.

  This PR does not change the default RPC wallet behavior, as this could break implementations that depend on it and it's not clear what happens when automated services suddenly switch on RBF on a large scale.

  After trying various approaches, we settled on just having QT ignore `-walletrbf`.

  Send screen:
  <img width="388" alt="send" src="https://user-images.githubusercontent.com/10217/34251097-329c8dee-e63f-11e7-9e14-d7f55d2b52cc.png">

  Confirmation screen by default (with RBF):
  <img width="429" alt="rbf yes" src="https://user-images.githubusercontent.com/10217/32442799-f50d54aa-c2fc-11e7-9392-96339d0f1f74.png">

  Confirmation screen without RBF:
  <img width="431" alt="rf no" src="https://user-images.githubusercontent.com/10217/32442793-ef30bc34-c2fc-11e7-8ca2-e86a97175278.png">

Tree-SHA512: 53efb5d277144478143e69dcae8112c1b9c2beb981fdd0fe778592e5f7d5bf838f73d48052ead874586a75b944e8af469b25e5f376c135cf48cc3598e77f5891
2017-12-22 13:15:31 +01:00
..
forms [Wallet] Use RBF by default in QT only 2017-12-22 09:18:05 +01:00
locale qt: Periodic translations update 2017-08-09 12:04:41 +02:00
res [qt] Make network disabled icon 50% opaque 2016-11-13 22:06:35 +01:00
test qt: refactor: Changes to make include paths absolute 2017-11-16 08:23:02 +13:00
addressbookpage.cpp qt: refactor: Changes to make include paths absolute 2017-11-16 08:23:02 +13:00
addressbookpage.h Remove unnecessary forward class declarations in header files 2017-06-12 20:37:43 +02:00
addresstablemodel.cpp scripted-diff: Replace #include "" with #include <> (ryanofsky) 2017-11-16 08:23:01 +13:00
addresstablemodel.h
askpassphrasedialog.cpp qt: refactor: Changes to make include paths absolute 2017-11-16 08:23:02 +13:00
askpassphrasedialog.h [ui] Add toggle for unblinding password fields 2017-10-18 13:22:30 -07:00
bantablemodel.cpp Merge #10493: Use range-based for loops (C++11) when looping over map elements 2017-11-30 17:10:05 -05:00
bantablemodel.h scripted-diff: Replace #include "" with #include <> (ryanofsky) 2017-11-16 08:23:01 +13:00
bitcoin.cpp Create walletdir if datadir doesn't exist and fix tests 2017-11-18 00:50:59 +13:00
bitcoin.qrc Overhaul network activity toggle 2016-10-24 10:23:58 +00:00
bitcoin_locale.qrc qt: periodic translations update 2017-01-10 12:52:02 +01:00
bitcoinaddressvalidator.cpp scripted-diff: Replace #include "" with #include <> (ryanofsky) 2017-11-16 08:23:01 +13:00
bitcoinaddressvalidator.h
bitcoinamountfield.cpp qt: refactor: Changes to make include paths absolute 2017-11-16 08:23:02 +13:00
bitcoinamountfield.h scripted-diff: Replace #include "" with #include <> (ryanofsky) 2017-11-16 08:23:01 +13:00
bitcoingui.cpp Remove includes in .cpp files for things the corresponding .h file already included 2017-11-16 22:26:34 +01:00
bitcoingui.h scripted-diff: Replace #include "" with #include <> (ryanofsky) 2017-11-16 08:23:01 +13:00
bitcoinstrings.cpp qt: Periodic translations update 2017-07-31 12:19:05 +02:00
bitcoinunits.cpp scripted-diff: Replace #include "" with #include <> (ryanofsky) 2017-11-16 08:23:01 +13:00
bitcoinunits.h scripted-diff: Replace #include "" with #include <> (ryanofsky) 2017-11-16 08:23:01 +13:00
callback.h Declare single-argument (non-converting) constructors "explicit" 2017-08-16 16:33:25 +02:00
clientmodel.cpp scripted-diff: Replace #include "" with #include <> (ryanofsky) 2017-11-16 08:23:01 +13:00
clientmodel.h Remove unnecessary forward class declarations in header files 2017-06-12 20:37:43 +02:00
coincontroldialog.cpp Remove includes in .cpp files for things the corresponding .h file already included 2017-11-16 22:26:34 +01:00
coincontroldialog.h scripted-diff: Replace #include "" with #include <> (ryanofsky) 2017-11-16 08:23:01 +13:00
coincontroltreewidget.cpp scripted-diff: Replace #include "" with #include <> (ryanofsky) 2017-11-16 08:23:01 +13:00
coincontroltreewidget.h
csvmodelwriter.cpp scripted-diff: Replace #include "" with #include <> (ryanofsky) 2017-11-16 08:23:01 +13:00
csvmodelwriter.h
editaddressdialog.cpp qt: refactor: Changes to make include paths absolute 2017-11-16 08:23:02 +13:00
editaddressdialog.h
guiconstants.h Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
guiutil.cpp Remove includes in .cpp files for things the corresponding .h file already included 2017-11-16 22:26:34 +01:00
guiutil.h scripted-diff: Replace #include "" with #include <> (ryanofsky) 2017-11-16 08:23:01 +13:00
intro.cpp Create walletdir if datadir doesn't exist and fix tests 2017-11-18 00:50:59 +13:00
intro.h Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
macdockiconhandler.h
macdockiconhandler.mm Document the preference of nullptr over NULL or (void*)0 2017-08-18 09:51:00 +02:00
macnotificationhandler.h [macOS] remove Growl support, remove unused code 2017-09-07 10:11:44 -07:00
macnotificationhandler.mm [macOS] remove Growl support, remove unused code 2017-09-07 10:11:44 -07:00
Makefile
modaloverlay.cpp qt: refactor: Changes to make include paths absolute 2017-11-16 08:23:02 +13:00
modaloverlay.h Add const to methods that do not modify the object for which it is called 2017-07-25 13:46:52 +02:00
networkstyle.cpp scripted-diff: Replace #include "" with #include <> (ryanofsky) 2017-11-16 08:23:01 +13:00
networkstyle.h
notificator.cpp Remove includes in .cpp files for things the corresponding .h file already included 2017-11-16 22:26:34 +01:00
notificator.h scripted-diff: Replace #include "" with #include <> (ryanofsky) 2017-11-16 08:23:01 +13:00
openuridialog.cpp qt: refactor: Changes to make include paths absolute 2017-11-16 08:23:02 +13:00
openuridialog.h
optionsdialog.cpp gui: Fix proxy setting options dialog crash 2017-12-07 17:34:16 +01:00
optionsdialog.h Add a button to open the config file in a text editor 2017-03-23 12:54:36 -04:00
optionsmodel.cpp Merge #10574: Remove includes in .cpp files for things the corresponding .h file already included 2017-12-12 14:56:25 +01:00
optionsmodel.h gui: Fix proxy setting options dialog crash 2017-12-07 17:34:16 +01:00
overviewpage.cpp qt: refactor: Changes to make include paths absolute 2017-11-16 08:23:02 +13:00
overviewpage.h scripted-diff: Replace #include "" with #include <> (ryanofsky) 2017-11-16 08:23:01 +13:00
paymentrequest.proto Specify Protobuf version 2 in paymentrequest.proto 2016-09-16 11:45:08 +08:00
paymentrequestplus.cpp scripted-diff: Replace #include "" with #include <> (ryanofsky) 2017-11-16 08:23:01 +13:00
paymentrequestplus.h qt: refactor: Changes to make include paths absolute 2017-11-16 08:23:02 +13:00
paymentserver.cpp scripted-diff: Replace #include "" with #include <> (ryanofsky) 2017-11-16 08:23:01 +13:00
paymentserver.h scripted-diff: Replace #include "" with #include <> (ryanofsky) 2017-11-16 08:23:01 +13:00
peertablemodel.cpp scripted-diff: Replace #include "" with #include <> (ryanofsky) 2017-11-16 08:23:01 +13:00
peertablemodel.h scripted-diff: Replace #include "" with #include <> (ryanofsky) 2017-11-16 08:23:01 +13:00
platformstyle.cpp Remove includes in .cpp files for things the corresponding .h file already included 2017-11-16 22:26:34 +01:00
platformstyle.h
qvalidatedlineedit.cpp scripted-diff: Replace #include "" with #include <> (ryanofsky) 2017-11-16 08:23:01 +13:00
qvalidatedlineedit.h
qvaluecombobox.cpp scripted-diff: Replace #include "" with #include <> (ryanofsky) 2017-11-16 08:23:01 +13:00
qvaluecombobox.h
receivecoinsdialog.cpp Remove includes in .cpp files for things the corresponding .h file already included 2017-11-16 22:26:34 +01:00
receivecoinsdialog.h scripted-diff: Replace #include "" with #include <> (ryanofsky) 2017-11-16 08:23:01 +13:00
receiverequestdialog.cpp Remove includes in .cpp files for things the corresponding .h file already included 2017-11-16 22:26:34 +01:00
receiverequestdialog.h scripted-diff: Replace #include "" with #include <> (ryanofsky) 2017-11-16 08:23:01 +13:00
recentrequeststablemodel.cpp scripted-diff: Replace #include "" with #include <> (ryanofsky) 2017-11-16 08:23:01 +13:00
recentrequeststablemodel.h scripted-diff: Replace #include "" with #include <> (ryanofsky) 2017-11-16 08:23:01 +13:00
rpcconsole.cpp Merge #10574: Remove includes in .cpp files for things the corresponding .h file already included 2017-12-12 14:56:25 +01:00
rpcconsole.h scripted-diff: Replace #include "" with #include <> (ryanofsky) 2017-11-16 08:23:01 +13:00
sendcoinsdialog.cpp Merge #11605: [Wallet] Enable RBF by default in QT 2017-12-22 13:15:31 +01:00
sendcoinsdialog.h scripted-diff: Replace #include "" with #include <> (ryanofsky) 2017-11-16 08:23:01 +13:00
sendcoinsentry.cpp Remove includes in .cpp files for things the corresponding .h file already included 2017-11-16 22:26:34 +01:00
sendcoinsentry.h scripted-diff: Replace #include "" with #include <> (ryanofsky) 2017-11-16 08:23:01 +13:00
signverifymessagedialog.cpp qt: refactor: Changes to make include paths absolute 2017-11-16 08:23:02 +13:00
signverifymessagedialog.h
splashscreen.cpp scripted-diff: Replace #include "" with #include <> (ryanofsky) 2017-11-16 08:23:01 +13:00
splashscreen.h Drop upgrade-cancel callback registration for a generic "resumeable" 2017-08-20 20:04:15 -04:00
trafficgraphwidget.cpp scripted-diff: Replace #include "" with #include <> (ryanofsky) 2017-11-16 08:23:01 +13:00
trafficgraphwidget.h
transactiondesc.cpp scripted-diff: Replace #include "" with #include <> (ryanofsky) 2017-11-16 08:23:01 +13:00
transactiondesc.h
transactiondescdialog.cpp qt: refactor: Changes to make include paths absolute 2017-11-16 08:23:02 +13:00
transactiondescdialog.h
transactionfilterproxy.cpp Merge #10574: Remove includes in .cpp files for things the corresponding .h file already included 2017-12-12 14:56:25 +01:00
transactionfilterproxy.h Merge #11395: Qt: Enable searching by transaction id 2017-11-29 13:51:16 -10:00
transactionrecord.cpp scripted-diff: Replace #include "" with #include <> (ryanofsky) 2017-11-16 08:23:01 +13:00
transactionrecord.h scripted-diff: Replace #include "" with #include <> (ryanofsky) 2017-11-16 08:23:01 +13:00
transactiontablemodel.cpp Merge #10493: Use range-based for loops (C++11) when looping over map elements 2017-11-30 17:10:05 -05:00
transactiontablemodel.h scripted-diff: Replace #include "" with #include <> (ryanofsky) 2017-11-16 08:23:01 +13:00
transactionview.cpp Merge #10574: Remove includes in .cpp files for things the corresponding .h file already included 2017-12-12 14:56:25 +01:00
transactionview.h Merge #11395: Qt: Enable searching by transaction id 2017-11-29 13:51:16 -10:00
utilitydialog.cpp qt: refactor: Changes to make include paths absolute 2017-11-16 08:23:02 +13:00
utilitydialog.h Declare single-argument (non-converting) constructors "explicit" 2017-08-16 16:33:25 +02:00
walletframe.cpp scripted-diff: Replace #include "" with #include <> (ryanofsky) 2017-11-16 08:23:01 +13:00
walletframe.h Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
walletmodel.cpp [Wallet] Use RBF by default in QT only 2017-12-22 09:18:05 +01:00
walletmodel.h [Wallet] Use RBF by default in QT only 2017-12-22 09:18:05 +01:00
walletmodeltransaction.cpp Merge #10920: [qt] Fix potential memory leak in newPossibleKey(ChangeCWallet *wallet) 2017-11-17 13:07:37 +01:00
walletmodeltransaction.h Merge #10920: [qt] Fix potential memory leak in newPossibleKey(ChangeCWallet *wallet) 2017-11-17 13:07:37 +01:00
walletview.cpp scripted-diff: Replace #include "" with #include <> (ryanofsky) 2017-11-16 08:23:01 +13:00
walletview.h scripted-diff: Replace #include "" with #include <> (ryanofsky) 2017-11-16 08:23:01 +13:00
winshutdownmonitor.cpp scripted-diff: Replace #include "" with #include <> (ryanofsky) 2017-11-16 08:23:01 +13:00
winshutdownmonitor.h