LBRYCommunity/lbrycrd
1
0
Fork 0
Code Issues 29 Pull requests 1 Packages Projects Releases 32 Wiki Activity
lbrycrd/src/qt
History
Wladimir J. van der Laan 07c92b98e2
Merge #10976: [MOVEONLY] Move some static functions out of wallet.h/cpp 
f01103c MOVEONLY: Init functions wallet/wallet.cpp -> wallet/init.cpp (Russell Yanofsky)
e7fe320 MOVEONLY: Fee functions wallet/wallet.cpp -> wallet/fees.cpp (Russell Yanofsky)
d97fe20 Move some static functions out of wallet.h/cpp (Russell Yanofsky)

Pull request description:

  This just moves some static wallet fee and init functions out of `wallet/wallet.cpp` and into new `wallet/fees.cpp` and `wallet/init.cpp` source files. There is one commit updating declarations and callers, followed by two MOVEONLY commits actually moving the function bodies.

  This change is desirable because wallet.h/cpp are monolithic and hard to navigate, so pulling things out and grouping together pieces of related functionality should improve the organization.

  Another motivation is the wallet process separation work in https://github.com/bitcoin/bitcoin/pull/10973, where (at least initially) parameter parsing and fee estimation are still done in the main process rather than the wallet process, and having functions that run in different processes scrambled up throughout wallet.cpp is unnecessarily confusing.

Tree-SHA512: 6e6982ff82b2ab4e681c043907e2b1801ceb9513394730070f16c46ad338278a863f5b3759aa13db76a259b268b1c919c81f4e339f0796a3cfb990161e8c316d
2017-08-25 21:30:42 +02:00
..
forms Fix typo in sendcoinsdialog. 2017-08-02 12:19:50 +09:00
locale qt: Periodic translations update 2017-08-09 12:04:41 +02:00
res [qt] Make network disabled icon 50% opaque 2016-11-13 22:06:35 +01:00
test Merge #10956: Fix typos 2017-08-16 00:37:18 +02:00
addressbookpage.cpp scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL 2017-08-07 07:36:37 +02:00
addressbookpage.h Remove unnecessary forward class declarations in header files 2017-06-12 20:37:43 +02:00
addresstablemodel.cpp scripted-diff: Remove #include <boost/foreach.hpp> 2017-06-22 03:48:52 +02:00
addresstablemodel.h Bump copyright headers to 2015 2015-12-13 18:08:39 +01:00
askpassphrasedialog.cpp Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
askpassphrasedialog.h qt: askpassphrasedialog: Clear pass fields on accept 2016-05-19 14:52:08 +03:00
bantablemodel.cpp Remove excess logic. 2017-04-10 10:24:49 +02:00
bantablemodel.h Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
bitcoin.cpp Merge #9964: Add const to methods that do not modify the object for which it is called 2017-08-16 02:09:49 +02:00
bitcoin.qrc Overhaul network activity toggle 2016-10-24 10:23:58 +00:00
bitcoin_locale.qrc qt: periodic translations update 2017-01-10 12:52:02 +01:00
bitcoinaddressvalidator.cpp
bitcoinaddressvalidator.h
bitcoinamountfield.cpp Bump copyright headers to 2015 2015-12-13 18:08:39 +01:00
bitcoinamountfield.h Bump copyright headers to 2015 2015-12-13 18:08:39 +01:00
bitcoingui.cpp scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL 2017-08-07 07:36:37 +02:00
bitcoingui.h scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL 2017-08-07 07:36:37 +02:00
bitcoinstrings.cpp qt: Periodic translations update 2017-07-31 12:19:05 +02:00
bitcoinunits.cpp Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
bitcoinunits.h Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
callback.h Declare single-argument (non-converting) constructors "explicit" 2017-08-16 16:33:25 +02:00
clientmodel.cpp Avoid redundant redeclaration of GetWarnings(const string&) 2017-07-18 15:54:38 +02:00
clientmodel.h Remove unnecessary forward class declarations in header files 2017-06-12 20:37:43 +02:00
coincontroldialog.cpp Move some static functions out of wallet.h/cpp 2017-08-14 11:19:38 -04:00
coincontroldialog.h Declare single-argument (non-converting) constructors "explicit" 2017-08-16 16:33:25 +02:00
coincontroltreewidget.cpp Limit variable scope 2017-06-05 00:52:36 +02:00
coincontroltreewidget.h Bump copyright headers to 2014 2016-01-05 21:01:39 +01:00
csvmodelwriter.cpp Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
csvmodelwriter.h Bump copyright headers to 2014 2016-01-05 21:01:39 +01:00
editaddressdialog.cpp Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
editaddressdialog.h Bump copyright headers to 2015 2015-12-13 18:08:39 +01:00
guiconstants.h Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
guiutil.cpp scripted-diff: stop using the gArgs wrappers 2017-08-14 17:02:10 +02:00
guiutil.h Merge #9890: Add a button to open the config file in a text editor 2017-04-10 10:46:21 +02:00
intro.cpp Declare single-argument (non-converting) constructors "explicit" 2017-08-16 16:33:25 +02:00
intro.h Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
macdockiconhandler.h Bump copyright headers to 2015 2015-12-13 18:08:39 +01:00
macdockiconhandler.mm Document the preference of nullptr over NULL or (void*)0 2017-08-18 09:51:00 +02:00
macnotificationhandler.h Bump copyright headers to 2014 2016-01-05 21:01:39 +01:00
macnotificationhandler.mm Document the preference of nullptr over NULL or (void*)0 2017-08-18 09:51:00 +02:00
Makefile
modaloverlay.cpp Fixed multiple typos 2017-06-22 19:18:10 +03:00
modaloverlay.h Add const to methods that do not modify the object for which it is called 2017-07-25 13:46:52 +02:00
networkstyle.cpp doc: spelling fixes 2017-08-16 00:24:39 +02:00
networkstyle.h
notificator.cpp Declare single-argument (non-converting) constructors "explicit" 2017-08-16 16:33:25 +02:00
notificator.h Bump copyright headers to 2015 2015-12-13 18:08:39 +01:00
openuridialog.cpp scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL 2017-08-07 07:36:37 +02:00
openuridialog.h Bump copyright headers to 2015 2015-12-13 18:08:39 +01:00
optionsdialog.cpp Move some static functions out of wallet.h/cpp 2017-08-14 11:19:38 -04:00
optionsdialog.h Add a button to open the config file in a text editor 2017-03-23 12:54:36 -04:00
optionsmodel.cpp Merge #9964: Add const to methods that do not modify the object for which it is called 2017-08-16 02:09:49 +02:00
optionsmodel.h Add const to methods that do not modify the object for which it is called 2017-07-25 13:46:52 +02:00
overviewpage.cpp Declare single-argument (non-converting) constructors "explicit" 2017-08-16 16:33:25 +02:00
overviewpage.h Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
paymentrequest.proto Specify Protobuf version 2 in paymentrequest.proto 2016-09-16 11:45:08 +08:00
paymentrequestplus.cpp Declare single-argument (non-converting) constructors "explicit" 2017-08-16 16:33:25 +02:00
paymentrequestplus.h Selectively suppress deprecation warnings 2017-02-14 13:50:57 +01:00
paymentserver.cpp Merge #10964: Pass SendCoinsRecipient (208 bytes) by reference 2017-08-15 20:43:45 +02:00
paymentserver.h Declare single-argument (non-converting) constructors "explicit" 2017-08-16 16:33:25 +02:00
peertablemodel.cpp scripted-diff: Remove Q_FOREACH 2017-06-05 20:11:01 +02:00
peertablemodel.h Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
platformstyle.cpp scripted-diff: Remove Q_FOREACH 2017-06-05 20:11:01 +02:00
platformstyle.h qt: Introduce PlatformStyle 2015-07-31 09:35:18 +02:00
qvalidatedlineedit.cpp Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
qvalidatedlineedit.h Bump copyright headers to 2015 2015-12-13 18:08:39 +01:00
qvaluecombobox.cpp Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
qvaluecombobox.h Bump copyright headers to 2015 2015-12-13 18:08:39 +01:00
receivecoinsdialog.cpp scripted-diff: Remove Q_FOREACH 2017-06-05 20:11:01 +02:00
receivecoinsdialog.h Remove unnecessary forward class declarations in header files 2017-06-12 20:37:43 +02:00
receiverequestdialog.cpp scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL 2017-08-07 07:36:37 +02:00
receiverequestdialog.h Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
recentrequeststablemodel.cpp scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL 2017-08-07 07:36:37 +02:00
recentrequeststablemodel.h Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
rpcconsole.cpp scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL 2017-08-07 07:36:37 +02:00
rpcconsole.h scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL 2017-08-07 07:36:37 +02:00
sendcoinsdialog.cpp Move some static functions out of wallet.h/cpp 2017-08-14 11:19:38 -04:00
sendcoinsdialog.h Use CoinControl to pass custom fee setting from QT. 2017-07-14 23:40:33 -04:00
sendcoinsentry.cpp Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
sendcoinsentry.h Bump copyright headers to 2015 2015-12-13 18:08:39 +01:00
signverifymessagedialog.cpp Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
signverifymessagedialog.h Bump copyright headers to 2015 2015-12-13 18:08:39 +01:00
splashscreen.cpp [Qt] allow to execute a callback during splashscreen progress 2017-06-29 17:48:08 +02:00
splashscreen.h [Qt] allow to execute a callback during splashscreen progress 2017-06-29 17:48:08 +02:00
trafficgraphwidget.cpp Merge #10502: scripted-diff: Remove BOOST_FOREACH, Q_FOREACH and PAIRTYPE 2017-06-13 18:05:58 -07:00
trafficgraphwidget.h Bump copyright headers to 2015 2015-12-13 18:08:39 +01:00
transactiondesc.cpp scripted-diff: Remove PAIRTYPE 2017-06-05 20:14:53 +02:00
transactiondesc.h Bump copyright headers to 2014 2016-01-05 21:01:39 +01:00
transactiondescdialog.cpp Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
transactiondescdialog.h Bump copyright headers to 2014 2016-01-05 21:01:39 +01:00
transactionfilterproxy.cpp Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
transactionfilterproxy.h Bump copyright headers to 2014 2016-01-05 21:01:39 +01:00
transactionrecord.cpp Merge #9964: Add const to methods that do not modify the object for which it is called 2017-08-16 02:09:49 +02:00
transactionrecord.h Add const to methods that do not modify the object for which it is called 2017-07-25 13:46:52 +02:00
transactiontablemodel.cpp Merge #10502: scripted-diff: Remove BOOST_FOREACH, Q_FOREACH and PAIRTYPE 2017-06-13 18:05:58 -07:00
transactiontablemodel.h Add const to methods that do not modify the object for which it is called 2017-07-25 13:46:52 +02:00
transactionview.cpp scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL 2017-08-07 07:36:37 +02:00
transactionview.h [Qt] simple fee bumper with user verification 2017-05-11 15:27:04 +02:00
utilitydialog.cpp scripted-diff: stop using the gArgs wrappers 2017-08-14 17:02:10 +02:00
utilitydialog.h Declare single-argument (non-converting) constructors "explicit" 2017-08-16 16:33:25 +02:00
walletframe.cpp Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
walletframe.h Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
walletmodel.cpp Merge #11039: Avoid second mapWallet lookup 2017-08-18 16:25:59 +02:00
walletmodel.h scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL 2017-08-07 07:36:37 +02:00
walletmodeltransaction.cpp Add const to methods that do not modify the object for which it is called 2017-07-25 13:46:52 +02:00
walletmodeltransaction.h Add const to methods that do not modify the object for which it is called 2017-07-25 13:46:52 +02:00
walletview.cpp scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL 2017-08-07 07:36:37 +02:00
walletview.h Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
winshutdownmonitor.cpp scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL 2017-08-07 07:36:37 +02:00
winshutdownmonitor.h