LBRYCommunity/lbrycrd
1
0
Fork 0
Code Issues 29 Pull requests 1 Packages Projects Releases 32 Wiki Activity
lbrycrd/src/qt
History
Wladimir J. van der Laan d080a7d503
Merge #11466: Specify custom wallet directory with -walletdir param 
c1e5d40 Make debugging test crash easier (MeshCollider)
8263f6a Create walletdir if datadir doesn't exist and fix tests (MeshCollider)
9587a9c Default walletdir is wallets/ if it exists (MeshCollider)
d987889 Add release notes for -walletdir and wallets/ dir (MeshCollider)
80c5cbc Add test for -walletdir (MeshCollider)
0530ba0 Add -walletdir parameter to specify custom wallet dir (MeshCollider)

Pull request description:

  Closes #11348

  Adds a `-walletdir` parameter which specifies a directory to use for wallets, allowing them to be stored separately from the 'main' data directory. Creates a new `wallets/` directory in datadir if this is the first time running, and defaults to using it if it exists.

  Includes tests and release notes. Things which might need to be considered more:
  - there is no 'lock' on the wallets directory, which might be needed?
  - because this uses a new wallets/ directory by default, downgrading to an earlier version won't see the wallets in that directory (not a big deal though, users can just copy them up to the main dir)
  - jnewbery suggested putting each wallet in its own directory, which is a good idea, but out of scope for this PR IMO. EDIT: this is being done in https://github.com/bitcoin/bitcoin/pull/11687
  - doc/files.md needs updating (will do soon)

  I also considered including  a cleanup by removing caching of data directory paths and instead just initialise them once on startup (c.f. #3073), but decided it wasn't super relevant here will just complicate review.

Tree-SHA512: c8ac04bfe9a810c32055f2c8b8fa0d535e56125ceb8d96f12447dd3538bf3e5ee992b60b1cd2173bf5f3fa023a9feab12c9963593bf27ed419df929bb413398d
2017-11-18 14:41:15 +01:00
..
forms qt: refactor: Use absolute include paths in .ui files 2017-11-16 08:23:02 +13:00
locale qt: Periodic translations update 2017-08-09 12:04:41 +02:00
res [qt] Make network disabled icon 50% opaque 2016-11-13 22:06:35 +01:00
test qt: refactor: Changes to make include paths absolute 2017-11-16 08:23:02 +13:00
addressbookpage.cpp qt: refactor: Changes to make include paths absolute 2017-11-16 08:23:02 +13:00
addressbookpage.h Remove unnecessary forward class declarations in header files 2017-06-12 20:37:43 +02:00
addresstablemodel.cpp scripted-diff: Replace #include "" with #include <> (ryanofsky) 2017-11-16 08:23:01 +13:00
addresstablemodel.h Bump copyright headers to 2015 2015-12-13 18:08:39 +01:00
askpassphrasedialog.cpp qt: refactor: Changes to make include paths absolute 2017-11-16 08:23:02 +13:00
askpassphrasedialog.h [ui] Add toggle for unblinding password fields 2017-10-18 13:22:30 -07:00
bantablemodel.cpp scripted-diff: Replace #include "" with #include <> (ryanofsky) 2017-11-16 08:23:01 +13:00
bantablemodel.h scripted-diff: Replace #include "" with #include <> (ryanofsky) 2017-11-16 08:23:01 +13:00
bitcoin.cpp Create walletdir if datadir doesn't exist and fix tests 2017-11-18 00:50:59 +13:00
bitcoin.qrc Overhaul network activity toggle 2016-10-24 10:23:58 +00:00
bitcoin_locale.qrc qt: periodic translations update 2017-01-10 12:52:02 +01:00
bitcoinaddressvalidator.cpp scripted-diff: Replace #include "" with #include <> (ryanofsky) 2017-11-16 08:23:01 +13:00
bitcoinaddressvalidator.h
bitcoinamountfield.cpp qt: refactor: Changes to make include paths absolute 2017-11-16 08:23:02 +13:00
bitcoinamountfield.h scripted-diff: Replace #include "" with #include <> (ryanofsky) 2017-11-16 08:23:01 +13:00
bitcoingui.cpp scripted-diff: Replace #include "" with #include <> (ryanofsky) 2017-11-16 08:23:01 +13:00
bitcoingui.h scripted-diff: Replace #include "" with #include <> (ryanofsky) 2017-11-16 08:23:01 +13:00
bitcoinstrings.cpp qt: Periodic translations update 2017-07-31 12:19:05 +02:00
bitcoinunits.cpp scripted-diff: Replace #include "" with #include <> (ryanofsky) 2017-11-16 08:23:01 +13:00
bitcoinunits.h scripted-diff: Replace #include "" with #include <> (ryanofsky) 2017-11-16 08:23:01 +13:00
callback.h Declare single-argument (non-converting) constructors "explicit" 2017-08-16 16:33:25 +02:00
clientmodel.cpp scripted-diff: Replace #include "" with #include <> (ryanofsky) 2017-11-16 08:23:01 +13:00
clientmodel.h Remove unnecessary forward class declarations in header files 2017-06-12 20:37:43 +02:00
coincontroldialog.cpp qt: refactor: Changes to make include paths absolute 2017-11-16 08:23:02 +13:00
coincontroldialog.h scripted-diff: Replace #include "" with #include <> (ryanofsky) 2017-11-16 08:23:01 +13:00
coincontroltreewidget.cpp scripted-diff: Replace #include "" with #include <> (ryanofsky) 2017-11-16 08:23:01 +13:00
coincontroltreewidget.h Bump copyright headers to 2014 2016-01-05 21:01:39 +01:00
csvmodelwriter.cpp scripted-diff: Replace #include "" with #include <> (ryanofsky) 2017-11-16 08:23:01 +13:00
csvmodelwriter.h Bump copyright headers to 2014 2016-01-05 21:01:39 +01:00
editaddressdialog.cpp qt: refactor: Changes to make include paths absolute 2017-11-16 08:23:02 +13:00
editaddressdialog.h Bump copyright headers to 2015 2015-12-13 18:08:39 +01:00
guiconstants.h Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
guiutil.cpp scripted-diff: Replace #include "" with #include <> (ryanofsky) 2017-11-16 08:23:01 +13:00
guiutil.h scripted-diff: Replace #include "" with #include <> (ryanofsky) 2017-11-16 08:23:01 +13:00
intro.cpp Create walletdir if datadir doesn't exist and fix tests 2017-11-18 00:50:59 +13:00
intro.h Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
macdockiconhandler.h Bump copyright headers to 2015 2015-12-13 18:08:39 +01:00
macdockiconhandler.mm Document the preference of nullptr over NULL or (void*)0 2017-08-18 09:51:00 +02:00
macnotificationhandler.h [macOS] remove Growl support, remove unused code 2017-09-07 10:11:44 -07:00
macnotificationhandler.mm [macOS] remove Growl support, remove unused code 2017-09-07 10:11:44 -07:00
Makefile
modaloverlay.cpp qt: refactor: Changes to make include paths absolute 2017-11-16 08:23:02 +13:00
modaloverlay.h Add const to methods that do not modify the object for which it is called 2017-07-25 13:46:52 +02:00
networkstyle.cpp scripted-diff: Replace #include "" with #include <> (ryanofsky) 2017-11-16 08:23:01 +13:00
networkstyle.h
notificator.cpp scripted-diff: Replace #include "" with #include <> (ryanofsky) 2017-11-16 08:23:01 +13:00
notificator.h scripted-diff: Replace #include "" with #include <> (ryanofsky) 2017-11-16 08:23:01 +13:00
openuridialog.cpp qt: refactor: Changes to make include paths absolute 2017-11-16 08:23:02 +13:00
openuridialog.h Bump copyright headers to 2015 2015-12-13 18:08:39 +01:00
optionsdialog.cpp qt: refactor: Changes to make include paths absolute 2017-11-16 08:23:02 +13:00
optionsdialog.h Add a button to open the config file in a text editor 2017-03-23 12:54:36 -04:00
optionsmodel.cpp qt: refactor: Changes to make include paths absolute 2017-11-16 08:23:02 +13:00
optionsmodel.h scripted-diff: Replace #include "" with #include <> (ryanofsky) 2017-11-16 08:23:01 +13:00
overviewpage.cpp qt: refactor: Changes to make include paths absolute 2017-11-16 08:23:02 +13:00
overviewpage.h scripted-diff: Replace #include "" with #include <> (ryanofsky) 2017-11-16 08:23:01 +13:00
paymentrequest.proto Specify Protobuf version 2 in paymentrequest.proto 2016-09-16 11:45:08 +08:00
paymentrequestplus.cpp scripted-diff: Replace #include "" with #include <> (ryanofsky) 2017-11-16 08:23:01 +13:00
paymentrequestplus.h qt: refactor: Changes to make include paths absolute 2017-11-16 08:23:02 +13:00
paymentserver.cpp scripted-diff: Replace #include "" with #include <> (ryanofsky) 2017-11-16 08:23:01 +13:00
paymentserver.h scripted-diff: Replace #include "" with #include <> (ryanofsky) 2017-11-16 08:23:01 +13:00
peertablemodel.cpp scripted-diff: Replace #include "" with #include <> (ryanofsky) 2017-11-16 08:23:01 +13:00
peertablemodel.h scripted-diff: Replace #include "" with #include <> (ryanofsky) 2017-11-16 08:23:01 +13:00
platformstyle.cpp scripted-diff: Replace #include "" with #include <> (ryanofsky) 2017-11-16 08:23:01 +13:00
platformstyle.h qt: Introduce PlatformStyle 2015-07-31 09:35:18 +02:00
qvalidatedlineedit.cpp scripted-diff: Replace #include "" with #include <> (ryanofsky) 2017-11-16 08:23:01 +13:00
qvalidatedlineedit.h Bump copyright headers to 2015 2015-12-13 18:08:39 +01:00
qvaluecombobox.cpp scripted-diff: Replace #include "" with #include <> (ryanofsky) 2017-11-16 08:23:01 +13:00
qvaluecombobox.h Bump copyright headers to 2015 2015-12-13 18:08:39 +01:00
receivecoinsdialog.cpp qt: refactor: Changes to make include paths absolute 2017-11-16 08:23:02 +13:00
receivecoinsdialog.h scripted-diff: Replace #include "" with #include <> (ryanofsky) 2017-11-16 08:23:01 +13:00
receiverequestdialog.cpp qt: refactor: Changes to make include paths absolute 2017-11-16 08:23:02 +13:00
receiverequestdialog.h scripted-diff: Replace #include "" with #include <> (ryanofsky) 2017-11-16 08:23:01 +13:00
recentrequeststablemodel.cpp scripted-diff: Replace #include "" with #include <> (ryanofsky) 2017-11-16 08:23:01 +13:00
recentrequeststablemodel.h scripted-diff: Replace #include "" with #include <> (ryanofsky) 2017-11-16 08:23:01 +13:00
rpcconsole.cpp qt: refactor: Changes to make include paths absolute 2017-11-16 08:23:02 +13:00
rpcconsole.h scripted-diff: Replace #include "" with #include <> (ryanofsky) 2017-11-16 08:23:01 +13:00
sendcoinsdialog.cpp qt: refactor: Changes to make include paths absolute 2017-11-16 08:23:02 +13:00
sendcoinsdialog.h scripted-diff: Replace #include "" with #include <> (ryanofsky) 2017-11-16 08:23:01 +13:00
sendcoinsentry.cpp qt: refactor: Changes to make include paths absolute 2017-11-16 08:23:02 +13:00
sendcoinsentry.h scripted-diff: Replace #include "" with #include <> (ryanofsky) 2017-11-16 08:23:01 +13:00
signverifymessagedialog.cpp qt: refactor: Changes to make include paths absolute 2017-11-16 08:23:02 +13:00
signverifymessagedialog.h Bump copyright headers to 2015 2015-12-13 18:08:39 +01:00
splashscreen.cpp scripted-diff: Replace #include "" with #include <> (ryanofsky) 2017-11-16 08:23:01 +13:00
splashscreen.h Drop upgrade-cancel callback registration for a generic "resumeable" 2017-08-20 20:04:15 -04:00
trafficgraphwidget.cpp scripted-diff: Replace #include "" with #include <> (ryanofsky) 2017-11-16 08:23:01 +13:00
trafficgraphwidget.h Bump copyright headers to 2015 2015-12-13 18:08:39 +01:00
transactiondesc.cpp scripted-diff: Replace #include "" with #include <> (ryanofsky) 2017-11-16 08:23:01 +13:00
transactiondesc.h Bump copyright headers to 2014 2016-01-05 21:01:39 +01:00
transactiondescdialog.cpp qt: refactor: Changes to make include paths absolute 2017-11-16 08:23:02 +13:00
transactiondescdialog.h Bump copyright headers to 2014 2016-01-05 21:01:39 +01:00
transactionfilterproxy.cpp scripted-diff: Replace #include "" with #include <> (ryanofsky) 2017-11-16 08:23:01 +13:00
transactionfilterproxy.h scripted-diff: Replace #include "" with #include <> (ryanofsky) 2017-11-16 08:23:01 +13:00
transactionrecord.cpp scripted-diff: Replace #include "" with #include <> (ryanofsky) 2017-11-16 08:23:01 +13:00
transactionrecord.h scripted-diff: Replace #include "" with #include <> (ryanofsky) 2017-11-16 08:23:01 +13:00
transactiontablemodel.cpp scripted-diff: Replace #include "" with #include <> (ryanofsky) 2017-11-16 08:23:01 +13:00
transactiontablemodel.h scripted-diff: Replace #include "" with #include <> (ryanofsky) 2017-11-16 08:23:01 +13:00
transactionview.cpp scripted-diff: Replace #include "" with #include <> (ryanofsky) 2017-11-16 08:23:01 +13:00
transactionview.h scripted-diff: Replace #include "" with #include <> (ryanofsky) 2017-11-16 08:23:01 +13:00
utilitydialog.cpp qt: refactor: Changes to make include paths absolute 2017-11-16 08:23:02 +13:00
utilitydialog.h Declare single-argument (non-converting) constructors "explicit" 2017-08-16 16:33:25 +02:00
walletframe.cpp scripted-diff: Replace #include "" with #include <> (ryanofsky) 2017-11-16 08:23:01 +13:00
walletframe.h Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
walletmodel.cpp scripted-diff: Replace #include "" with #include <> (ryanofsky) 2017-11-16 08:23:01 +13:00
walletmodel.h scripted-diff: Replace #include "" with #include <> (ryanofsky) 2017-11-16 08:23:01 +13:00
walletmodeltransaction.cpp Merge #10920: [qt] Fix potential memory leak in newPossibleKey(ChangeCWallet *wallet) 2017-11-17 13:07:37 +01:00
walletmodeltransaction.h Merge #10920: [qt] Fix potential memory leak in newPossibleKey(ChangeCWallet *wallet) 2017-11-17 13:07:37 +01:00
walletview.cpp scripted-diff: Replace #include "" with #include <> (ryanofsky) 2017-11-16 08:23:01 +13:00
walletview.h scripted-diff: Replace #include "" with #include <> (ryanofsky) 2017-11-16 08:23:01 +13:00
winshutdownmonitor.cpp scripted-diff: Replace #include "" with #include <> (ryanofsky) 2017-11-16 08:23:01 +13:00
winshutdownmonitor.h