LBRYCommunity/spee.ch
1
0
Fork 0
Code Issues 95 Pull requests 2 Projects Releases 4 Packages Wiki Activity

Issue #533 - Lighter version of the show page #654

Merged
saniaio merged 50 commits from master into master 2018-11-12 18:40:49 +01:00
Conversation 3 Commits 50 Files changed 41 +855 -209
saniaio commented 2018-10-24 00:34:11 +02:00 (Migrated from github.com)
Copy link

New designs for the show page that allows the metadata and description to be tucked away. New layout means the published item takes up much more space, with all of the details stowed away underneath.
533_speech_revamp

New designs for the show page that allows the metadata and description to be tucked away. New layout means the published item takes up much more space, with all of the details stowed away underneath. ![533_speech_revamp](https://user-images.githubusercontent.com/38168355/47394738-e328f080-d71b-11e8-9145-896de913547d.png)
skhameneh (Migrated from github.com) reviewed 2018-10-25 03:05:33 +02:00
skhameneh (Migrated from github.com) left a comment
Copy link

Looks good so far, I'll need to test tomorrow, mostly minor comments, thanks!

Looks good so far, I'll need to test tomorrow, mostly minor comments, thanks!
client/scss/asset-display/_asset-display.scss
@ -1,22 +1,184 @@
.asset-display {
background: #F6F6F6;
skhameneh (Migrated from github.com) commented 2018-10-25 02:52:34 +02:00
Copy link

Use rgba(169, 173, 186, 0.2) as a SASS variable

Use ```rgba(169, 173, 186, 0.2)``` as a SASS variable
client/scss/asset-display/_asset-display.scss
@ -6,0 +10,4 @@
&:after {
background: transparent;
bottom: 0;
box-shadow: inset 0 1px 2px 2px $shadow-color;
skhameneh (Migrated from github.com) commented 2018-10-25 02:49:46 +02:00
Copy link

line break before

line break before
client/scss/asset-display/_asset-display.scss
@ -6,0 +14,4 @@
content: '';
height: 1px;
left: 0;
position: absolute;
skhameneh (Migrated from github.com) commented 2018-10-25 02:50:13 +02:00
Copy link

please order new style attributes alphabetically

please order new style attributes alphabetically
client/scss/asset-display/_asset-display.scss
@ -22,0 +76,4 @@
z-index: 100;
}
&:after {
skhameneh (Migrated from github.com) commented 2018-10-25 02:51:11 +02:00
Copy link

add line breaks before all selectors please

add line breaks before all selectors please
client/scss/icon/chevron-down.svg
@ -0,0 +1,9 @@
<?xml version="1.0" encoding="UTF-8"?>
<svg width="14px" height="8px" viewBox="0 0 14 8" version="1.1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink">
<!-- Generator: Sketch 52.2 (67145) - http://www.bohemiancoding.com/sketch -->
<title>chevron-down</title>
skhameneh (Migrated from github.com) commented 2018-10-25 02:58:53 +02:00
Copy link

Please remove extraneous code, you might want to check:
https://medium.com/sketch-app-sources/the-best-way-to-export-an-svg-from-sketch-dd8c66bb6ef2

Please remove extraneous code, you might want to check: https://medium.com/sketch-app-sources/the-best-way-to-export-an-svg-from-sketch-dd8c66bb6ef2
client/scss/share-buttons/_share-buttons.scss
skhameneh (Migrated from github.com) commented 2018-10-25 02:59:58 +02:00
Copy link

Fix indentation, we use 2 spaces for an indent.
Most editors should be able to autocorrect this for you

Fix indentation, we use 2 spaces for an indent. Most editors should be able to autocorrect this for you
client/src/components/VerticalCollapsibleSplit/index.jsx
@ -0,0 +19,4 @@
state,
} = this;
return (
skhameneh (Migrated from github.com) commented 2018-10-25 03:02:59 +02:00
Copy link

you can use this before your return to clear up your references, it also has faster faster lookup when they're local vars:

let {
  props,
  state
} = this;
you can use this before your ```return``` to clear up your references, it also has faster faster lookup when they're local vars: ``` let { props, state } = this; ```
client/src/pages/ShowAssetDetails/view.jsx
skhameneh (Migrated from github.com) commented 2018-10-25 03:04:20 +02:00
Copy link

Remove

Remove
public/assets/img/facebook.svg
@ -0,0 +1,16 @@
<?xml version="1.0" encoding="UTF-8"?>
skhameneh (Migrated from github.com) commented 2018-10-25 03:04:46 +02:00
Copy link

Clean up, see the other comment on SVG files

Clean up, see the other comment on SVG files
minesh93 (Migrated from github.com) reviewed 2018-10-25 21:18:15 +02:00
client/src/components/VerticalCollapsibleSplit/index.jsx
@ -0,0 +19,4 @@
state,
} = this;
return (
minesh93 (Migrated from github.com) commented 2018-10-25 21:18:15 +02:00
Copy link

Hi,
Could you elaborate on this?
I've just implemented this but this is throwing an es-lint warning as its stating that those variables are unused?

Hi, Could you elaborate on this? I've just implemented this but this is throwing an es-lint warning as its stating that those variables are unused?
skhameneh (Migrated from github.com) reviewed 2018-10-26 17:15:19 +02:00
client/src/components/VerticalCollapsibleSplit/index.jsx
@ -0,0 +19,4 @@
state,
} = this;
return (
skhameneh (Migrated from github.com) commented 2018-10-26 17:15:19 +02:00
Copy link
  render () {
    let {
      props,
      state,
    } = this;

    return (
      <div className={'vertical-split'}>
        <div className='visible-content' data-name={props.name}>
          {props.top}
          <button className='collapse-button' onClick={this.collapse}>
            {state.closed ? <Icon.PlusCircle className='plus-icon' />  : <Icon.MinusCircle /> }
          </button>
        </div>
        <div className='collapse-content' data-name={props.name}>
          {props.bottom}
        </div>
      </div>
    );
  }
``` render () { let { props, state, } = this; return ( <div className={'vertical-split'}> <div className='visible-content' data-name={props.name}> {props.top} <button className='collapse-button' onClick={this.collapse}> {state.closed ? <Icon.PlusCircle className='plus-icon' /> : <Icon.MinusCircle /> } </button> </div> <div className='collapse-content' data-name={props.name}> {props.bottom} </div> </div> ); } ```
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
area: devops

   
area: discovery

   
area: docs

   
area: livestream

   
area: proposal

Work is part of a proposal

  
consider soon

Discuss this issue at the next planning meeting, then remove this label

  
dependencies

Pull requests that update a dependency file

  
Epic

   
good first issue

   
hacktoberfest

Welcome to Hacktoberfest

  
help wanted

   
icebox

Long-term storage

  
level: 1

No knowledge of the existing code required

  
level: 2

Some knowledge of the existing code is recommended

  
level: 3

Significant knowledge of the existing code is recommended

  
level: 4

Intimate knowledge of the existing code is recommended

  
needs: exploration

Solution unclear, needs research

  
needs: grooming

Issue needs to be groomed before work can start

  
needs: priority

Priority level needs to be defined

  
needs: repro

Issue needs step-by-step instructions on how to reproduce in latest code

  
needs: tech design

Needs technical design signoff before implementation can begin

  
on hold

Temporarily paused

  
Osprey

Spee.ch special project

  
priority: blocker

Issue is blocking release, do ASAP

  
priority: high

Work needs to be moved into sprint ASAP

  
priority: low

Work should be done but can stay in the backlog for now

  
priority: medium

Work needs to be done within 2-3 sprints

  
protocol dependent

   
resilience

   
Tom's Wishlist

   
type: bug

Existing functionality is wrong or broken

  
type: discussion

A conversation. No specific changes requested

  
type: error handling

   
type: improvement

Existing (or partially existing) functionality needs to be changed

  
type: new feature

New functionality that does not exist yet

  
type: refactor

Minimal user-visible changes, but significant internal work

  
type: task

Either work that's not related to the code, or a small chore that does not fit into other categories

  
type: testing

Solution needs additional user testing

  
unplanned

Work that was not planned into the spirnt, took priority over planned work

No labels
area: devops
area: discovery
area: docs
area: livestream
area: proposal
consider soon
dependencies
Epic
good first issue
hacktoberfest
help wanted
icebox
level: 1
level: 2
level: 3
level: 4
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
on hold
Osprey
priority: blocker
priority: high
priority: low
priority: medium
protocol dependent
resilience
Tom's Wishlist
type: bug
type: discussion
type: error handling
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/spee.ch#654
No description provided.
Delete branch "master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?