LBRYCommunity/lbry-desktop
1
0
Fork 0
Code Issues 596 Pull requests 6 Projects Releases 238 Packages Wiki Activity

only call email provided event for real sign ups

Browse source
This commit is contained in:
Sean Yesmunt 2020-04-15 14:11:51 -04:00
parent bb22d4ba07
commit 3d6ed7b1ec
4 changed files with 11 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
package.json
View file

@ -130,8 +130,8 @@
"imagesloaded": "^4.1.4", "imagesloaded": "^4.1.4",
"json-loader": "^0.5.4", "json-loader": "^0.5.4",
"lbry-format": "https://github.com/lbryio/lbry-format.git", "lbry-format": "https://github.com/lbryio/lbry-format.git",
"lbry-redux": "lbryio/lbry-redux#df043f3ef6076b52cec11be76069e0c7c9c19e0a", "lbry-redux": "lbryio/lbry-redux#22c9e3563ead27a0250751b6d72a678cbbe60633",
"lbryinc": "lbryio/lbryinc#12aefaa14343d2f3eac01f2683701f58e53f1848", "lbryinc": "lbryio/lbryinc#11ebc51ab6156beb71d18494ed82e8da2e673ead",
"lint-staged": "^7.0.2", "lint-staged": "^7.0.2",
"localforage": "^1.7.1", "localforage": "^1.7.1",
"lodash-es": "^4.17.14", "lodash-es": "^4.17.14",

9
ui/component/userEmailNew/view.jsx
View file

@ -20,7 +20,7 @@ type Props = {
balance: number, balance: number,
daemonSettings: { share_usage_data: boolean }, daemonSettings: { share_usage_data: boolean },
setShareDiagnosticData: boolean => void, setShareDiagnosticData: boolean => void,
doSignUp: (string, ?string) => void, doSignUp: (string, ?string) => Promise<any>,
clearEmailEntry: () => void, clearEmailEntry: () => void,
}; };
@ -52,11 +52,12 @@ function UserEmailNew(props: Props) {
function handleSubmit() { function handleSubmit() {
setSync(formSyncEnabled); setSync(formSyncEnabled);
doSignUp(email, password === '' ? undefined : password);
// @if TARGET='app' // @if TARGET='app'
setShareDiagnosticData(true); setShareDiagnosticData(true);
// @endif // @endif
analytics.emailProvidedEvent(); doSignUp(email, password === '' ? undefined : password).then(() => {
analytics.emailProvidedEvent();
});
} }
function handleChangeToSignIn(additionalParams) { function handleChangeToSignIn(additionalParams) {
@ -87,7 +88,7 @@ function UserEmailNew(props: Props) {
return ( return (
<div className="main__sign-up"> <div className="main__sign-up">
<Card <Card
title={__('Join lbry.tv')} title={__('Register with lbry.tv')}
// @if TARGET='app' // @if TARGET='app'
subtitle={__('An account with lbry.tv allows you to earn rewards and backup your data.')} subtitle={__('An account with lbry.tv allows you to earn rewards and backup your data.')}
// @endif // @endif

2
ui/component/userEmailReturning/view.jsx
View file

@ -8,7 +8,6 @@ import { useHistory } from 'react-router-dom';
import UserEmailVerify from 'component/userEmailVerify'; import UserEmailVerify from 'component/userEmailVerify';
import Card from 'component/common/card'; import Card from 'component/common/card';
import Nag from 'component/common/nag'; import Nag from 'component/common/nag';
import analytics from 'analytics';
type Props = { type Props = {
errorMessage: ?string, errorMessage: ?string,
@ -32,7 +31,6 @@ function UserEmailReturning(props: Props) {
function handleSubmit() { function handleSubmit() {
doUserCheckIfEmailExists(email); doUserCheckIfEmailExists(email);
analytics.emailProvidedEvent();
} }
function handleChangeToSignIn() { function handleChangeToSignIn() {

8
yarn.lock
View file

@ -6139,17 +6139,17 @@ lazy-val@^1.0.4:
yargs "^13.2.2" yargs "^13.2.2"
zstd-codec "^0.1.1" zstd-codec "^0.1.1"
lbry-redux@lbryio/lbry-redux#df043f3ef6076b52cec11be76069e0c7c9c19e0a: lbry-redux@lbryio/lbry-redux#22c9e3563ead27a0250751b6d72a678cbbe60633:
version "0.0.1" version "0.0.1"
resolved "https://codeload.github.com/lbryio/lbry-redux/tar.gz/df043f3ef6076b52cec11be76069e0c7c9c19e0a" resolved "https://codeload.github.com/lbryio/lbry-redux/tar.gz/22c9e3563ead27a0250751b6d72a678cbbe60633"
dependencies: dependencies:
proxy-polyfill "0.1.6" proxy-polyfill "0.1.6"
reselect "^3.0.0" reselect "^3.0.0"
uuid "^3.3.2" uuid "^3.3.2"
lbryinc@lbryio/lbryinc#12aefaa14343d2f3eac01f2683701f58e53f1848: lbryinc@lbryio/lbryinc#11ebc51ab6156beb71d18494ed82e8da2e673ead:
version "0.0.1" version "0.0.1"
resolved "https://codeload.github.com/lbryio/lbryinc/tar.gz/12aefaa14343d2f3eac01f2683701f58e53f1848" resolved "https://codeload.github.com/lbryio/lbryinc/tar.gz/11ebc51ab6156beb71d18494ed82e8da2e673ead"
dependencies: dependencies:
reselect "^3.0.0" reselect "^3.0.0"