comment github action mac python hack

This commit is contained in:
zeppi 2022-11-17 13:19:16 -05:00
parent b332023bcc
commit 5f9ffd52d4

View file

@ -39,10 +39,16 @@ jobs:
if: startsWith(runner.os, 'mac') if: startsWith(runner.os, 'mac')
with: with:
xcode-version: '13.1.0' xcode-version: '13.1.0'
# This is gonna be hacky.
# Github made us upgrade xcode, which would force an upgrade of electron-builder to fix mac.
# But there were bugs with copyfiles / extraFiles that kept seeing duplicates erroring on ln.
# A flag USE_HARD_LINKS=false in electron-builder.json was suggested in comments, but that broke windows builds.
# So for now we'll install python2 on mac and make sure it can find it.
# Remove this after successfully upgrading electron-builder.
# HACK part 1
- uses: Homebrew/actions/setup-homebrew@master - uses: Homebrew/actions/setup-homebrew@master
if: startsWith(runner.os, 'mac') if: startsWith(runner.os, 'mac')
# HACK part 2
- name: Install Python2 - name: Install Python2
if: startsWith(runner.os, 'mac') if: startsWith(runner.os, 'mac')
run: | run: |