Commit graph

1866 commits

Author SHA1 Message Date
zeppi 0987c6e94f publish form recon 2021-07-23 10:14:22 -04:00
infinite-persistence ffad52d5b7 Remove console.log
Seems like lint is being bypassed recently?
2021-07-23 08:42:58 -04:00
infinite-persistence 7a8d213861
Eliminate CLS in Recommended due to wrapper mismatch
Seem like `type === small` was missed out, so it was using a wrapper than necessary, causing the shift.
2021-07-23 13:23:52 +08:00
zeppi 038431f95c channel follow first run on master 2021-07-23 00:00:32 -04:00
zeppi ed0387d94a pinning 2021-07-22 23:24:55 -04:00
zeppi d88752c646 music icon, fix lint 2021-07-22 17:31:46 -04:00
Anthony 78b4fa05b3 pull out variable for max and min fiat amounts 2021-07-22 14:06:59 -04:00
Anthony 7975ccf3e0 disable button if theres a fiat tip error 2021-07-22 14:06:59 -04:00
Anthony 713dc69ed7 add check for two decimals and fix showing error for fiat tip 2021-07-22 14:06:59 -04:00
zeppi f4559c1cce fileSubtitle recon 2021-07-22 12:09:54 -04:00
zeppi 8919182c0c default avatar config 2021-07-22 09:44:57 -04:00
infinite-persistence 032e17cecd
Improve CLS on Posts
## Issue
6068 Fix "Cumulative Layout Shift" for Core Web Vitals

In Posts, the Comments section appears first while we fetch the MD file. When the MD is fetched, Comments get pushed to the bottom (or shifted up for short posts), hence the red CLS scores.

## Approach
There are too many layers between `<FilePage>` and `<DocumentViewer>` to pass the `loading` state around to hide the Comments section, so just make Comments fade in after a 2s delay.

## Changes
- Posts: Add 2s fade-in delay to Comments.
- Posts: remove the gray placeholder. This improves the score a bit more, and reduces flicker as well. There's already a spinner from `FileRenderInline` to tell the user to be patient.
- Posts: add a minimum 30vh height so that short posts don't get collapsed too much, causing the `FileDetails` and Comments to shift. Small shifts are fine as long as CLS is below 0.1.
2021-07-22 10:38:01 +08:00
infinite-persistence 50c606d916 claimListDiscover: don't re-render until query is done
## Issue
6542 Livestream listing and blocked list kills CLS score

This is basically a repeat of what was done on `claimTileDiscover` (homepage), but now on `claimListDiscover` (category pages).

This handles the unnecessary re-render when:
- the uri list temporarily being zero while waiting for new claim-search results.
- livestream claim-search invalidating the list.

## Changes
Store the last uri list and use that when we know that claim-search is still not done.

## Tests
1. Ran Lighthouse on category pages (force a livestream channel on it). CLS score must be green.
2. Block `claim_search` from Dev Tools and move to another category. The page should say "timed out" instead of "no results" (i.e. maintain existing behavior).
2021-07-21 21:51:12 -04:00
zeppi 1994b5da04 guidelines optional in sidenav 2021-07-21 20:26:17 -04:00
zeppi fbf105e113 fileActions recon 2021-07-21 18:37:43 -04:00
zeppi 91b908ad50 pubfile copy 2021-07-21 16:18:46 -04:00
infinite-persistence 4fc6b89975 Fix reposted channels incorrectly showing the channel thumb
## Issue
6589

## Notes
`parseURI` will return `isChannel=false` due to the reposted channel URL not having the '@' symbol.

Since we already have the claim object, check `value_type` directly instead.
2021-07-21 14:41:47 -04:00
saltrafael b164a5d1f4 Pop up Menu Fixes and Improvements
Pop up Menu Fixes and Improvements

Improve re-directs

Fix file deletion

Improve code, and more

Fix List Layout collection popup

Allow to edit list

Fix blocking when not logged or no channel

Fix Edit and Delete showing for not owned Lists

Fix actions breaking when not logged in

Fix List options not showing

Lint

Shorten logic

Lint
2021-07-21 14:40:44 -04:00
zeppi fdca58727c restore paid content 2021-07-21 12:49:56 -04:00
zeppi 1600bb69b9 sms copy 2021-07-21 08:11:33 -04:00
infinite-persistence 6b2548cc49
Fix channel-selector thumbnail not updating
Recently changed to `<OptimizedImg>`, which was assuming the `src` never changes.

dejavu ... we also hit this issue when implementing the `IntersectionObserver` lazy-loading.
2021-07-21 16:38:54 +08:00
Dispatch e138673d27
Merge pull request #6508 from saltrafael/live_comments
Fix 'Recent Comments' button for livestreams
2021-07-20 12:33:52 -07:00
zeppi 283bbb52fa disable google imasdk 2021-07-20 15:12:14 -04:00
zeppi 8674b97be8 disable aniview 2021-07-20 15:12:14 -04:00
zeppi e4f1d4221b header notify recon 2021-07-20 12:32:17 -04:00
zeppi 8301244507 commentReactions recon ma 2021-07-20 11:17:44 -04:00
zeppi 27400cbe03 yt recon 2021-07-20 10:37:46 -04:00
zeppi e834a4aa51 change uploads copy 2021-07-20 10:33:48 -04:00
infinite-persistence 11b5eb49a0
Optimize ChannelThumbnail using the new method 2021-07-20 16:21:51 +08:00
infinite-persistence 68432eef26
OptimizedImage - wrapper for CDN-optimized image
Objective:
- Get appropriately sized images to improve performance and Core Vitals score.
- Ensure images using "objectFit=cover" doesn't get stretched out if the source is large enough.
- Peg to 100px increments for better caching.

Notes:
- Skip images hosted in '/public'. If we really want to optimize it, then we'll need to provide the full path in the code, otherwise CDN lookup will fail.
2021-07-20 16:21:50 +08:00
infinite-persistence 08738ffcee
Reaction-fetch: handle "deleted all channels"
- use `selectActiveChannelClaim` as that takes the current channel list into account (i.e. correct state when all channels are deleted).
    - `selectActiveChannelId` should probably be removed or not exposed through a selector, as it is not updated when channel list changes?
2021-07-20 15:22:50 +08:00
infinite-persistence c71e4718d0
Remove (revert) reaction-fetch hardstop
Root-cause is known, so removing it to detect other issues.
2021-07-20 15:22:49 +08:00
zeppi 4bf7c68574 use config for showTagsIntro 2021-07-19 22:46:43 -04:00
zeppi 765cef7564 recon notify components 2021-07-19 22:16:29 -04:00
zeppi 3dc7c35cd7 recon 2021-07-19 21:46:28 -04:00
zeppi f6dc48fdc0 use odysee recsys plugin 2021-07-19 17:30:44 -04:00
zeppi 26e67b375c more 2021-07-19 13:52:15 -04:00
zeppi 50875566ad more 2021-07-19 13:52:15 -04:00
Anthony fdfa2f1660 hotfix for bug 2021-07-19 11:08:59 -04:00
jessopb ae2354a0e0 Revert "move stuff to web (#6537)"
This reverts commit a6c413da5c.
2021-07-19 10:12:57 -04:00
infinite-persistence 6f4ce0a57c
Apply placeholder images
https://lbryians.slack.com/archives/C81FGKR51/p1624278721203900?thread_ts=1624269131.202200&cid=C81FGKR51

The intrinsic size needs to be at least equal the final image's size. Stretching, SVGs, etc. doesn't count.
2021-07-19 12:07:26 +08:00
zeppi e03325d0e4 remove old stripe setting 2021-07-18 22:30:12 -04:00
jessopb a6c413da5c
move stuff to web (#6537) 2021-07-18 21:57:36 -04:00
mayeaux 4fe17363f3
disable review button if no card saved also some cleanup (#6535)
* disable review button if no card saved also some cleanup

* fix flow errors
2021-07-18 21:49:21 -04:00
jessopb 5a04d0fea0
some recon (#6532) 2021-07-18 13:06:52 -04:00
zeppi dfc013d423 more recon 2021-07-18 11:27:05 -04:00
infinite-persistence 1fa7533ee3
Hide 'download' for livestreams
6517
2021-07-18 23:10:59 +08:00
infinite-persistence f3ed597ff6
i18n: Fix invalid template literal use + split strings 2021-07-18 22:42:21 +08:00
Anthony 6aea8e38bc fix css 2021-07-17 13:19:33 -04:00
zeppi 7ffd59c169 more lint 2021-07-17 13:19:33 -04:00