LBRYCommunity/lbry-desktop
1
0
Fork 0
Code Issues 596 Pull requests 6 Projects Releases 238 Packages Wiki Activity
lbry-desktop/ui/component
History
infinite-persistence 032e17cecd
Improve CLS on Posts 
## Issue
6068 Fix "Cumulative Layout Shift" for Core Web Vitals

In Posts, the Comments section appears first while we fetch the MD file. When the MD is fetched, Comments get pushed to the bottom (or shifted up for short posts), hence the red CLS scores.

## Approach
There are too many layers between `<FilePage>` and `<DocumentViewer>` to pass the `loading` state around to hide the Comments section, so just make Comments fade in after a 2s delay.

## Changes
- Posts: Add 2s fade-in delay to Comments.
- Posts: remove the gray placeholder. This improves the score a bit more, and reduces flicker as well. There's already a spinner from `FileRenderInline` to tell the user to be patient.
- Posts: add a minimum 30vh height so that short posts don't get collapsed too much, causing the `FileDetails` and Comments to shift. Small shifts are fine as long as CLS is below 0.1.
2021-07-22 10:38:01 +08:00
..
abandonedChannelPreview allow unsubscribe from deleted channels by navigating from sidebar 2021-04-30 11:06:34 -04:00
app render filedrop for only authenticated users (#6466) 2021-07-16 14:53:14 -04:00
autoplayCountdown wip 2021-06-08 13:25:52 -04:00
button clean 2021-06-18 10:57:19 -04:00
cardVerify updated code 2021-07-03 14:42:37 -04:00
channelAbout Only apply Staked Levels to Comments (allow it in Posts) 2021-04-09 11:27:07 -04:00
channelBlockButton Moderator Delegation GUI 2021-06-18 15:46:51 -04:00
channelContent more recon 2021-07-18 11:27:05 -04:00
channelDiscussion Restore comment pagination 2021-07-16 10:54:12 -04:00
channelEdit Rename default import/exports for clarity in text search (no functional change) 2021-07-09 08:40:26 +08:00
channelMuteButton Rename default import/exports for clarity in text search (no functional change) 2021-07-09 08:40:26 +08:00
channelSelector Rename default import/exports for clarity in text search (no functional change) 2021-07-09 08:40:26 +08:00
channelStakedIndicator Move getChannelLevel to a selector. Requires accompanying lbry-redux PR. 2021-03-12 10:38:16 -05:00
channelThumbnail Optimize ChannelThumbnail using the new method 2021-07-20 16:21:51 +08:00
channelTitle improve empty states 2020-03-19 12:12:19 -04:00
claimAbandonButton wip 2021-06-08 13:25:52 -04:00
claimAuthor wip 2021-06-08 13:25:52 -04:00
claimCollectionAdd i18n and various minor fixes 2021-06-17 17:05:24 +08:00
claimCollectionAddButton Rename default import/exports for clarity in text search (no functional change) 2021-07-09 08:40:26 +08:00
claimEffectiveAmount show loading while searching 2020-12-28 15:00:15 -05:00
claimInsufficientCredits new lbc icon 2020-09-29 17:12:32 -04:00
claimLink Revert lazy-loading videojs 2021-07-06 17:04:16 +08:00
claimList show currently active playing item on playlist: #6204 2021-07-16 10:58:40 -04:00
claimListDiscover claimListDiscover: don't re-render until query is done 2021-07-21 21:51:12 -04:00
claimListHeader wip 2021-06-08 13:25:52 -04:00
claimMenuList Pop up Menu Fixes and Improvements 2021-07-21 14:40:44 -04:00
claimPreview Pop up Menu Fixes and Improvements 2021-07-21 14:40:44 -04:00
claimPreviewSubtitle use new isLivestream (placeholder stream) selector 2021-03-25 20:14:24 -04:00
claimPreviewTile Fix reposted channels incorrectly showing the channel thumb 2021-07-21 14:41:47 -04:00
claimPreviewTitle cleanup 2020-03-19 12:12:19 -04:00
claimProperties wip 2021-06-08 13:25:52 -04:00
claimRepostAuthor add channel staked amount indicator on channel thumbnails 2021-02-18 01:14:39 -05:00
claimSupportButton String fix for 'Support Repost' 2021-01-21 14:31:31 -05:00
claimTags wip 2021-06-08 13:25:52 -04:00
claimTilesDiscover some recon (#6532) 2021-07-18 13:06:52 -04:00
claimType wip 2021-06-08 13:25:52 -04:00
claimUri bring in 'notifications' state from lbry-redux 2020-06-16 09:56:32 -04:00
collectionActions wip 2021-06-08 13:25:52 -04:00
collectionContentSidebar Playlist style fixes (#6509) 2021-07-16 15:13:28 -04:00
collectionEdit Rename default import/exports for clarity in text search (no functional change) 2021-07-09 08:40:26 +08:00
collectionMenuList Rename default import/exports for clarity in text search (no functional change) 2021-07-09 08:40:26 +08:00
collectionPreviewOverlay Rename default import/exports for clarity in text search (no functional change) 2021-07-09 08:40:26 +08:00
collectionPreviewTile thumbnail fix 2021-06-14 11:55:50 -04:00
collectionSelectItem Add watch later hover action and Favorites 2021-07-14 11:41:36 -04:00
collectionsListMine Add watch later hover action and Favorites 2021-07-14 11:41:36 -04:00
comment Reaction-fetch: handle "deleted all channels" 2021-07-20 15:22:50 +08:00
commentCreate disable review button if no card saved also some cleanup (#6535) 2021-07-18 21:49:21 -04:00
commentMenuList Restore comment pagination 2021-07-16 10:54:12 -04:00
commentReactions commentReactions recon ma 2021-07-20 11:17:44 -04:00
commentsList Reaction-fetch: handle "deleted all channels" 2021-07-20 15:22:50 +08:00
commentsReplies Don't show "comments disabled" while still fetching. 2021-07-17 12:09:42 +08:00
common fix css 2021-07-17 13:19:33 -04:00
copyableText Swap: Don't copy the currency, only amount (#5915) 2021-04-21 11:36:34 -04:00
creatorAnalytics fix upload button on creator analytics: #6323 2021-07-13 18:09:09 -04:00
dateTime DateTime: avoid unnecessary update (#6110) 2021-05-24 18:29:58 -04:00
emailCollection all settings constants come from redux 2020-07-27 11:53:14 -04:00
embedPlayButton Revert "Use blank poster and advisory when preview is blocked by insufficient stake." 2021-04-07 00:39:35 -04:00
embedTextArea add referral code to embed links 2020-10-07 16:23:53 -04:00
errorBoundary Don't lazy-load components in ErrorBoundary 2021-07-08 14:52:29 +08:00
expandable remove [data-mode='dark'] 2019-11-22 16:45:33 -05:00
fileActions fileActions recon 2021-07-21 18:37:43 -04:00
fileDescription wip 2021-06-08 13:25:52 -04:00
fileDetails wip 2021-06-08 13:25:52 -04:00
fileDownloadLink Move 'Download' and 'Report Content' into overflow menu. 2021-06-18 15:50:13 -04:00
fileDrop Add all proper react lifecycle hooks 2021-01-29 14:49:12 -05:00
filePrice new lbc icon 2020-09-29 17:12:32 -04:00
fileReactions wip 2021-06-08 13:25:52 -04:00
fileRender Fix invalid semicolon 2021-07-09 21:28:58 +08:00
fileRenderDownload Use sentence case for all card titles 2020-09-29 17:12:32 -04:00
fileRenderFloating fix colon handling 2021-07-15 17:48:02 -04:00
fileRenderInitiator Fix stuck video poster when switching videos 2021-06-26 01:05:23 +08:00
fileRenderInline Revert lazy-loading videojs 2021-07-06 17:04:16 +08:00
fileSubtitle trigger file/view event for livestream claims 2021-04-14 12:26:33 -04:00
fileThumbnail FileThumbnail: don't go through optimizer if GIF 2021-06-23 14:15:37 -04:00
fileTitle better posts styling 2021-03-11 14:12:59 -05:00
fileTitleSection use ENABLE_MATURE for fileTitleSection 2021-07-06 16:06:58 -04:00
fileType wip 2021-06-08 13:25:52 -04:00
fileValues Tip-unlock: add tooltip and related strings 2021-03-25 15:35:53 -04:00
fileViewCount some recon (#6532) 2021-07-18 13:06:52 -04:00
fileViewerEmbeddedTitle Add tooltip to embed's Title and Home button 2021-03-01 10:27:52 -05:00
fileWatchLaterLink i18n: Fix invalid template literal use + split strings 2021-07-18 22:42:21 +08:00
formFieldPrice refactor lbrytv web server 2019-11-11 13:27:29 -05:00
header header notify recon 2021-07-20 12:32:17 -04:00
hiddenNsfwClaims fix empty state when mature content is hidden 2019-12-14 02:28:47 -05:00
homepageSelector zh languages 2021-01-11 10:30:26 -05:00
i18nMessage Fix <i18nMessage> not localizing the message. 2020-05-25 10:18:08 -04:00
IframeReact re-enable pdfs on web 2021-04-05 15:06:56 -04:00
invited flow fixes 2020-12-16 10:52:22 -05:00
inviteList update app-strings 2020-10-08 13:15:22 -04:00
inviteNew wip 2021-06-08 13:25:52 -04:00
lastReleaseChanges prevent release notes from extending beyond height of app 2021-03-18 18:17:10 -04:00
livestreamComment Stripe 2 2021-07-17 13:19:33 -04:00
livestreamComments Merge pull request #6508 from saltrafael/live_comments 2021-07-20 12:33:52 -07:00
livestreamLayout use commentron for live view counts 2021-06-17 14:58:55 -04:00
livestreamLink recon 2021-07-19 21:46:28 -04:00
livestreamList Rename default import/exports for clarity in text search (no functional change) 2021-07-09 08:40:26 +08:00
loadingBarOneOff Use env for loading-bar color instead of hardcoded. 2021-06-29 21:01:14 +08:00
loginGraphic FileThumbnail: don't go through optimizer if GIF 2021-06-23 14:15:37 -04:00
markdownLink Rename default import/exports for clarity in text search (no functional change) 2021-07-09 08:40:26 +08:00
nagContinueFirstRun Rename default import/exports for clarity in text search (no functional change) 2021-07-09 08:40:26 +08:00
navigationButton Allow double-clicking in header to maximize the app. 2020-05-17 21:26:30 -07:00
navigationHistory remove [data-mode='dark'] 2019-11-22 16:45:33 -05:00
navigationHistoryItem cleanup css 2019-12-10 10:08:14 -05:00
navigationHistoryRecent refactor lbrytv web server 2019-11-11 13:27:29 -05:00
notification Skin fiat-tip notification 2021-07-08 11:21:58 +08:00
notificationBubble recon notify components 2021-07-19 22:16:29 -04:00
notificationContentChannelMenu Rename default import/exports for clarity in text search (no functional change) 2021-07-09 08:40:26 +08:00
notificationHeaderButton recon notify components 2021-07-19 22:16:29 -04:00
nudgeFloating move nudge to FileReactions and add src param to sign up redirects 2020-11-17 14:32:53 -05:00
optimizedImage Fix channel-selector thumbnail not updating 2021-07-21 16:38:54 +08:00
page Reload page when trying to open stale chunks 2021-07-08 15:06:09 +08:00
postEditor Markdown editor: Remove character limit 2021-03-21 21:00:16 -04:00
postViewer Improve CLS on Posts 2021-07-22 10:38:01 +08:00
previewLink CodeSplit: Initial work 2021-06-25 16:00:44 +08:00
previewOverlayProperties remove sub heart on collections 2021-06-16 13:01:30 -04:00
privacyAgreement call install/new after users select privacy options 2021-01-25 14:24:57 -05:00
publishAdditionalOptions Rename default import/exports for clarity in text search (no functional change) 2021-07-09 08:40:26 +08:00
publishBid refactor 'active' channel usage across the app 2021-02-11 10:45:34 -05:00
publishDescription moar alignment 2020-10-05 14:28:19 -04:00
publishFile pubfile copy 2021-07-21 16:18:46 -04:00
publishForm i18n update request from translators 2021-06-13 15:46:18 +08:00
publishFormErrors Propagate thumbnail errors to PublishFormData 2021-04-26 12:24:19 -04:00
publishName More recon (#6400) 2021-07-05 17:45:20 -04:00
publishPending add spinner to web upload message and fix double card issue 2020-09-29 17:12:32 -04:00
publishPrice new lbc icon 2020-09-29 17:12:32 -04:00
publishReleaseDate i18n update request from translators 2021-06-13 15:46:18 +08:00
publishSettings Add SETTINGS.ENABLE_PUBLISH_PREVIEW 2020-10-02 10:25:17 -04:00
recommendedContent Rename default import/exports for clarity in text search (no functional change) 2021-07-09 08:40:26 +08:00
reportContent remove emojis from reporting (#6042) 2021-05-12 10:19:45 -04:00
repostCreate More recon (#6400) 2021-07-05 17:45:20 -04:00
rewardAuthIntro add youtube sync to first run 2020-09-29 17:12:32 -04:00
rewardLink fix incorrect aria-label in rewards page 2021-07-13 18:09:09 -04:00
rewardListClaimed table alignment fixes 2020-09-29 17:12:32 -04:00
rewardSummary Use sentence case for all card titles 2020-09-29 17:12:32 -04:00
rewardTile i18n: Reward cards 2021-03-19 11:27:10 -04:00
rewardTotal new lbc icon 2020-09-29 17:12:32 -04:00
router Revert "move stuff to web (#6537)" 2021-07-19 10:12:57 -04:00
searchOptions Remove unused items 2021-07-14 11:13:13 +08:00
searchTopClaim i18n: missing translation + emoji fixes 2021-03-29 15:50:21 -04:00
selectAsset small i18n fixes 2021-06-18 19:08:08 -04:00
selectChannel refactor 'active' channel usage across the app 2021-02-11 10:45:34 -05:00
selectThumbnail Recon 7 6 b (#6418) 2021-07-07 14:21:11 -04:00
settingAccountPassword settings use null when matching current browser language 2020-11-23 14:12:31 -05:00
settingAutoLaunch settings use null when matching current browser language 2020-11-23 14:12:31 -05:00
settingClosingBehavior Add app closing behavior setting 2020-08-20 01:16:11 -04:00
settingLanguage i18n: Added missing state handling for RTL languages (#6275) 2021-07-16 13:51:08 -04:00
settingWalletServer all settings constants come from redux 2020-07-27 11:53:14 -04:00
shareButton bring in 'notifications' state from lbry-redux 2020-06-16 09:56:32 -04:00
sideNavigation guidelines optional in sidenav 2021-07-21 20:26:17 -04:00
snackBar use LbcMessage on snackbars 2020-09-29 17:12:32 -04:00
socialShare forbid playlist embed in share 2021-06-16 16:03:08 -04:00
spinner refactor floatingUri to allow inline players in comments/markdown 2020-10-21 15:29:29 -04:00
splash status -> wallet_status on wallet_status call 2021-03-15 16:19:13 -04:00
subscribeButton Fix notification bell toast 2021-07-12 11:03:11 -04:00
supportsLiquidate new lbc icon 2020-09-29 17:12:32 -04:00
syncEnableFlow settings use null when matching current browser language 2020-11-23 14:12:31 -05:00
syncFatalError ensure lbrytv api status is web only 2021-03-16 22:19:03 -04:00
syncPassword More master reconciliation 2021-04-27 23:05:38 -04:00
syncToggle settings use null when matching current browser language 2020-11-23 14:12:31 -05:00
tag Tag: Add "type=flow" that reflows to multiline with gaps. 2020-10-02 10:25:17 -04:00
tagsSearch Moderator Delegation GUI 2021-06-18 15:46:51 -04:00
tagsSelect sync reducer stuff 2020-10-27 10:17:11 -04:00
theme flow fixes 2020-12-16 10:52:22 -05:00
thumbnailPicker i18n and various minor fixes 2021-06-17 17:05:24 +08:00
transactionListTable wip 2021-06-08 13:25:52 -04:00
transactionListTableItem display signing channel for tips 2021-03-08 12:31:19 -05:00
txoList Re-add ability to export transactions (#5899) 2021-04-23 12:10:37 -04:00
uriIndicator add helplbrysavecrypto prompt and fix file page UI bugs 2021-04-04 23:32:47 -04:00
userChannelFollowIntro discover channelIds from homepages 2021-07-16 18:31:48 -04:00
userEmail Use sentence case for all card titles 2020-09-29 17:12:32 -04:00
userEmailNew enable sign up in desktop 2021-06-26 11:56:32 -04:00
userEmailReturning Add sign-in graphics for SIMPLE_SITE 2021-05-27 14:21:16 +08:00
userEmailVerify More master reconciliation 2021-04-27 23:05:38 -04:00
userFirstChannel record channel in analytics on first run 2020-11-30 11:50:26 -05:00
userPasswordReset Use sentence case for all card titles 2020-09-29 17:12:32 -04:00
userPasswordSet Use sentence case for all card titles 2020-09-29 17:12:32 -04:00
userPhoneNew Use sentence case for all card titles 2020-09-29 17:12:32 -04:00
userPhoneVerify More master reconciliation 2021-04-27 23:05:38 -04:00
userSignIn sync changes 2020-09-10 14:20:02 -04:00
userSignInPassword Add SITE_HELP_EMAIL in strings to ease Odysee string merge and maintenance. 2021-03-08 11:33:33 -05:00
userSignOutButton add user + rewards redux code from lbryinc 2020-06-16 09:56:32 -04:00
userSignUp use config for showTagsIntro 2021-07-19 22:46:43 -04:00
userTagFollowIntro sync reducer stuff 2020-10-27 10:17:11 -04:00
userVerify sms copy 2021-07-21 08:11:33 -04:00
videoDuration refactor lbrytv web server 2019-11-11 13:27:29 -05:00
viewers Improve CLS on Posts 2021-07-22 10:38:01 +08:00
walletAddress ReceiveLBC: switch from Modal to Page 2021-04-13 14:02:25 -04:00
walletBackup rc fixes for electron 9 2020-10-15 19:06:47 -04:00
walletBalance i18n - fiat 2021-07-06 14:53:23 -04:00
walletSend i18n update 2021-06-01 13:33:58 -04:00
walletSendTip hotfix for bug 2021-07-19 11:08:59 -04:00
walletSpendableBalanceHelp lint 2021-07-17 13:19:33 -04:00
walletSwap i18n update (#6039) 2021-05-15 02:01:00 -04:00
walletTipAmountSelector disable review button if no card saved also some cleanup (#6535) 2021-07-18 21:49:21 -04:00
webUploadList change uploads copy 2021-07-20 10:33:48 -04:00
wunderbar Reload page when trying to open stale chunks 2021-07-08 15:06:09 +08:00
wunderbarSuggestion ChannelThumbnail improvements 2021-07-05 16:04:10 +08:00
wunderbarSuggestions Remove unused items 2021-07-14 11:13:13 +08:00
wunderbarTopSuggestion cleanup 2020-12-03 16:18:04 -05:00
youtubeBadge move youtube badge to 'channel about' section 2020-10-06 16:30:03 -04:00
youtubeTransferStatus yt recon 2021-07-20 10:37:46 -04:00
yrbl winning claim style pass 2020-12-16 14:58:30 -05:00
yrblWalletEmpty Combine Buy and Swap 2021-06-05 10:07:38 +08:00
zoomableImage Zoomable image viewer in Markdown (posts and comments) 2021-01-27 10:06:31 -05:00