Commit graph

6 commits

Author SHA1 Message Date
Sean Yesmunt
d71f977a55 Revert "Remove hack in Timestamp parser now that 'remark-breaks' has addressed the original problem."
This reverts commit 02792b8f0c.
2021-02-20 18:23:52 -05:00
infiinte-persistence
02792b8f0c Remove hack in Timestamp parser now that 'remark-breaks' has addressed the original problem.
## Issue
Closes 5523: timestamps not interpreted in some cases

## Notes
`remark-breaks` previously kept repeating the same index in the loop, causing some corner-cases to be parsed oddly. I added code to address that.

Later, `remark-breaks` fixed the problem and we recently just bumped up the componnent version. My hack is no longer necesary.
2021-02-16 17:11:07 -05:00
infiinte-persistence
267c019d7a Timestamp: Handle Safari + better parsing
## Issue
- The previous regex uses lookback (I think ES2018?) which Safari has yet to implement.
- There were a few bugs in the previous regex too, like missing out multiple timestamps in a line, or parsing "62:02" as "2:02" (although YT does this as well).
- The previous method searched too deep (matchAll) on each 'locate' call, which was wasteful.
2020-12-18 11:35:47 -05:00
infiinte-persistence
897128a168 Restore "Handle timestamp in Markdown."
This reverts the revertion in:
- 85f8965d44.
- d3f0e471e5.
2020-12-18 11:35:47 -05:00
Sean Yesmunt
d3f0e471e5 Revert "Tokenize and format timestamps in Markdown"
This reverts commit 93709fbeb8.
2020-12-14 22:31:18 -05:00
infiinte-persistence
93709fbeb8 Tokenize and format timestamps in Markdown
1. Find and tokenize timestamps, i.e. "XX:XX:XX" strings.
2. Transform 'timestamp' nodes to Links.
2020-12-14 12:12:50 -05:00