Commit graph

24 commits

Author SHA1 Message Date
infinite-persistence 2a6df18b72
ChannelThumbnail fixes (#6075)
* Restore "use cdn for channel thumbnails"

This reverts commit e7adc607fa.

* ChannelThumbnail: disable optimization in Channel Page and for GIFs

## Issue
5564: Don't use optimized URLs on channel pages (profile/banner)

## Notes
This is not the best/full solution yet, but it is better than what we have to today (one step in the right direction).

Optimized channel thumbnail size is currently hardcoded to a lowest common denominator.
- Pro(s):
  - For images used in multiple places (different sizes) in a page, the total time needed to get the optimized version for each size is too much. Also, the optimizer seems to increase the size of the image in some cases. So, getting 1 image and re-using it is faster for this scenario.
  - Simpler code (no need to mount first -> get dimension -> load image)
- Cons:
  - We aren't fully optimizing the size, so not really addressing Core Web Vitals score problem.
    - e.g. in the front page, we could have used a smaller image for the channel thumbnails.
  - We haven't address the problem with large screen sizes.

* Restore channel selector

This reverts b5cc0bb42d

* ChannelThumbnail: fix lazy-loading

- Closes 6066: Revisit lazy-loading Channel thumbnails
- Properly fixes 5933: Thumbnail lazy-load causes ChannelSelector icon to not update.
    - Add effect-dependency on `channelThumbnail` and `thumbError`.
- Really perform the lazy-loading now.
    - `data-src` was not used, so it wasn't actually lazy loading previously.
2021-05-17 15:51:21 -04:00
Sean Yesmunt 6d89f0df7e hyperchats 2021-04-23 16:20:17 -04:00
infinite-persistence b5cc0bb42d Disable thumbnail lazy-load for Channels
## Issue
5933: Thumbnail lazy-load causes ChannelSelector icon to not update
2021-04-23 00:23:36 -04:00
Sean Yesmunt e4a3e54613 move lazy loading effect into effects/ 2021-04-14 15:25:19 -04:00
Louis Sandoval a7cb0e240e Fix #5795 - Claim images not lazy loaded 2021-04-14 15:25:19 -04:00
infinite-persistence e7adc607fa Revert "use cdn for channel thumbnails"
This reverts commit b231b1a51f.

## Issue
5564: Don't use optimized URLs on channel pages (profile/banner)
2021-02-23 12:53:16 -05:00
Sean Yesmunt b231b1a51f use cdn for channel thumbnails 2021-02-18 17:24:31 -05:00
Sean Yesmunt 09b689ba1c add channel staked amount indicator on channel thumbnails 2021-02-18 01:14:39 -05:00
Franco Montenegro 77d90b807e Display default image for channel thumbnail on error 2021-01-29 14:50:36 -05:00
Sean Yesmunt 9801f43d3e hack together a thumbnail message on the channel page 2020-11-19 13:33:37 -05:00
Sean Yesmunt 788fd153da fix thumbnail gifs in comments 2020-10-21 16:45:43 -04:00
Sean Yesmunt 5ac404c01a comment cleanup 2020-09-29 17:12:32 -04:00
Sean Yesmunt 90327a72ed add comments behind a flag 2020-07-23 11:03:00 -04:00
Sean Yesmunt 259f51abd6 style pass for channel edit
clean up sections and improve navigation handling

cleanup + image upload modal styling
2020-07-01 22:04:23 -04:00
jessop 91662a9d57 force https thumbs or handle img src error 2020-06-08 09:42:19 -04:00
Sean Yesmunt 85ec35f246 pause gifs until hover round 2 2020-05-28 13:07:51 -04:00
Sean Yesmunt 06f71f2f0d Revert "pause gifs until hover"
This reverts commit e97a03c5c9.
2020-05-28 12:31:45 -04:00
Sean Yesmunt e97a03c5c9 pause gifs until hover 2020-05-28 11:39:39 -04:00
Sean Yesmunt 8a9a79720b add aria-label and alt messages 2020-01-30 15:56:54 -05:00
Jeremy Kauffman b374e94710 fix small channel image previews 2019-12-09 10:19:49 -05:00
Sean Yesmunt 01a45e00bb clean up styles 2019-12-04 13:24:57 -05:00
Oleg Silkin 6018429e68 Adds thumbnail support for default, null-valued thumbnails 2019-12-04 13:24:57 -05:00
Sean Yesmunt 15815e5071 remove [data-mode='dark'] 2019-11-22 16:45:33 -05:00
Sean Yesmunt 6ad31a3ce9 refactor lbrytv web server 2019-11-11 13:27:29 -05:00