ChannelThumbnail fixes #6075

Merged

infinite-persistence merged 4 commits from ip/reenable-channel-thumbnail-optimization into master

2021-05-17 21:51:21 +02:00

infinite-persistence commented

2021-05-17 05:43:53 +02:00

(Migrated from github.com)

Disable optimization in Channel Page and for GIFs

Closes #6067 ChannelThumbnails: revisit image optimization
Better attempt for #5564 Don't use optimized URLs on channel pages (profile/banner)

Notes

This is not the best/full solution yet, but it is better than what we have to today (one step in the right direction). The main page should load faster now.

Changes:

Re-enabled optimization for ChannelThumbnail, but disable it for the avatar in Channel Page and also if it's a GIF.

Remaining problem

Optimized channel thumbnail size is currently hardcoded to a lowest common denominator. Filed as #6074 Get exact optimized thumbnail sizes instead of hardcoded to lowest denominator

ChannelThumbnail: fix lazy-loading

Closes #6066: Revisit lazy-loading Channel thumbnails.
Properly fixes #5933: Thumbnail lazy-load causes ChannelSelector icon to not update.
- Add effect-dependency on channelThumbnail and thumbError.
Really perform the lazy-loading now.
- data-src was not used, so it wasn't actually lazy loading previously.

# Disable optimization in Channel Page and for GIFs - Closes #6067 `ChannelThumbnails: revisit image optimization` - Better attempt for #5564 `Don't use optimized URLs on channel pages (profile/banner)` ### Notes This is not the best/full solution yet, but it is better than what we have to today (one step in the right direction). The main page should load faster now. Changes: - Re-enabled optimization for `ChannelThumbnail`, but disable it for the avatar in Channel Page and also if it's a GIF. ### Remaining problem Optimized channel thumbnail size is currently hardcoded to a lowest common denominator. Filed as #6074 `Get exact optimized thumbnail sizes instead of hardcoded to lowest denominator` # ChannelThumbnail: fix lazy-loading - Closes #6066: `Revisit lazy-loading Channel thumbnails`. - Properly fixes #5933: `Thumbnail lazy-load causes ChannelSelector icon to not update`. - Add effect-dependency on `channelThumbnail` and `thumbError`. - Really perform the lazy-loading now. - `data-src` was not used, so it wasn't actually lazy loading previously.

tzarebczan (Migrated from github.com) reviewed 2021-05-17 05:43:53 +02:00