LBRYCommunity/lbry-desktop
1
0
Fork 0
Code Issues 596 Pull requests 6 Projects Releases 238 Packages Wiki Activity
8357 commits 144 branches 725 tags 262 MiB
Commit graph

2741 commits

Author SHA1 Message Date
jessop
b5dccced6d bugfix 2020-09-10 14:20:02 -04:00
jessop
6c4842a111 sync changes 2020-09-10 14:20:02 -04:00
ioancole
bb9bde1c19 Encode automplete search string and don't autocomplete for empty query 2020-09-10 13:36:33 -04:00
ioancole
055a476d2f Hide search page URI header for invalid channel/stream name 2020-09-10 13:36:33 -04:00
ioancole
4add1f7200 Refactor wunderbar index/view and encode search query 2020-09-10 13:36:33 -04:00
Sean Yesmunt
c80b28ade9 Revert "Hiding URIs header for invalid URIs" 
This reverts commit 8f407a36d4.
 2020-09-10 11:30:55 -04:00
Sean Yesmunt
80707a37df Revert "Refactor wunderbar index/view and encode search query" 
This reverts commit 323ab43889.
 2020-09-10 11:30:55 -04:00
Sean Yesmunt
813ef0e960 Revert "Encode autocomplete search query" 
This reverts commit 7f8d084fa4.
 2020-09-10 11:30:55 -04:00
Sean Yesmunt
cb0918726e Revert "Don't autocomplete for empty string search" 
This reverts commit 72187ca51e.
 2020-09-10 11:30:55 -04:00
ioancole
72187ca51e Don't autocomplete for empty string search 2020-09-10 11:08:22 -04:00
ioancole
7f8d084fa4 Encode autocomplete search query 2020-09-10 11:08:22 -04:00
ioancole
323ab43889 Refactor wunderbar index/view and encode search query 2020-09-10 11:08:22 -04:00
ioancole
8f407a36d4 Hiding URIs header for invalid URIs 2020-09-10 11:08:22 -04:00
infiinte-persistence
e784107a0b FloatingPlayer: Stay within screen when window is resized 
## Issue
4741: `Pop out player disappears or is cut off`

## Approach:
- When dragging stops, determine the location of the floating player with respect to the main window in terms of percentage.
- When window is resized, roughly re-position based on the stored percentage.
 2020-09-10 11:06:35 -04:00
infiinte-persistence
ddfc2a54b8 FloatingPlayer: Minor function-renaming for clarity 2020-09-10 11:06:35 -04:00
infiinte-persistence
8e76fee162 String: Usual updates 2020-09-10 11:06:35 -04:00
Sean Yesmunt
bba539f846 Revert "Revert "add logging of player point of presence"" 
This reverts commit 4067e1ffd8.
 2020-09-09 14:55:16 -04:00
Sean Yesmunt
799c0c1f11 quick comment fix while waiting for release branch to be merged into master 2020-09-09 14:54:29 -04:00
Sean Yesmunt
4067e1ffd8 Revert "add logging of player point of presence" 
This reverts commit fb142f7699.
 2020-09-09 14:40:43 -04:00
Jeremy Kauffman
fb142f7699 add logging of player point of presence 2020-09-09 10:48:15 -04:00
jessop
f04cebd7b5 custom share domain defaults to url 2020-09-08 15:09:21 -04:00
infiinte-persistence
dd73e4a164 Translator-found missing strings 2020-09-08 12:17:38 -04:00
infiinte-persistence
202269ebeb Web: Fix 'Download' not triggering until second attempt 
## Issue
4669: `Download doesn't trigger on web until 2nd attempt`

The issue only happens when _Autoplay_ is disabled in the User Settings and the video hasn't been loaded when _Download_ is clicked.

The following code:
   `if (didClickDownloadButton && streamingUrl)`
didn't triggered because:
1. `streamingUrl` has not resolved yet when the Effect ran.
2. When it did resolve, the parent component was also notified and unmounted things, causing `didClickDownloadButton` to reset.

## Approach
Avoid the unnecessary unmounting by not using a conditional section wrapper within a return statement. React probably couldn't do the diffs when the conditional is at a section level.
 2020-09-04 11:52:38 -04:00
infiinte-persistence
d1db6fb3b3 Block Toast untranslated strings 2020-09-04 11:51:31 -04:00
infiinte-persistence
7edd9f7c92 Fix partially untranslated text in the Upgrade Modal 
## Issue
- "See the" was not encapsulated with the translation macro.
- Split-strings are not translatable for some languages.

## Change
Combine the entire sentence into a single string with variable.
 2020-09-04 11:51:31 -04:00
infiinte-persistence
a0df0a0e0a Sidebar: Bring back the "Followed Tags" list 
## Issue
4708: Bring back tag list in side bar when Tags view selected

## Approach
- Instead of displaying either Channels or Tags, both will now be displayed.
- The tags will simply be a the same button component as the "channels", but with a "#" prefix. This simplifies the CSS-side changes, and looks better overall as well.
 2020-09-04 11:50:02 -04:00
Mark Beamer Jr
6485e1af82 Add lbry apis to config 2020-09-03 12:58:29 -04:00
Sean Yesmunt
404f0dc195 fix first comment on post failing even when it is created successfully 2020-09-01 20:27:52 -04:00
Thomas Zarebczan
20f932f935 add comment stats to creator analytics 
+ fix up other minor issues and added weekly change figure to recent content

app strings
 2020-08-31 14:34:41 -04:00
jessop
ee217404da provide share domain url configuration 2020-08-31 11:51:25 -04:00
ioan.cole
254a2f5138 Refactor search.js 
Calling 'normalizeURI' then 'parseURI' needlessly runs the 'parseURI' function twice. This is a better way of doing it.
 2020-08-31 11:25:32 -04:00
ioancole
3f598f76d1 Fix search suggestions 'View Channel' Bug 2020-08-31 11:25:32 -04:00
jessopb
3a69f47347
quick fix for sync (#4718) 2020-08-28 11:25:47 -04:00
Sean Yesmunt
df9a19a9b4 always send integers to buffer api 2020-08-27 14:18:45 -04:00
infiinte-persistence
2e1d7fde1a Fix floating player being paused after dragging. 
## Issue
Fixes 4709 `Dragging floating player via video section pauses video`

## Changes
Don't propagate the key-up action if the window was dragged. Hopefully there isn't another sub-component that relies on the action being propagated.

## Note
If you drag at exactly the "Play" icon the control bar, the issue still happens.
 2020-08-27 13:59:25 -04:00
infiinte-persistence
de780a1fd8 Remove strings with trailing spaces as it's not obvious in Transifex. 
## Issue
Fixes 4665 `Translated strings with trailing spaces not shown correctly`

## Changes
While there are other strings with trailing spaces, "Trending for " was the only one that mattered. The rest are standalone paragragphs or used in a single line, so it doesn't matter if the translation included the space or not.
 2020-08-27 13:58:44 -04:00
Sean Yesmunt
6377dc86e0 fix side navigation scroll behavior on mobile 2020-08-26 11:01:33 -04:00
jessop
4a86d25891 fix react dom warning passing hideForUnauth 2020-08-26 10:25:36 -04:00
Sean Yesmunt
bae146205c fix card width on rewards page 2020-08-25 14:07:12 -04:00
Sean Yesmunt
23dfddefa1 fix extra padding on unseen notifications 2020-08-25 12:25:25 -04:00
Sean Yesmunt
a28ce2d3b8 pass 'only_if_expired: true' so clicking 'resend link' doesn't expire old tokens 2020-08-25 12:25:25 -04:00
Sean Yesmunt
4035c18f8e Publishes => Uploads 2020-08-25 12:25:25 -04:00
Sean Yesmunt
b9fd01d7b3 fix 'Related' title size on small/medium screens 2020-08-25 12:25:25 -04:00
Sean Yesmunt
22586c802c revert redirect after signin until we can signin users from verfication token 2020-08-25 12:25:25 -04:00
jessop
c78e1e2970 patch null blocked error 2020-08-25 09:53:22 -04:00
btzr-io
353c57a568 fix #4686 2020-08-25 09:51:13 -04:00
Jeremy Kauffman
f201039772
copy changes made on call 2020-08-24 18:23:38 -04:00
Thomas Zarebczan
a1f5292e57
Increase polling interval (makes app lag) 2020-08-24 16:08:14 -04:00
Jeremy Kauffman
aff2ddd04d
adjust account validation text 2020-08-24 15:39:59 -04:00
Sean Yesmunt
9ee4b256fb add mark as seen to notifications 2020-08-21 16:04:27 -04:00
sanabhass
2ae3484363 Support for auto-detection of direction for component with varying content 2020-08-21 11:50:40 -04:00
Sean Yesmunt
cf98e65a3f redirect to homepage after signing in 2020-08-21 11:47:41 -04:00
Sean Yesmunt
e0e33eb148 additional copy changes 2020-08-21 11:47:41 -04:00
Sean Yesmunt
7e35de3760 Register => Sign Up 2020-08-21 11:47:41 -04:00
Sean Yesmunt
764af3a5db wrap IS_MAC statements inside app ifdef 2020-08-21 11:47:41 -04:00
Sean Yesmunt
ea2d040c22 increase side nav width and give extra bottom padding to deal with link preview 2020-08-20 22:33:13 -04:00
Sean Yesmunt
b688fc1cc0 use 'Library' label instead of 'Purchased' on desktop 2020-08-20 22:33:13 -04:00
Sean Yesmunt
3ca847ece3 show lbry link on share dialog for channels 2020-08-20 22:33:13 -04:00
Sean Yesmunt
082ee187da hide side navigation scrollbar until hover 2020-08-20 22:33:13 -04:00
Sean Yesmunt
7b23126379 fix side navigation on mac 
mac has an extra header height to handle the top level menu buttons
 2020-08-20 22:33:13 -04:00
Sean Yesmunt
fd778adf99 remove 2020protests from the homepage 2020-08-20 11:31:35 -04:00
Sean Yesmunt
84084a7c41 use limit_claims_per_channel on homepage 2020-08-20 11:31:35 -04:00
Sean Yesmunt
17feef93df add back sign out link on mobile 2020-08-20 11:14:51 -04:00
Sean Yesmunt
4ebb463508 add back sign in link on desktop 2020-08-20 11:14:51 -04:00
Sean Yesmunt
33d47d1d6d default sync to false on desktop 2020-08-20 01:38:48 -04:00
Sean Yesmunt
cc1a8ca4e8 fix navigation button spacing 2020-08-20 01:38:48 -04:00
Franco Montenegro
cbfed97853 Add app closing behavior setting 2020-08-20 01:16:11 -04:00
Sean Yesmunt
005cf1d52b fix url creation typo 2020-08-19 17:40:12 -04:00
Sean Yesmunt
6ca0796c8a handle google webcache urls 2020-08-19 17:28:08 -04:00
Sean Yesmunt
f5de744641 only show notification bubble in menu button on mobile 2020-08-19 12:50:12 -04:00
Sean Yesmunt
c0053a772b fix mobile video alignment 2020-08-19 10:02:00 -04:00
Sean Yesmunt
3b4ac976b6 Revert "full width homepage" 
This reverts commit 0018fdaebc.
 2020-08-18 12:53:07 -04:00
Sean Yesmunt
36067417f5 Revert "move click listener to app only for external links" 
This reverts commit b58c9709e2.
 2020-08-18 12:53:07 -04:00
Sean Yesmunt
f688402748 align page contents with header width 2020-08-18 10:17:53 -04:00
infiinte-persistence
f3362c4e59 Publish: Make 'Channel' setting persistent. 
## Issue
Users are annoyed with the constant reset of the 'channel' setting in the Publish page.

## Changes
1. Revert the previous attempt in ff7b4092. The `usePersistedState` method is bad, as it will clash with the Redux value.
2. Implemented the persistence in Redux -- requires "https://github.com/lbryio/lbry-redux/pull/347".
 2020-08-18 09:25:57 -04:00
Sean Yesmunt
b58c9709e2 move click listener to app only for external links 2020-08-18 09:25:36 -04:00
Sean Yesmunt
0018fdaebc full width homepage 2020-08-18 09:25:36 -04:00
Sean Yesmunt
0ec569f020 only redirect on show page if in lbry.tv land 
Fixes crash when app is served from webcache.googleusercontent.com
 2020-08-17 23:42:16 -04:00
Baltazar Gomez
d2ca72e246 remove debug comment 2020-08-13 11:11:23 -04:00
Baltazar Gomez
c397297dfb remove debug comment 2020-08-13 11:11:23 -04:00
btzr-io
f881f3b1c6 fix WebFile flow type 2020-08-13 11:11:23 -04:00
btzr-io
2d47dd1780 fix fileReader flow errors 2020-08-13 11:11:23 -04:00
btzr-io
334f582a4d fix publishForm flow errors 2020-08-13 11:11:23 -04:00
infiinte-persistence
b49df1fc0a Fix translation failure on the Sidebar 
## Issue
The sidebar text stuck in English despite already translated.

I'm guessing the i18n macro only ran once for the global object.

## Change
Run the macro on the label when passing it to the `Button`.
 2020-08-13 11:10:08 -04:00
Sean Yesmunt
717de53eb1 force footer to sit below file page contents 2020-08-12 17:23:04 -04:00
Sean Yesmunt
abbaa8bf78 always batch resolve search results 2020-08-12 13:03:00 -04:00
Sean Yesmunt
2db2b870ff fix document layout and remove WaitUntilOnPage wrapper for related content 2020-08-12 11:47:00 -04:00
jessopb
1471511c03 Revert "check matomo and disable if necessary" 
This reverts commit f88b98ea62.
 2020-08-12 11:04:38 -04:00
Sean Yesmunt
a31f14b016 cleanup 2020-08-11 17:04:14 -04:00
Sean Yesmunt
692862c769 collapsable sidebar initial commit 2020-08-11 17:04:14 -04:00
jessop
f88b98ea62 check matomo and disable if necessary 2020-08-11 16:47:56 -04:00
Thomas Zarebczan
7b504b5fa7
update invalid symbols 2020-08-11 11:30:23 -04:00
jessop
c0be817960 support sdk feature for fast comments 2020-08-10 14:52:17 -04:00
Sean Yesmunt
2f995be794 use new buffer analytics api 2020-08-07 22:54:29 -04:00
infiinte-persistence
e5b1177644 Patch 37a1fd88: Sync selectedChannel only if the channel doesn't exist 
## Issue
The previous commit was over-doing the manual syncing, causing other usages like the Repost Modal to always reset to a different channel.

## Fix
Only do the manual syncing when the channel does not exist.
At this point, we could also just take `channel[0]` as the new value.
 2020-08-07 16:28:41 -04:00
Sean Yesmunt
e64d925086 fix alignment 2020-08-07 16:28:09 -04:00
Sean Yesmunt
1854710093 fix app crash when file name can't be found 2020-08-07 16:28:09 -04:00
Sean Yesmunt
c4e6605ada use button group as publish file header instead of title for better app parity 2020-08-07 16:28:09 -04:00
Baltazar Gomez
3da4df6b8f increase max chars limit of post editor 2020-08-05 21:37:00 -04:00
Baltazar Gomez
2089a0064f add new chars limit for post 2020-08-05 21:37:00 -04:00
jessop
5f5203a211 put file properties such as type and duration over thumb 2020-08-05 14:59:04 -04:00
infiinte-persistence
c75bab5979 Tip Modal: Don't do final submit when the intention is to create New Channel. 
## Issue
Fixes `4544 Channel-creation in "Tip|Support" Modal shouldn't submit LBC immediately`

## Changes
`Form` seems to have already tried to stop the propagation of `onSubmit`, so I'm not sure why it was still propagated.

Fix by using the same method used in the `CommentCreate`, which is simply to check for `CHANNEL_NEW` as the current selection.
 2020-08-05 13:01:29 -04:00
infiinte-persistence
37a1fd88e3 selectChannel: sync auto-resolved value during mounting. 
## Issue
Fixes `4621 Can't create Comments if you recently deleted a channel`

The `channel` that the parent passes in is from a persisted state. If the channel has been deleted, `<select>` will automatically resolve to another selectable value. However, `onChange` will not be called for this scenario, so we now have a mismatch.

## Changes
- Manually check if the value has been auto-resolved and report it to the parent.
- An extra `setTimeout` was needed. It seems like `onChannelChange` needs to be called after the first `useEffect` of the parent, otherwise the call has no effect.
 2020-08-05 12:59:54 -04:00
Baltazar Gomez
d64d278676 fix metadata not updating if post content doesn't change 2020-08-05 12:57:49 -04:00
jessop
ab56633eed prevent specific settings sync in config 2020-08-04 12:00:20 -04:00
Sean Yesmunt
42e989d0cc always use markdown editor for text posts 2020-08-04 11:49:12 -04:00
btzr-io
036aedd88d use redux to load post content 2020-08-04 11:49:12 -04:00
btzr-io
80e1965e46 prevent name change while editing and more fixes 2020-08-04 11:49:12 -04:00
btzr-io
8067793379 fix reselect file error 2020-08-04 11:49:12 -04:00
btzr-io
0f757bc101 fix typo 2020-08-04 11:49:12 -04:00
btzr-io
d93d97882b fix auto populate title logic 2020-08-04 11:49:12 -04:00
btzr-io
0b3fe001d0 autopopulate name from title 2020-08-04 11:49:12 -04:00
btzr-io
a565f7c5df fix labeling and rename some strings 2020-08-04 11:49:12 -04:00
btzr-io
18a6e7c7c1 generate temporal file for published story 2020-08-04 11:49:12 -04:00
btzr-io
c47c6f6034 fix story validation and content loading on web 2020-08-04 11:49:12 -04:00
btzr-io
c7ea2a14ad fix web version build 2020-08-04 11:49:12 -04:00
btzr-io
9fc2384649 fix changes not saving on edit mode 2020-08-04 11:49:12 -04:00
btzr-io
2ff1fc024c load story content from streaming url and improve form validation + minor fixes 2020-08-04 11:49:12 -04:00
btzr-io
a5d1746151 add in-app text and markdown publishing 2020-08-04 11:49:12 -04:00
Sean Yesmunt
80d8eeb4cf move ads in ClaimList behind SHOW_ADS config 2020-08-03 16:16:04 -04:00
Sean Yesmunt
e9b7d40456 redirect to claim if entering a valid claim_id in the search bar 2020-08-03 13:58:53 -04:00
Julie Sigwart
78784f3ab6 Additional change per @eatdostacos recommendation 2020-08-03 09:43:27 -04:00
jessopb
bc6cbfd5ee Revert "add imhere row at top" 
This reverts commit 8e73a02863.
 2020-08-01 16:55:01 -04:00
jessop
314fb22638 pull sync on nav to settings 2020-07-31 17:09:05 -04:00
Sean Yesmunt
c65afb201d fix embedded link for encoded url 2020-07-30 17:20:39 -04:00
Sean Yesmunt
8e73a02863 add imhere row at top 2020-07-30 17:13:01 -04:00
jessop
c33ce28805 sync settings generally based on navigation and settings paths 2020-07-30 17:05:30 -04:00
Sean Yesmunt
9acbdf9825 group comment notifications and clean up notification style 2020-07-30 16:15:02 -04:00
Sean Yesmunt
9fc3d10d4b update copy while abandoning 2020-07-30 13:53:40 -04:00
jessop
4dbfbbee00 disable file remove/abandon while abandoning 2020-07-30 13:53:40 -04:00
Sean Yesmunt
410c3b34a2 actually fix it 2020-07-30 11:09:15 -04:00
Sean Yesmunt
60e2d14e99 fix inline player style for mobile 2020-07-30 08:33:30 -04:00
infiinte-persistence
93d26a0ebb Fix 'Comments' being loaded on Autoplay despite not visible. 2020-07-29 17:56:38 -04:00
infiinte-persistence
0ab5ca080e Fix 'Related' being loaded on Autoplay despite not visible. 
## Issue
In the `Autoplay` case, if the `WaitUntilOnPage` has already opened the gates previously, the next video's Related will be loaded regardless of scroll position.

## Changes
Add a `lastUpdateDate` prop to `WaitUntilOnPage` to allow the parent to reset the gating state.

I don't really like the `lastUpdateDate` prop since it's purpose is not intuitive. Is there a standard way to do a "one-time trigger" from the parent?
 2020-07-29 17:56:38 -04:00
infiinte-persistence
c1dbb752d8 RecommendedContent: Move WaitUntilOnPage to within the component instead. 
This allows `RecommendedContent` to render the Card but with an empty list, so that the area isn't totally blank while waiting for `WaitUntilOnPage` to debounce.
 2020-07-29 17:56:38 -04:00
infiinte-persistence
1383b19817 WaitUntilOnPage: Debounce to fix false positives. 
There are cases where `WaitUntilOnPage` will incorrectly render, such as at the beginning if the upper components hasn't expanded to full size, so `WaitUntilOnPage` would be briefly visible.

Added a 300ms debounce to fix this, which would also improve scrolling performance a bit by doing less. Hopefully 300ms is enough for the upper components to inflate to full size.
 2020-07-29 17:56:38 -04:00
jessopb
2a5d87ee54
Merge pull request #4602 from lbryio/fix-syncThemeSetting 
trigger sync on theme change in nav menu
 2020-07-29 17:56:06 -04:00
Sean Yesmunt
ca89dab45f move claim uri under file/channel details 2020-07-29 13:04:58 -04:00
Sean Yesmunt
c9723082fe hide data network settings on web 2020-07-29 00:16:49 -04:00
jessop
b185857eb0 trigger sync on theme change in nav menu 2020-07-28 22:52:44 -04:00
Sean Yesmunt
3aad88ebe7 revert markdown size increases so no markdown is larger than card titles 2020-07-28 16:37:59 -04:00
Sean Yesmunt
0df388280e add search code from lbry-redux 2020-07-27 16:37:36 -04:00
jessop
142e695150 reverse child comments 2020-07-27 16:14:23 -04:00
Sean Yesmunt
d76ece04bc group similar settings in preparation of tabular settings page 2020-07-27 14:19:18 -04:00
jessop
0b3dbfc8f8 bump redux 2020-07-27 11:53:14 -04:00
jessop
d9bf72a351 all settings constants come from redux 
sync settings

backout nav cases and anon preference key

more robust backout header

put notificationSettings under backout bar

review changes
 2020-07-27 11:53:14 -04:00
Sean Yesmunt
e001906443 hide exact search result for SIMPLE_SITE 2020-07-27 10:48:05 -04:00
Sean Yesmunt
e10647b5a2 hide some file page buttons with SIMPLE_SITE flag 2020-07-27 10:48:05 -04:00
Sean Yesmunt
5ea87b76c9 use SITE_NAME from config for tos copy 2020-07-27 10:48:05 -04:00
Sean Yesmunt
312ff91994 add SIMPLE_SITE config value to disable complex UIs 2020-07-27 10:48:05 -04:00