Commit graph

72 commits

Author SHA1 Message Date
infinite-persistence
b733215c5f
PublishFile: fix render function violation (#1518)
* PublishFile: fix render function violation

Per doc:
> A React component should not cause side effects in other components during rendering.

Even in own render function (allowed to call), it should be avoided as it could cause infinite loops.

* PublishFile: fix useEffect infinite loop due to bad dependency

## Issue
One of the effects was adding an internal wrapper function as a dependency. As this is a functional component, the wrapper is re-created on every render and would spark the effect. That effect also updates redux (depending on the code path), so we end up in a loop.

## Change 1
Two options to fix the dependency:
1. Just remove the wrappers from the list, since we "know" it is essentially the same function (i.e. it's not function-variable that could point to something else at runtime).
2. Peek into the wrapper and determine what are the actual dependencies (usually props or data derived from props).

Solution 2 is the norm.

Aside: wrappers are usually the root-cause of incorrect dependencies, because they mask away the actual code. Need to always peek into it.

## Change 2
Next, change the dispatch-to-props map from function version to object version so that we have stable references to the actions. The object version is also preferred when we don't need to make any customizations to the actions.
2022-05-19 10:41:32 -04:00
Thomas Zarebczan
8144a9bb87 livestream new api
Re-used lots of Anthony's code + made fixes to a few areas including the publish page.

a

new videojs

video.js@7.18.1 + http-streaming@2.14.2

remove console log
2022-04-20 15:53:28 -04:00
Thomas Zarebczan
fc99d85efc Add max bitrate messaging
Disable form on error

Fix resetting
2022-02-01 17:26:09 -05:00
Thomas Zarebczan
92f0fd8745
More cleanup 2022-01-31 11:39:03 -05:00
Dan Peterson
cb562ef27d - fix issue where upload didn't show for users without replays
- better define if the form is in edit or create mode
- improve some naming conventions
2022-01-05 11:20:57 -05:00
Dan Peterson
6b809e76c4 Default to replay view when editing a liveststream 2022-01-05 11:20:57 -05:00
Dan Peterson
4ec4942d8c move publish source state up, when editing livestream only show scheduling option when source is none. 2022-01-05 11:20:57 -05:00
Dan Peterson
6da73f6bc4 Fix bug where upload tools may remain visible upon switching upload type, even when no option to upload is available. 2022-01-05 11:20:57 -05:00
Dan Peterson
7671d12e42 Update publish form when editing livestream + update to radios for liveststream release time 2022-01-05 11:20:57 -05:00
Thomas Zarebczan
ce37e06e10 Revert "Fix publish form when editing livestream (#565)"
This reverts commit da06c14e60.
2021-12-31 13:28:19 -05:00
Dan Peterson
da06c14e60
Fix publish form when editing livestream (#565)
* Update publish form when editing livestream + update to radios for liveststream release time

* Fix bug where upload tools may remain visible upon switching upload type, even when no option to upload is available.

* move publish source state up, when editing livestream only show scheduling option when source is none.

* Reset any set release time if switching to live stream mode.

* Update date/time cmpnts to reset any chnages they made on umount. Update schedule date/time cmpnt to clear release time when selecting anytime option.

* Additional filtering of internal tags

* Default to replay view when editing a liveststream
2021-12-31 11:20:54 -06:00
infinite-persistence
8deac56e40
Fix memo: isLivestream & isLivestreamActive 2021-11-16 11:52:35 +08:00
infinite-persistence
6492fe1c66
Upload: remove "download app" suggestion for large files. 2021-11-11 10:16:31 +08:00
Thomas Zarebczan
23525b0baa
FAQ stuff (#109) 2021-10-21 16:21:51 -04:00
Merge
30023422b8
Desktop cherry-pick: "7240 Integrate lbry redux and lbryinc" 2021-10-19 20:40:07 +08:00
infinite-persistence
fcea4005eb
Fix incorrect context for 'New' string 2021-09-21 16:48:20 +08:00
zeppi
91b908ad50 pubfile copy 2021-07-21 16:18:46 -04:00
zeppi
f5f3bf21ee bugfixes 2021-04-23 14:51:09 -04:00
zeppi
9b82f57006 livestream related publish fixes 2021-04-22 10:59:03 -04:00
Thomas Zarebczan
9689ef72a1
Odysee audio support (#5897) 2021-04-15 22:52:41 -04:00
zeppi
fe69ef2c90 allow non video selection when not odysee 2021-04-14 15:06:08 -04:00
jessopb
989126c603
Feat publish replays on master (#5863)
* provide livestream replay publish via url
2021-04-14 00:06:11 -04:00
zeppi
713109167c publish, edit, remote_url publish 2021-03-26 18:43:09 -04:00
Sean Yesmunt
0f24f3fdfd use has_no_source to check if claim is a livestream 2021-03-22 15:30:16 -07:00
Sean Yesmunt
da3e3c8404 add new 'livestream' publish mode 2021-03-22 15:30:03 -07:00
infiinte-persistence
8e9f6eb905 Bump lbry.tv upload limit to 4GB as well, plus lint fixes (matching Odysee) 2021-02-16 15:02:46 -05:00
infiinte-persistence
642e872296 Change upload limit to a variable to better handle site differences.
`const TV_PUBLISH_SIZE_LIMIT_STR_GB = '2';`

The above needs to be changed when merging into Odysee.
2021-02-16 15:02:46 -05:00
Sean Yesmunt
db87125dc8 refactor 'active' channel usage across the app 2021-02-11 10:45:34 -05:00
Sean Yesmunt
0c8c4938d9 move channel selection to top of publish form 2021-01-25 17:51:58 -05:00
Sean Yesmunt
6c6dacb195 fix strings 2020-10-23 01:53:09 -04:00
Sean Yesmunt
3b20104261 bump allowed upload size to 2gb on web 2020-10-20 13:13:08 -04:00
infiinte-persistence
d7a178d259 Str-context-split: "Post"
Splitting the context between "Markdown post" (noun) vs. "Post something" (verb)
2020-10-14 17:44:44 -04:00
infiinte-persistence
4294e0109a String: fix variable-resolving problems 2020-10-07 16:25:03 -04:00
Sean Yesmunt
00b23cbee4 moar alignment 2020-10-05 14:28:19 -04:00
Sean Yesmunt
248e7a1f9e fix lbry.tv strings 2020-10-05 10:39:24 -04:00
Sean Yesmunt
391cc76bd8 use consitent style for 'empty wallet' message on pages that require LBC 2020-09-29 17:12:32 -04:00
btzr-io
353c57a568 fix #4686 2020-08-25 09:51:13 -04:00
Baltazar Gomez
d2ca72e246 remove debug comment 2020-08-13 11:11:23 -04:00
btzr-io
f881f3b1c6 fix WebFile flow type 2020-08-13 11:11:23 -04:00
btzr-io
2d47dd1780 fix fileReader flow errors 2020-08-13 11:11:23 -04:00
Sean Yesmunt
e64d925086 fix alignment 2020-08-07 16:28:09 -04:00
Sean Yesmunt
1854710093 fix app crash when file name can't be found 2020-08-07 16:28:09 -04:00
Sean Yesmunt
c4e6605ada use button group as publish file header instead of title for better app parity 2020-08-07 16:28:09 -04:00
btzr-io
d93d97882b fix auto populate title logic 2020-08-04 11:49:12 -04:00
btzr-io
0b3fe001d0 autopopulate name from title 2020-08-04 11:49:12 -04:00
btzr-io
a565f7c5df fix labeling and rename some strings 2020-08-04 11:49:12 -04:00
btzr-io
c47c6f6034 fix story validation and content loading on web 2020-08-04 11:49:12 -04:00
btzr-io
2ff1fc024c load story content from streaming url and improve form validation + minor fixes 2020-08-04 11:49:12 -04:00
btzr-io
a5d1746151 add in-app text and markdown publishing 2020-08-04 11:49:12 -04:00
Sean Yesmunt
201417efcf Publish => Upload 2020-07-27 10:48:05 -04:00