Maximized window setting lost if restored from tray after minimizing #1199

New issue

Open

opened 2018-03-28 03:06:23 +02:00 by tzarebczan · 3 comments

tzarebczan commented

2018-03-28 03:06:23 +02:00

(Migrated from github.com)

The Issue

This seems to affect Windows only. If you have the LBRY app maximized, then minimize (or minimize + close), then try to restore from tray (double click, or right click > Open LBRY), the window returns to the previous un-maximized window size. This will also happen if you have LBRY minimized in such a state and then open a LBRY url like https://open.lbry.io/test

Steps to reproduce

Maximize LBRY window size
Minimize LBRY
Restore from tray
Notice the window is no longer maximized - it may be full screen or use whatever previous non-maximized you had.

Expected behaviour

Window show be restored to last used state, or maximized in this case

Actual behaviour

Window size is restored

System Configuration

LBRY Daemon version: 0.19.1
LBRY App version: 0.21.2
LBRY Installation ID:
Operating system:

Anything Else

Screenshots

## The Issue This seems to affect Windows only. If you have the LBRY app maximized, then minimize (or minimize + close), then try to restore from tray (double click, or right click > Open LBRY), the window returns to the previous un-maximized window size. This will also happen if you have LBRY minimized in such a state and then open a LBRY url like https://open.lbry.io/test ### Steps to reproduce 1. Maximize LBRY window size 2. Minimize LBRY 3. Restore from tray 4. Notice the window is no longer maximized - it may be full screen or use whatever previous non-maximized you had. ### Expected behaviour Window show be restored to last used state, or maximized in this case ### Actual behaviour Window size is restored ## System Configuration   - LBRY Daemon version: 0.19.1 - LBRY App version: 0.21.2 - LBRY Installation ID: - Operating system: ## Anything Else  ## Screenshots

QuirkyRobots commented

2018-03-28 03:35:45 +02:00

(Migrated from github.com)

Looks like it's missing these arguments...

isMaximized - Boolean

true if the window state was saved while the window was maximized. undefined if the state has not been saved yet.

isFullScreen - Boolean

true if the window state was saved while the window was in full screen mode. undefined if the state has not been saved yet.

Based off of this useful application...

https://github.com/szwacz/electron-boilerplate

#1057

Looks like it's missing these arguments... `isMaximized` - Boolean `true` if the window state was saved while the window was maximized. `undefined` if the state has not been saved yet. `isFullScreen` - Boolean `true` if the window state was saved while the window was in full screen mode. `undefined` if the state has not been saved yet. Based off of this useful application... https://github.com/szwacz/electron-boilerplate #1057

miikkatu commented

2018-03-28 08:26:53 +02:00

(Migrated from github.com)

I wasn't able to reproduce this on a Mac.

Here's a possibly helpful discussion about an issue with electron-window-state library when using maximized windows: https://github.com/mawie81/electron-window-state/issues/3

I wasn't able to reproduce this on a Mac. Here's a possibly helpful discussion about an issue with electron-window-state library when using maximized windows: https://github.com/mawie81/electron-window-state/issues/3

btzr-io commented

2021-07-27 20:59:21 +02:00

(Migrated from github.com)

Is this still a bug ?