Adding ability to view logs and open log directory #1569

2018-06-10T01:32:02+02:00

amitnndn commented

2018-06-10 01:32:02 +02:00

(Migrated from github.com)

#1556 - Adding ability to open logs and view log directory on the help page.
#741 - Fixing content address extending outside of the visible area in the card. (I am including this fix as a part of this PR since it is a small relatively small fix - 3 lines)

Changes

Made changes to the code to include a new section to giving users the option to open the log file or the directory that contains the log file.
Added some type declarations since eslint and flow checkers were failing on the file that I edited.
Added a word wrap while to card's h1 element so that long URLs do not extend outside the visible area.

Preview

#1556

#741

P.S: I have tested this only on macOS Sierra and theoretically should work on other operating systems as well. Let me know if it doesn't!

#1556 - Adding ability to open logs and view log directory on the help page. #741 - Fixing content address extending outside of the visible area in the card. (I am including this fix as a part of this PR since it is a small relatively small fix - 3 lines) ### Changes * Made changes to the code to include a new section to giving users the option to open the log file or the directory that contains the log file. * Added some type declarations since eslint and flow checkers were failing on the file that I edited. * Added a word wrap while to card's ```h1``` element so that long URLs do not extend outside the visible area. ### Preview #1556 ![screen shot 2018-06-09 at 6 30 04 pm](https://user-images.githubusercontent.com/4067311/41196955-308afbbc-6c13-11e8-9f14-6d754e846eb0.png) #741 ![screen shot 2018-06-10 at 5 15 46 pm](https://user-images.githubusercontent.com/4067311/41206925-f67f145c-6cd1-11e8-87eb-a716a9f734dd.png) P.S: I have tested this only on macOS Sierra and theoretically should work on other operating systems as well. Let me know if it doesn't!

tzarebczan commented

2018-06-10 21:37:38 +02:00

(Migrated from github.com)

@amitnndn thanks for the contribution! We'll get this reviewed shortly.

Similar to last time, please see https://lbry.io/faq/tips if you'd like a tip for your contribution :)

@amitnndn thanks for the contribution! We'll get this reviewed shortly. Similar to last time, please see https://lbry.io/faq/tips if you'd like a tip for your contribution :)

amitnndn commented

2018-06-11 00:19:05 +02:00

(Migrated from github.com)

Thanks, @tzarebczan! I fixed another very simple bug in the app and included that as a part of this PR. Did not want to go through the trouble of creating another PR for such a simple fix. Let me know if that is alright!

neb-b (Migrated from github.com) approved these changes 2018-06-11 03:37:21 +02:00

neb-b (Migrated from github.com) left a comment

Nice work on adding flow to this page. Just one question about the flowconfig

.flowconfig

					
				@ -20,5 +20,6 @@ module.name_mapper='^lbry\(.*\)$' -> '<PROJECT_ROOT>/src/renderer/lbry\1'

				module.name_mapper='^rewards\(.*\)$' -> '<PROJECT_ROOT>/src/renderer/rewards\1'

				module.name_mapper='^modal\(.*\)$' -> '<PROJECT_ROOT>/src/renderer/modal\1'

				module.name_mapper='^app\(.*\)$' -> '<PROJECT_ROOT>/src/renderer/app\1'

				module.name_mapper='^native\(.*\)$' -> '<PROJECT_ROOT>/src/renderer/native\1'

neb-b (Migrated from github.com) commented

2018-06-11 03:36:34 +02:00

Is there a reason this was added?

amitnndn (Migrated from github.com) reviewed 2018-06-12 03:07:18 +02:00

.flowconfig

					
				@ -20,5 +20,6 @@ module.name_mapper='^lbry\(.*\)$' -> '<PROJECT_ROOT>/src/renderer/lbry\1'

				module.name_mapper='^rewards\(.*\)$' -> '<PROJECT_ROOT>/src/renderer/rewards\1'

				module.name_mapper='^modal\(.*\)$' -> '<PROJECT_ROOT>/src/renderer/modal\1'

				module.name_mapper='^app\(.*\)$' -> '<PROJECT_ROOT>/src/renderer/app\1'

				module.name_mapper='^native\(.*\)$' -> '<PROJECT_ROOT>/src/renderer/native\1'

amitnndn (Migrated from github.com) commented

2018-06-12 03:07:18 +02:00

@seanyesmunt This was to resolve a flow error that was on in line

@seanyesmunt This was to resolve a flow error that was on [in line](https://github.com/amitnndn/lbry-app/blob/aa493f997bd99dd9ef620484bf3585d6604b4d0f/src/renderer/page/help/view.jsx#L6)

Sign in to join this conversation.

No reviewers

neb-b