LBRYCommunity/lbry-desktop

Channel page caching #1750

Merged

daovist merged 1 commit from channel-caching into master

2018-07-11 16:58:52 +02:00

daovist commented

2018-07-10 20:59:06 +02:00

(Migrated from github.com)

Issue #1255

Moves <BusyIndicator> to title bar.

Refactors contentList to show "No content found" only after fetch is complete; null while fetching.

There is still some chance that a user will click the wrong tile but the update is very fast and pretty smooth. The best way I see to prevent this is to disable navigation for ~1sec following the update. This could be done by adding a throttle property to the state along with corresponding actions, reducers, and a thunk in doNavigate, or migrating from thunks to middleware, both of which seem well beyond the scope of this issue.

Issue #1255 Moves `<BusyIndicator>` to title bar. Refactors `contentList` to show "No content found" only after fetch is complete; `null` while fetching. ![channel page fetching](https://user-images.githubusercontent.com/34498824/42529216-e106674c-844b-11e8-84db-6e26c3fa2957.png) There is still some chance that a user will click the wrong tile but the update is very fast and pretty smooth. The best way I see to prevent this is to disable navigation for ~1sec following the update. This could be done by adding a throttle property to the state along with corresponding actions, reducers, and a thunk in doNavigate, or migrating from thunks to middleware, both of which seem well beyond the scope of this issue.

neb-b (Migrated from github.com) requested changes 2018-07-11 04:58:57 +02:00

neb-b (Migrated from github.com) left a comment

Two very small changes.

Two very small changes.

src/renderer/page/channel/view.jsx

neb-b (Migrated from github.com) commented

2018-07-11 04:58:05 +02:00

maybe

...
) : !fetching && <span className="empty">{__('No content found.')}</span>;

To avoid the nested ternarys

maybe ``` ... ) : !fetching && <span className="empty">{__('No content found.')}</span>; ``` To avoid the nested ternarys

neb-b (Migrated from github.com) commented

2018-07-11 04:58:35 +02:00

{!fetching && <BusyIndicator />}

`{!fetching && <BusyIndicator />}`

neb-b commented

2018-07-11 04:59:11 +02:00

(Migrated from github.com)

This is great. So much smoother.

This is great. So much smoother.

daovist commented

2018-07-11 15:15:34 +02:00

(Migrated from github.com)

I also cleaned up types in <BusyIndicator>.

I also cleaned up types in `<BusyIndicator>`.

neb-b (Migrated from github.com) approved these changes 2018-07-11 16:58:44 +02:00

Sign in to join this conversation.

No reviewers

No labels

area: discovery

area: installer

area: livestream

area: performance

area: subscriptions

feature request

first-timers-only

good first issue

merge when green

needs: exploration

needs: grooming

needs: priority

needs: tech design

priority: blocker

priority: medium

protocol dependent

type: discussion

type: improvement

type: new feature

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#1750

No description provided.