LBRYCommunity/lbry-desktop
1
0
Fork 0
Code Issues 596 Pull requests 6 Projects Releases 238 Packages Wiki Activity

File viewer v2 #1826

Merged
btzr-io merged 17 commits from fix-viewer into master 2018-08-06 03:53:57 +02:00
Conversation 7 Commits 17 Files changed 26 +961 -165
btzr-io commented 2018-07-27 02:32:06 +02:00 (Migrated from github.com)
Copy link

Changes (WIP)

  • Closes: Better preview for content #620
  • Closes: Use router pattern for rendering file viewer (#1544)
  • Temp solution for: Add csv and json viewer (#1410)
  • Markdown viewer. (md, markdown)
  • Plain-text files and code snippets viewer (txt, json, csv, xml, log, yml).
  • Docx viewer (text only)
  • Html viewer. (iframe sandbox)
  • Implement syntax highlighter.
  • Fix description field fullscreen styles 77cfcc84a8.
  • Fix CodeMirror context menu be9c16cbde.
  • Choose a CodeMirror theme (light / dark).
  • Refactoring of fileSource logic.
  • Problem with search auto-complete menu when scrolling over file viewer #1847

Test

lbry://docxfile#a035152583aaa2ed50e6ab12174839a2cc2c0227

lbry://pdffile#1ec33dbcdf61c051b136354a9640f5dc25b04b96

lbry://csvfile#3eb2ae7de726f21318fc61c6794960f7fc4d81da

lbry://json#5fd9811240848eeae120166d8c57fc8e81dc6497

lbry://txtfile#13475689e84cd6c3ef43a279c0e8bfa6ed5c312f

lbry://index#6e477eded9468613c9c5b45eb58662ea302bccea

lbry://mdfile#24e737e03df62930ac4bd44151c818b3933a0381

bry://javascriptfile#c286d02c447aecb9cbd83b6f3ee6811e8fcc3d68

### Changes (WIP) - [x] Closes: Better preview for content #620 - [x] Closes: Use router pattern for rendering file viewer ([#1544](https://github.com/lbryio/lbry-desktop/pull/1544)) - [x] Temp solution for: Add csv and json viewer ([#1410](https://github.com/lbryio/lbry-desktop/pull/1410)) - [x] Markdown viewer. (md, markdown) - [x] Plain-text files and code snippets viewer (txt, json, csv, xml, log, yml). - [x] Docx viewer (text only) - [x] Html viewer. (iframe sandbox) - [x] Implement syntax highlighter. - [x] Fix description field fullscreen styles https://github.com/lbryio/lbry-desktop/pull/1826/commits/77cfcc84a81f1e629895d7f2019a318d1a11de30. - [x] Fix `CodeMirror` context menu https://github.com/lbryio/lbry-desktop/pull/1671/commits/be9c16cbdec789b557da118b1fc09b950be7171a. - [x] Choose a `CodeMirror` theme (light / dark). - [x] Refactoring of fileSource logic. - [x] Problem with search auto-complete menu when scrolling over file viewer #1847 ### Test > lbry://docxfile#a035152583aaa2ed50e6ab12174839a2cc2c0227 > lbry://pdffile#1ec33dbcdf61c051b136354a9640f5dc25b04b96 > lbry://csvfile#3eb2ae7de726f21318fc61c6794960f7fc4d81da > lbry://json#5fd9811240848eeae120166d8c57fc8e81dc6497 > lbry://txtfile#13475689e84cd6c3ef43a279c0e8bfa6ed5c312f > lbry://index#6e477eded9468613c9c5b45eb58662ea302bccea > lbry://mdfile#24e737e03df62930ac4bd44151c818b3933a0381 > bry://javascriptfile#c286d02c447aecb9cbd83b6f3ee6811e8fcc3d68
skhameneh (Migrated from github.com) reviewed 2018-07-27 02:32:06 +02:00
skhameneh commented 2018-07-27 03:57:43 +02:00 (Migrated from github.com)
Copy link

Looks good, nice work!
I'll need to take a closer look and test this out; @seanyesmunt also had some MD changes as well that I need to test and check for conflicts.

Looks good, nice work! I'll need to take a closer look and test this out; @seanyesmunt also had some MD changes as well that I need to test and check for conflicts.
👍 2
btzr-io commented 2018-07-28 01:54:10 +02:00 (Migrated from github.com)
Copy link

https://github.com/codemirror/CodeMirror/issues/5484

https://github.com/codemirror/CodeMirror/issues/5484
kauffj commented 2018-07-30 18:38:27 +02:00 (Migrated from github.com)
Copy link

FYI @btzr-io @seanyesmunt is on vacation until Wednesday

FYI @btzr-io @seanyesmunt is on vacation until Wednesday
👍 1
neb-b commented 2018-08-03 16:50:05 +02:00 (Migrated from github.com)
Copy link

Will test this today

Will test this today
👍 1
neb-b commented 2018-08-03 20:04:15 +02:00 (Migrated from github.com)
Copy link

Just added this to test lbry://javascriptfile#c286d02c447aecb9cbd83b6f3ee6811e8fcc3d68

Just added this to test lbry://javascriptfile#c286d02c447aecb9cbd83b6f3ee6811e8fcc3d68
👍 1
neb-b (Migrated from github.com) requested changes 2018-08-03 20:04:43 +02:00
neb-b (Migrated from github.com) left a comment
Copy link

This is so cool. 🙂

One minor comment. Can you add a changelog too? Then it's ready to be merged.

This is so cool. :slightly_smiling_face: One minor comment. Can you add a changelog too? Then it's ready to be merged.
src/renderer/scss/component/_file-render.scss
neb-b (Migrated from github.com) commented 2018-08-03 19:41:23 +02:00
Copy link

padding in this file should use the spacing variables

padding in this file should use the spacing variables
neb-b (Migrated from github.com) reviewed 2018-08-03 20:05:54 +02:00
src/renderer/scss/component/_file-render.scss
neb-b (Migrated from github.com) commented 2018-08-03 20:05:54 +02:00
Copy link

Whoops forgot to add this comment. This z-index seems a little weird. Is it needed?

Whoops forgot to add this comment. This `z-index` seems a little weird. Is it needed?
btzr-io (Migrated from github.com) reviewed 2018-08-03 20:16:51 +02:00
src/renderer/scss/component/_file-render.scss
btzr-io (Migrated from github.com) commented 2018-08-03 20:16:51 +02:00
Copy link

not sure let me check, probably not 👍

not sure let me check, probably not :+1:
btzr-io commented 2018-08-03 20:59:20 +02:00 (Migrated from github.com)
Copy link

@seanyesmunt ok done 👍

@seanyesmunt ok done :+1:
❤️ 1
tzarebczan commented 2018-08-03 23:01:51 +02:00 (Migrated from github.com)
Copy link

On lbry://@jiggytom#e48d2b50501159034f68d53321f67b8aa5b1d771/epubfile - a non-supported file, I'm missing a view button. Not sure if it should still say view, but lbry://zipfile does and it's an unsupported file. This isn't related to this PR, but thought i'd mention it as we are touching that code.

Otherwise, I tested a bunch of the videos and things look good! Thanks again for the contribution @btzr-io !

On lbry://@jiggytom#e48d2b50501159034f68d53321f67b8aa5b1d771/epubfile - a non-supported file, I'm missing a view button. Not sure if it should still say view, but lbry://zipfile does and it's an unsupported file. This isn't related to this PR, but thought i'd mention it as we are touching that code. Otherwise, I tested a bunch of the videos and things look good! Thanks again for the contribution @btzr-io !
neb-b (Migrated from github.com) approved these changes 2018-08-06 03:53:49 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
skhameneh
neb-b
Labels
Clear labels   
accessibility

   
app-parity

   
area: creator

   
area: daemon

   
area: design

   
area: devops

   
area: discovery

   
area: docs

   
area: installer

   
area: internal

   
area: livestream

   
area: performance

   
area: proposal

Work is part of a proposal

  
area: reposts

   
area: rewards

   
area: search

   
area: security

   
area: subscriptions

   
area: sync

   
area: ux

   
area: viewer

   
area: wallet

   
BEAMER

Beamer is waiting on you!

  
channel

   
comments

   
community PR

   
consider soon

Discuss this issue at the next planning meeting, then remove this label

  
core team

   
css

   
dependencies

   
electron

   
Epic

   
feature request

   
first-timers-only

   
good first issue

   
hacktoberfest

Welcome to Hacktoberfest

  
help wanted

   
hub-dependent

   
icebox

Long-term storage

  
Invalid

   
level: 0

   
level: 1

No knowledge of the existing code required

  
level: 2

Some knowledge of the existing code is recommended

  
level: 3

Significant knowledge of the existing code is recommended

  
level: 4

Intimate knowledge of the existing code is recommended

  
merge when green

   
needs: exploration

Solution unclear, needs research

  
needs: grooming

Issue needs to be groomed before work can start

  
needs: priority

Priority level needs to be defined

  
needs: repro

Issue needs step-by-step instructions on how to reproduce in latest code

  
needs: tech design

Needs technical design signoff before implementation can begin

  
notifications

   
odysee

   
on hold

Temporarily paused

  
playlists

   
priority: blocker

Issue is blocking release, do ASAP

  
priority: high

Work needs to be moved into sprint ASAP

  
priority: low

Work should be done but can stay in the backlog for now

  
priority: medium

Work needs to be done within 2-3 sprints

  
protocol dependent

   
recsys

   
redesign

general redesign not prioritize for anyone release

  
regression

   
resilience

   
sdk dependent

Requires work on lbry-sdk repo

  
Tom's Wishlist

   
trending

   
type: bug

Existing functionality is wrong or broken

  
type: discussion

A conversation. No specific changes requested

  
type: improvement

Existing (or partially existing) functionality needs to be changed

  
type: new feature

New functionality that does not exist yet

  
type: refactor

Minimal user-visible changes, but significant internal work

  
type: task

Either work that's not related to the code, or a small chore that does not fit into other categories

  
type: testing

Solution needs additional user testing

  
unplanned

Work that was not planned into the spirnt, took priority over planned work

  
windows
No labels
accessibility
app-parity
area: creator
area: daemon
area: design
area: devops
area: discovery
area: docs
area: installer
area: internal
area: livestream
area: performance
area: proposal
area: reposts
area: rewards
area: search
area: security
area: subscriptions
area: sync
area: ux
area: viewer
area: wallet
BEAMER
channel
comments
community PR
consider soon
core team
css
dependencies
electron
Epic
feature request
first-timers-only
good first issue
hacktoberfest
help wanted
hub-dependent
icebox
Invalid
level: 0
level: 1
level: 2
level: 3
level: 4
merge when green
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
notifications
odysee
on hold
playlists
priority: blocker
priority: high
priority: low
priority: medium
protocol dependent
recsys
redesign
regression
resilience
sdk dependent
Tom's Wishlist
trending
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
windows
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#1826
No description provided.
Delete branch "fix-viewer"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?